Skip to content

Invalid use of "find the topmost popover ancestor" #245

Open
@theIDinside

Description

@theIDinside

Recently a new PR was pulled in: Add popover=hint #9778

It adds another argument to the find the topmost popover ancestor:

  1. a Node newPopoverOrTopLayerElement
  2. a list popoverList <- this one
  3. an HTML element or null invoker
  4. a boolean isPopover

However, to fullscreen an element we are still only using the old three argument-version.

@josepharhar wrote the pull request for the new popover attribute value so I guess my question is what would be the parameter for the list in the Fullscreen API scenario? I'm not well versed in how popover works or is intended to work, but I take that the specific change for the PR is to add tooltip-like stuff, and so, I wonder, should all these be auto closed and only have the "manual" popovers left open or should it be auto? But that's just my initial guesses after having peaked at it for 5 minutes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions