From a9f3ace17b1406527d261e0a9aac23a9d2ca0fa9 Mon Sep 17 00:00:00 2001 From: pg0404-44 Date: Wed, 18 Mar 2026 22:28:12 +0530 Subject: [PATCH 1/4] Add personal contribution note to README Added a personal note about the contribution. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bbee0f9..7eb4114 100644 --- a/README.md +++ b/README.md @@ -464,6 +464,6 @@ Example qqq.json: ``` In MediaWiki and its hundreds of extensions, message documentation is a strictly followed practice. There is a grunt task to check whether all messages are documented or not. See https://www.npmjs.org/package/grunt-banana-checker - +This is my first contribution. [npm]: https://img.shields.io/npm/v/@wikimedia/jquery.i18n.svg [npm-url]: https://npmjs.com/package/@wikimedia/jquery.i18n From d7bb9061b5470dc753e068eaf65bafe379974750 Mon Sep 17 00:00:00 2001 From: pg0404-44 Date: Wed, 18 Mar 2026 22:29:33 +0530 Subject: [PATCH 2/4] Update README.md From e7904b3ceb82e0ddaee3acb989f899328623a83f Mon Sep 17 00:00:00 2001 From: pg0404-44 Date: Thu, 26 Mar 2026 23:39:44 +0530 Subject: [PATCH 3/4] Fix shared message object reference across locales --- src/jquery.i18n.messagestore.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/jquery.i18n.messagestore.js b/src/jquery.i18n.messagestore.js index ba81ce5..b0c7b1b 100644 --- a/src/jquery.i18n.messagestore.js +++ b/src/jquery.i18n.messagestore.js @@ -100,13 +100,15 @@ * @param {string} locale * @param {Object} messages */ - set: function ( locale, messages ) { - if ( !this.messages[ locale ] ) { - this.messages[ locale ] = messages; - } else { - this.messages[ locale ] = $.extend( this.messages[ locale ], messages ); - } - }, + set: function ( locale, messages ) { + var clonedMessages = $.extend( true, {}, messages ); + + if ( !this.messages[ locale ] ) { + this.messages[ locale ] = clonedMessages; + } else { + this.messages[ locale ] = $.extend( true, {}, this.messages[ locale ], clonedMessages ); + } +}, /** * From 95d47c8cc2404bb1b452d3c5625468b1f95a3fd7 Mon Sep 17 00:00:00 2001 From: pg0404-44 Date: Fri, 27 Mar 2026 10:41:10 +0530 Subject: [PATCH 4/4] Fix shared message object reference across locales --- src/jquery.i18n.messagestore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jquery.i18n.messagestore.js b/src/jquery.i18n.messagestore.js index b0c7b1b..99b1ba0 100644 --- a/src/jquery.i18n.messagestore.js +++ b/src/jquery.i18n.messagestore.js @@ -100,7 +100,7 @@ * @param {string} locale * @param {Object} messages */ - set: function ( locale, messages ) { + set: function ( locale, messages ) { var clonedMessages = $.extend( true, {}, messages ); if ( !this.messages[ locale ] ) {