-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
csp: improve docs #12812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csp: improve docs #12812
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some tiny editing questions!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @ematipico !
Would it make sense to update line 149 to read something like:
A list of valid sources for the `script-src` and `style-src` directives, including [values for subclasses](#adding-values-for-subclasses).
I don't know if we can/need to say subclasses of what, or what the proper terminology is (directive subclasses?)
or
A list of valid sources for the `script-src` and `style-src` directives, including [subclasses](#directive-subclasses).
If anything like that makes sense, then I think having that statement in the opening line and a link to a section heading makes sense and is helpful. If there's no good way to do that, then I think this is good as is!
|
@sarah11918 I applied your suggestion |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 🙌
Description (required)
Some users have asked how, with CSP, can support
script-src-*andstyle-src-*.Well, the thing is, we already do! However, this information was "hidden", in the sense that we don't explicitly state that
resourcescan be used to add the values supported by those directives.This was due to my lack of knowledge.
This PR expands the docs of
resources.Related issues & labels (optional)