From 01caf0c67b654a982513ba04b3832573a60d7e0c Mon Sep 17 00:00:00 2001 From: Roman Proskuryakov Date: Sat, 2 Nov 2019 01:42:00 +0300 Subject: [PATCH 1/3] Update relationship to Tokio --- README.md | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 10ff7cbb..08b0b84f 100644 --- a/README.md +++ b/README.md @@ -125,10 +125,10 @@ fn main() -> io::Result<()> { ## Relationship to Tokio Romio is a fork of another Rust project called [Tokio][tokio]. The Tokio -project uses an older version of the futures API which is not compatible with +project would use an older version of the futures API which was not compatible with the new "async/await" syntax. In order to enable people to experiment with -"async/await," Romio ports parts of the tokio project to the newer futures API -which is compatible with that syntax. +"async/await," Romio ported parts of the tokio project to the newer futures API +which was compatible with that syntax. Romio is not a complete port of tokio: it only contains a small part of the entire tokio code base: the IO primitives necessary for writing asynchronous @@ -137,15 +137,11 @@ instead, all async IO primitives use the default reactor set up - and it doesn't contain many other parts of tokio that are not directly related to asynchronous IO. -You should use romio if you want to experiment with writing networking code -using the new async/await syntax. However, romio is not directly compatible -with other libraries built on top of tokio - like hyper, actix, and tower - so -if you want to use those, romio might not be a good fit for you. - -Romio is intended to unblock people trying to experiment with async/await, -which is why it exposes such a minimal API. It's not intended to be a full -fledged "competitor" to tokio, which we expect will eventually move to the -newer futures API and be compatible with async/await syntax. +Romio was intended to unblock people trying to experiment with async/await, +so that it exposed such a minimal API. It was not intended to be a full +fledged "competitor" to tokio, which we expected would eventually move to the +newer futures API and be compatible with async/await syntax. Since async/await +landed to stable, there is no need to use romio to experiment with this feature. ## License From 667d2a88b9e81afad36bd79241ff3507addaaeea Mon Sep 17 00:00:00 2001 From: Roman Proskuryakov Date: Sat, 2 Nov 2019 01:52:30 +0300 Subject: [PATCH 2/3] Fix review notes Co-Authored-By: Benjamin Saunders --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 08b0b84f..8539a254 100644 --- a/README.md +++ b/README.md @@ -125,7 +125,7 @@ fn main() -> io::Result<()> { ## Relationship to Tokio Romio is a fork of another Rust project called [Tokio][tokio]. The Tokio -project would use an older version of the futures API which was not compatible with +project once used an older version of the futures API which was not compatible with the new "async/await" syntax. In order to enable people to experiment with "async/await," Romio ported parts of the tokio project to the newer futures API which was compatible with that syntax. From e260b97bfe10cc1cd3966a403521a5318d843b1c Mon Sep 17 00:00:00 2001 From: Roman Proskuryakov Date: Sat, 2 Nov 2019 01:56:55 +0300 Subject: [PATCH 3/3] Fix review notes Co-Authored-By: Benjamin Saunders --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 8539a254..7d2a6ed4 100644 --- a/README.md +++ b/README.md @@ -139,9 +139,9 @@ asynchronous IO. Romio was intended to unblock people trying to experiment with async/await, so that it exposed such a minimal API. It was not intended to be a full -fledged "competitor" to tokio, which we expected would eventually move to the -newer futures API and be compatible with async/await syntax. Since async/await -landed to stable, there is no need to use romio to experiment with this feature. +fledged "competitor" to tokio, which has now moved to the +newer futures API and became compatible with async/await syntax. Since async/await +landed in stable, there is no need to use romio to experiment with this feature. ## License