Rename 'removeDuplicateBlogs' to something more generic and move it outside of the Thread object

Author: daniloercoli

WordPress/src/main/java/org/wordpress/android/ui/reader/services/update/ReaderUpdateLogic.java

@@ -2,6 +2,8 @@
 
 import android.content.Context;
 
+import androidx.annotation.NonNull;
+
 import com.android.volley.VolleyError;
 import com.wordpress.rest.RestRequest;
 
@@ -322,13 +324,12 @@ private void handleFollowedBlogsResponse(final JSONObject jsonObject) {
             public void run() {
                 ReaderBlogList serverBlogs = ReaderBlogList.fromJson(jsonObject);
                 ReaderBlogList localBlogs = ReaderBlogTable.getFollowedBlogs();
-                // Remove duplicates from the server blogs list only if local and remote  lists don't match.
-                if (serverBlogs.size() != localBlogs.size()) {
-                    // This is required because under rare circumstances the server can return duplicates.
-                    // We could have modified the function isSameList to eliminate the length check,
-                    // but it's better to keep it separate since we aim to remove this check as soon as possible.
-                    removeDuplicateFromServerResponse(serverBlogs);
-                }
+
+                // This is required because under rare circumstances the server can return duplicates.
+                // We could have modified the function isSameList to eliminate the length check,
+                // but it's better to keep it separate since we aim to remove this check as soon as possible.
+                removeDuplicateBlogs(serverBlogs);
+
                 if (!localBlogs.isSameList(serverBlogs)) {
                     // always update the list of followed blogs if there are *any* changes between
                     // server and local (including subscription count, description, etc.)
@@ -345,20 +346,26 @@ public void run() {
 
                 taskCompleted(UpdateTask.FOLLOWED_BLOGS);
             }
-            /* This method remove duplicate ReaderBlog from list. */
-            private void removeDuplicateFromServerResponse(ReaderBlogList serverBlogs) {
-                for (int i = 0; i < serverBlogs.size(); i++) {
-                    ReaderBlog outer = serverBlogs.get(i);
-                    for (int j = serverBlogs.size() - 1; j > i; j--) {
-                        ReaderBlog inner = serverBlogs.get(j);
-                        if (outer.blogId == inner.blogId) {
-                            // If the 'id' property is the same,
-                            // remove the later object to avoid duplicates
-                            serverBlogs.remove(j);
-                        }
-                    }
+        }.start();
+    }
+
+    /**
+     * Remove duplicates from the input list.
+     * Note that this method modifies the input list.
+     *
+     * @param blogList The list of blogs to remove duplicates from.
+     */
+    private void removeDuplicateBlogs(@NonNull ReaderBlogList blogList) {
+        for (int i = 0; i < blogList.size(); i++) {
+            ReaderBlog outer = blogList.get(i);
+            for (int j = blogList.size() - 1; j > i; j--) {
+                ReaderBlog inner = blogList.get(j);
+                if (outer.blogId == inner.blogId) {
+                    // If the 'id' property is the same,
+                    // remove the later object to avoid duplicates
+                    blogList.remove(j);
                 }
             }
-        }.start();
+        }
     }
 }