Skip to content

Commit 621ccfb

Browse files
authored
Merge pull request #19981 from wordpress-mobile/fix/target-sdk-14-foreground-service-types
[Fix] Add targetSdk 34 foreground service types to our services.
2 parents c9602d9 + adf8b49 commit 621ccfb

File tree

1 file changed

+38
-19
lines changed

1 file changed

+38
-19
lines changed

WordPress/src/main/AndroidManifest.xml

Lines changed: 38 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -851,88 +851,105 @@
851851
<service
852852
android:name=".ui.reader.services.update.ReaderUpdateService"
853853
android:exported="false"
854-
android:label="Reader Update Service" />
854+
android:label="Reader Update Service"
855+
android:foregroundServiceType="dataSync"/>
855856
<service
856857
android:name=".ui.reader.services.update.ReaderUpdateJobService"
857858
android:permission="android.permission.BIND_JOB_SERVICE"
858859
android:exported="false"
859-
android:label="Reader Update JobService" />
860+
android:label="Reader Update JobService"
861+
android:foregroundServiceType="dataSync"/>
860862

861863
<service
862864
android:name=".ui.reader.services.discover.ReaderDiscoverService"
863865
android:exported="false"
864-
android:label="Reader Discover Service" />
866+
android:label="Reader Discover Service"
867+
android:foregroundServiceType="dataSync"/>
865868
<service
866869
android:name=".ui.reader.services.discover.ReaderDiscoverJobService"
867870
android:permission="android.permission.BIND_JOB_SERVICE"
868871
android:exported="false"
869-
android:label="Reader Discover JobService" />
872+
android:label="Reader Discover JobService"
873+
android:foregroundServiceType="dataSync"/>
870874

871875
<service
872876
android:name=".ui.reader.services.post.ReaderPostService"
873877
android:exported="false"
874-
android:label="Reader Post Service" />
878+
android:label="Reader Post Service"
879+
android:foregroundServiceType="dataSync"/>
875880
<service
876881
android:name=".ui.reader.services.post.ReaderPostJobService"
877882
android:permission="android.permission.BIND_JOB_SERVICE"
878883
android:exported="false"
879-
android:label="Reader Post JobService" />
884+
android:label="Reader Post JobService"
885+
android:foregroundServiceType="dataSync"/>
880886

881887
<service
882888
android:name=".ui.reader.services.search.ReaderSearchService"
883889
android:exported="false"
884-
android:label="Reader Search Service" />
890+
android:label="Reader Search Service"
891+
android:foregroundServiceType="dataSync"/>
885892
<service
886893
android:name=".ui.reader.services.search.ReaderSearchJobService"
887894
android:permission="android.permission.BIND_JOB_SERVICE"
888895
android:exported="false"
889-
android:label="Reader Search Job Service" />
896+
android:label="Reader Search Job Service"
897+
android:foregroundServiceType="dataSync"/>
890898

891899
<service
892900
android:name=".ui.reader.services.comment.ReaderCommentService"
893901
android:exported="false"
894-
android:label="Reader Comment Service" />
902+
android:label="Reader Comment Service"
903+
android:foregroundServiceType="dataSync"/>
895904

896905
<service
897906
android:name=".ui.suggestion.service.SuggestionService"
898907
android:exported="false"
899-
android:label="Suggestion Service" />
908+
android:label="Suggestion Service"
909+
android:foregroundServiceType="dataSync"/>
900910
<service
901911
android:name=".push.NotificationsProcessingService"
902912
android:exported="false"
903-
android:label="Notifications Quick Actions processing Service" />
913+
android:label="Notifications Quick Actions processing Service"
914+
android:foregroundServiceType="dataSync"/>
904915

905916
<service
906917
android:name=".ui.notifications.services.NotificationsUpdateService"
907918
android:exported="false"
908-
android:label="Notifications Update Service" />
919+
android:label="Notifications Update Service"
920+
android:foregroundServiceType="dataSync"/>
909921
<service
910922
android:name=".ui.notifications.services.NotificationsUpdateJobService"
911923
android:permission="android.permission.BIND_JOB_SERVICE"
912924
android:exported="false"
913-
android:label="Notifications Update Job Service" />
925+
android:label="Notifications Update Job Service"
926+
android:foregroundServiceType="dataSync"/>
914927

915928
<service
916929
android:name=".util.analytics.service.InstallationReferrerService"
917930
android:exported="true"
918931
android:permission="com.google.android.finsky.permission.BIND_GET_INSTALL_REFERRER_SERVICE"
919-
android:label="Installation Referrer Service" />
932+
android:label="Installation Referrer Service"
933+
android:foregroundServiceType="dataSync"/>
920934

921935
<service
922936
android:name=".util.analytics.service.InstallationReferrerJobService"
923937
android:permission="android.permission.BIND_JOB_SERVICE"
924938
android:exported="false"
925-
android:label="Installation Referrer Service" />
939+
android:label="Installation Referrer Service"
940+
android:foregroundServiceType="dataSync"/>
926941

927942
<service
928943
android:name=".login.LoginWpcomService"
929944
android:exported="false"
930-
android:label="Login to WPCOM Service" />
945+
android:label="Login to WPCOM Service"
946+
android:foregroundServiceType="dataSync"/>
931947

932948
<service
933949
android:name=".ui.sitecreation.services.SiteCreationService"
934950
android:exported="false"
935-
android:label="Site Creation Service" />
951+
android:label="Site Creation Service"
952+
android:foregroundServiceType="dataSync"/>
936953

937954
<!-- Samsung multiwindow support -->
938955
<uses-library
@@ -1006,7 +1023,8 @@
10061023
<receiver android:name=".ui.notifications.DismissNotificationReceiver" />
10071024
<service
10081025
android:name=".ui.stats.refresh.lists.widget.WidgetService"
1009-
android:permission="android.permission.BIND_REMOTEVIEWS" />
1026+
android:permission="android.permission.BIND_REMOTEVIEWS"
1027+
android:foregroundServiceType="dataSync"/>
10101028

10111029
<activity
10121030
android:name=".ui.stats.refresh.lists.widget.views.StatsViewsWidgetConfigureActivity"
@@ -1066,7 +1084,8 @@
10661084

10671085
<service
10681086
android:name=".push.GCMMessageService"
1069-
android:exported="false" >
1087+
android:exported="false"
1088+
android:foregroundServiceType="dataSync">
10701089
<intent-filter>
10711090
<action android:name="com.google.firebase.MESSAGING_EVENT" />
10721091
</intent-filter>

0 commit comments

Comments
 (0)