Skip to content

Commit 7508d71

Browse files
authored
Merge pull request #20346 from wordpress-mobile/origin/fix/20287-talkback-stats-crash
Fix crashes with Traffic tab when Talkback enabled
2 parents b355f63 + 8cae948 commit 7508d71

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficBarChartViewHolder.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,23 @@ class TrafficBarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
6969

7070
private fun BarChart.draw(item: BlockListItem.TrafficBarChartItem): Int {
7171
resetChart()
72+
val dataSet = getData(item)
73+
val dataSets = mutableListOf<IBarDataSet>()
74+
dataSets.add(dataSet)
7275

73-
data = BarData(getData(item))
76+
data = BarData(dataSets)
7477

7578
configureChartView()
7679
configureYAxis(item)
7780
configureXAxis(item)
7881

7982
invalidate()
80-
return data.dataSets.size
83+
return dataSet.entryCount
8184
}
8285

8386
private fun hasData(entries: List<Bar>) = entries.isNotEmpty() && entries.any { it.value > 0 }
8487

85-
private fun getData(item: BlockListItem.TrafficBarChartItem): List<IBarDataSet> {
88+
private fun getData(item: BlockListItem.TrafficBarChartItem): IBarDataSet {
8689
val minColumnCount = 5
8790

8891
val graphWidth = DisplayUtils.pxToDp(chart.context, chart.width)
@@ -97,10 +100,8 @@ class TrafficBarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
97100
buildEmptyDataSet(chart.context, cutEntries.size)
98101
}
99102
item.onBarChartDrawn?.invoke(dataSet.entryCount)
100-
val dataSets = mutableListOf<IBarDataSet>()
101-
dataSets.add(dataSet)
102103

103-
return dataSets
104+
return dataSet
104105
}
105106

106107
private fun configureChartView() {

WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficOverviewUseCase.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ class TrafficOverviewUseCase(
282282
lowerGranularity
283283
)
284284
if (period != null && period != "empty") {
285-
val selectedDate = statsDateFormatter.parseStatsDate(statsGranularity, period)
285+
val selectedDate = statsDateFormatter.parseStatsDate(lowerGranularity, period)
286286
selectedDateProvider.selectDate(
287287
selectedDate,
288288
lowerGranularity

0 commit comments

Comments
 (0)