build: bump kotlinpoet to 1.16.0

wzieba · wzieba · commit cf2a4ccd1c4b · 2024-02-20T12:54:00.000+01:00
Address breaking changes
diff --git a/build.gradle b/build.gradle
@@ -85,7 +85,7 @@ ext {
     kotlinxCoroutinesVersion = '1.7.3'
     lottieVersion = '6.1.0'
     philjayMpAndroidChartVersion = 'v3.1.0'
-    squareupKotlinPoetVersion = '1.6.0'
+    squareupKotlinPoetVersion = '1.16.0'
     squareupOkioVersion = '3.6.0'
     squareupRetrofitVersion = '2.9.0'
     uCropVersion = '2.2.8'
diff --git a/libs/processors/src/main/java/org/wordpress/android/processor/FeaturesInDevelopmentDefaultsBuilder.kt b/libs/processors/src/main/java/org/wordpress/android/processor/FeaturesInDevelopmentDefaultsBuilder.kt
@@ -28,7 +28,7 @@ class FeaturesInDevelopmentDefaultsBuilder(private val featuresInDevelopment: Li
             .build()
         return FileSpec.builder("org.wordpress.android.util.config", "FeaturesInDevelopment")
             .addType(remoteConfigDefaults)
-            .addComment("Automatically generated file. DO NOT MODIFY")
+            .addFileComment("Automatically generated file. DO NOT MODIFY")
             .indent("    ")
             .build()
     }
diff --git a/libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt b/libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt
@@ -1,6 +1,7 @@
 package org.wordpress.android.processor
 
 import com.google.auto.service.AutoService
+import com.squareup.kotlinpoet.DelicateKotlinPoetApi
 import com.squareup.kotlinpoet.TypeName
 import com.squareup.kotlinpoet.asTypeName
 import org.wordpress.android.annotation.Experiment
@@ -26,6 +27,7 @@ import javax.tools.Diagnostic.Kind
     "org.wordpress.android.annotation.RemoteFieldDefaultGenerater"
 )
 class RemoteConfigProcessor : AbstractProcessor() {
+    @OptIn(DelicateKotlinPoetApi::class)
     @Suppress("DEPRECATION")
     override fun process(p0: MutableSet<out TypeElement>?, roundEnvironment: RoundEnvironment?): Boolean {
         val experiments = roundEnvironment?.getElementsAnnotatedWith(Experiment::class.java)?.map { element ->
diff --git a/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFeatureConfigCheckBuilder.kt b/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFeatureConfigCheckBuilder.kt
@@ -42,7 +42,7 @@ class RemoteFeatureConfigCheckBuilder(private val remoteFeatures: List<TypeName>
             .build()
         return FileSpec.builder("org.wordpress.android.util.config", "RemoteFeatureConfigCheck")
             .addType(remoteFeatureConfigDefaults)
-            .addComment("Automatically generated file. DO NOT MODIFY")
+            .addFileComment("Automatically generated file. DO NOT MODIFY")
             .indent("    ")
             .build()
     }
diff --git a/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFeatureConfigDefaultsBuilder.kt b/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFeatureConfigDefaultsBuilder.kt
@@ -31,7 +31,7 @@ class RemoteFeatureConfigDefaultsBuilder(private val defaults: Map<String, Strin
             .build()
         return FileSpec.builder("org.wordpress.android.util.config", FILE_NAME)
             .addType(remoteConfigDefaults)
-            .addComment("Automatically generated file. DO NOT MODIFY")
+            .addFileComment("Automatically generated file. DO NOT MODIFY")
             .indent("    ")
             .build()
     }
diff --git a/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFieldConfigDefaultsBuilder.kt b/libs/processors/src/main/java/org/wordpress/android/processor/RemoteFieldConfigDefaultsBuilder.kt
@@ -31,7 +31,7 @@ class RemoteFieldConfigDefaultsBuilder(private val defaults: Map<String, String>
             .build()
         return FileSpec.builder("org.wordpress.android.util.config", FILE_NAME)
             .addType(remoteConfigDefaults)
-            .addComment("Automatically generated file. DO NOT MODIFY")
+            .addFileComment("Automatically generated file. DO NOT MODIFY")
             .indent("    ")
             .build()
     }
diff --git a/libs/processors/src/test/kotlin/org/wordpress/android/processor/FeaturesInDevelopmentDefaultsBuilderTest.kt b/libs/processors/src/test/kotlin/org/wordpress/android/processor/FeaturesInDevelopmentDefaultsBuilderTest.kt
@@ -23,8 +23,8 @@ class FeaturesInDevelopmentDefaultsBuilderTest {
             import kotlin.String
             import kotlin.collections.List
 
-            object FeaturesInDevelopment {
-                val featuresInDevelopment: List<String> = listOf(
+            public object FeaturesInDevelopment {
+                public val featuresInDevelopment: List<String> = listOf(
                         "$featureA",
                         "$featureB"
                         )
@@ -51,8 +51,8 @@ class FeaturesInDevelopmentDefaultsBuilderTest {
                 import kotlin.String
                 import kotlin.collections.List
 
-                object FeaturesInDevelopment {
-                    val featuresInDevelopment: List<String> = listOf(
+                public object FeaturesInDevelopment {
+                    public val featuresInDevelopment: List<String> = listOf(
                             )
                 }
 
diff --git a/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFeatureConfigCheckBuilderTest.kt b/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFeatureConfigCheckBuilderTest.kt
@@ -28,14 +28,14 @@ class RemoteFeatureConfigCheckBuilderTest {
             import org.wordpress.$classA
             import org.wordpress.$classB
 
-            class RemoteFeatureConfigCheck(
-                val appConfig: AppConfig
+            public class RemoteFeatureConfigCheck(
+                public val appConfig: AppConfig,
             ) {
-                val $classA: $classA = $classA(appConfig)
+                public val $classA: $classA = $classA(appConfig)
 
-                val $classB: $classB = $classB(appConfig)
+                public val $classB: $classB = $classB(appConfig)
 
-                fun checkRemoteFields() {
+                public fun checkRemoteFields() {
                     if ($classA.remoteField == null) {
                         throw IllegalArgumentException(""${'"'}org.wordpress.$classA needs to define
                             remoteField""${'"'})
diff --git a/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFeatureConfigDefaultsBuilderTest.kt b/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFeatureConfigDefaultsBuilderTest.kt
@@ -24,8 +24,8 @@ class RemoteFeatureConfigDefaultsBuilderTest {
             import kotlin.String
             import kotlin.collections.Map
 
-            object RemoteFeatureConfigDefaults {
-                val remoteFeatureConfigDefaults: Map<String, Any> = mapOf(
+            public object RemoteFeatureConfigDefaults {
+                public val remoteFeatureConfigDefaults: Map<String, Any> = mapOf(
                         "$keyA" to "$valueA",
                         "$keyB" to "$valueB"
                         )
diff --git a/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFieldConfigDefaultsBuilderTest.kt b/libs/processors/src/test/kotlin/org/wordpress/android/processor/RemoteFieldConfigDefaultsBuilderTest.kt
@@ -26,8 +26,8 @@ class RemoteFieldConfigDefaultsBuilderTest {
             import kotlin.String
             import kotlin.collections.Map
 
-            object RemoteFieldConfigDefaults {
-                val remoteFieldConfigDefaults: Map<String, Any> = mapOf(
+            public object RemoteFieldConfigDefaults {
+                public val remoteFieldConfigDefaults: Map<String, Any> = mapOf(
                         "$keyA" to "$valueA",
                         "$keyB" to "$valueB"
                         )
@@ -55,8 +55,8 @@ class RemoteFieldConfigDefaultsBuilderTest {
                 import kotlin.String
                 import kotlin.collections.Map
 
-                object RemoteFieldConfigDefaults {
-                    val remoteFieldConfigDefaults: Map<String, Any> = mapOf(
+                public object RemoteFieldConfigDefaults {
+                    public val remoteFieldConfigDefaults: Map<String, Any> = mapOf(
                             )
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class FeaturesInDevelopmentDefaultsBuilder(private val featuresInDevelopment: Li`
`28`	`28`	`.build()`
`29`	`29`	`return FileSpec.builder("org.wordpress.android.util.config", "FeaturesInDevelopment")`
`30`	`30`	`.addType(remoteConfigDefaults)`
`31`		`- .addComment("Automatically generated file. DO NOT MODIFY")`
	`31`	`+ .addFileComment("Automatically generated file. DO NOT MODIFY")`
`32`	`32`	`.indent(" ")`
`33`	`33`	`.build()`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ class RemoteFeatureConfigCheckBuilder(private val remoteFeatures: List<TypeName>`
`42`	`42`	`.build()`
`43`	`43`	`return FileSpec.builder("org.wordpress.android.util.config", "RemoteFeatureConfigCheck")`
`44`	`44`	`.addType(remoteFeatureConfigDefaults)`
`45`		`- .addComment("Automatically generated file. DO NOT MODIFY")`
	`45`	`+ .addFileComment("Automatically generated file. DO NOT MODIFY")`
`46`	`46`	`.indent(" ")`
`47`	`47`	`.build()`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class RemoteFeatureConfigDefaultsBuilder(private val defaults: Map<String, Strin`
`31`	`31`	`.build()`
`32`	`32`	`return FileSpec.builder("org.wordpress.android.util.config", FILE_NAME)`
`33`	`33`	`.addType(remoteConfigDefaults)`
`34`		`- .addComment("Automatically generated file. DO NOT MODIFY")`
	`34`	`+ .addFileComment("Automatically generated file. DO NOT MODIFY")`
`35`	`35`	`.indent(" ")`
`36`	`36`	`.build()`
`37`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class RemoteFieldConfigDefaultsBuilder(private val defaults: Map<String, String>`
`31`	`31`	`.build()`
`32`	`32`	`return FileSpec.builder("org.wordpress.android.util.config", FILE_NAME)`
`33`	`33`	`.addType(remoteConfigDefaults)`
`34`		`- .addComment("Automatically generated file. DO NOT MODIFY")`
	`34`	`+ .addFileComment("Automatically generated file. DO NOT MODIFY")`
`35`	`35`	`.indent(" ")`
`36`	`36`	`.build()`
`37`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@ class FeaturesInDevelopmentDefaultsBuilderTest {`
`23`	`23`	`import kotlin.String`
`24`	`24`	`import kotlin.collections.List`
`25`	`25`
`26`		`- object FeaturesInDevelopment {`
`27`		`- val featuresInDevelopment: List<String> = listOf(`
	`26`	`+ public object FeaturesInDevelopment {`
	`27`	`+ public val featuresInDevelopment: List<String> = listOf(`
`28`	`28`	`"$featureA",`
`29`	`29`	`"$featureB"`
`30`	`30`	`)`
`@@ -51,8 +51,8 @@ class FeaturesInDevelopmentDefaultsBuilderTest {`
`51`	`51`	`import kotlin.String`
`52`	`52`	`import kotlin.collections.List`
`53`	`53`
`54`		`- object FeaturesInDevelopment {`
`55`		`- val featuresInDevelopment: List<String> = listOf(`
	`54`	`+ public object FeaturesInDevelopment {`
	`55`	`+ public val featuresInDevelopment: List<String> = listOf(`
`56`	`56`	`)`
`57`	`57`	`}`
`58`	`58`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ class RemoteFieldConfigDefaultsBuilderTest {`
`26`	`26`	`import kotlin.String`
`27`	`27`	`import kotlin.collections.Map`
`28`	`28`
`29`		`- object RemoteFieldConfigDefaults {`
`30`		`- val remoteFieldConfigDefaults: Map<String, Any> = mapOf(`
	`29`	`+ public object RemoteFieldConfigDefaults {`
	`30`	`+ public val remoteFieldConfigDefaults: Map<String, Any> = mapOf(`
`31`	`31`	`"$keyA" to "$valueA",`
`32`	`32`	`"$keyB" to "$valueB"`
`33`	`33`	`)`
`@@ -55,8 +55,8 @@ class RemoteFieldConfigDefaultsBuilderTest {`
`55`	`55`	`import kotlin.String`
`56`	`56`	`import kotlin.collections.Map`
`57`	`57`
`58`		`- object RemoteFieldConfigDefaults {`
`59`		`- val remoteFieldConfigDefaults: Map<String, Any> = mapOf(`
	`58`	`+ public object RemoteFieldConfigDefaults {`
	`59`	`+ public val remoteFieldConfigDefaults: Map<String, Any> = mapOf(`
`60`	`60`	`)`
`61`	`61`	`}`
`62`	`62`