refactor / clean CI workflow code

Author: kolomenkin

.github/workflows/build.yml

@@ -22,6 +22,9 @@ jobs:
   build:
     name: Visual Studio 2019
     runs-on: windows-2019
+    env:
+      ARTIFACT_NAME: logreader-${{ matrix.config.config }}-${{ matrix.config.platform }}.7z
+
     strategy:
       fail-fast: false
       matrix:
@@ -56,35 +59,36 @@ jobs:
 
       - name: Run Unit Tests - ${{ matrix.config.config }} - ${{ matrix.config.platform }}
         shell: sh
-        run: |
-          ./${{ matrix.config.output_dir }}/tests.exe
+        run: ./${{ matrix.config.output_dir }}/tests.exe
 
       - name: Copy Executable
         shell: sh
         run: |
           mkdir -p -- "$RUNNER_TEMP/instdir"
           cp -- ./${{ matrix.config.output_dir }}/LogReader.exe "$RUNNER_TEMP/instdir"
 
-      - name: Pack
-        env:
-          ARCHIVE_FILE: ${{ runner.temp }}/logreader-${{ matrix.config.config }}-${{ matrix.config.platform }}.7z
+      - name: Pack Build Artifact
         working-directory: ${{ runner.temp }}/instdir
         shell: sh
-        run: cmake -E tar vcf "$ARCHIVE_FILE" --format=7zip -- .
+        run: cmake -E tar vcf "$RUNNER_TEMP/$ARTIFACT_NAME" --format=7zip -- .
 
-      - name: Upload
+      - name: Upload Build Artifact
         uses: actions/upload-artifact@v2
         with:
-          path: ${{ runner.temp }}/logreader-${{ matrix.config.config }}-${{ matrix.config.platform }}.7z
-          name: logreader-${{ matrix.config.config }}-${{ matrix.config.platform }}.7z
+          path: ${{ runner.temp }}/${{ env.ARTIFACT_NAME }}
+          name: ${{ env.ARTIFACT_NAME }}
 
-  release:
+  create-release:
     name: Create Release for ${{ github.ref }}
     if: contains(github.ref, 'tags/v')
     runs-on: ubuntu-latest
-    needs: build
+    needs:
+      - build
+      - check-formatting
     permissions:
       contents: write
+    env:
+      ARTIFACT_NAME: logreader-Release-x64.7z
 
     steps:
       - name: Create Release
@@ -94,54 +98,23 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           tag_name: ${{ github.ref }}
-          release_name: Release ${{ github.ref }}
+          release_name: ${{ github.ref }}
           draft: false
           prerelease: false
 
-      - name: Store Release url
-        shell: sh
-        run: |
-          echo "${{ steps.create_release.outputs.upload_url }}" > ./upload_url
-
-      - uses: actions/upload-artifact@v2
-        with:
-          path: ./upload_url
-          name: upload_url
-
-  publish:
-    if: contains(github.ref, 'tags/v')
-    name: Publish Release Artifacts from Visual Studio 2019
-    runs-on: ubuntu-latest
-    needs: release
-    permissions:
-      contents: write
-
-    steps:
-      - name: Download artifact
-        uses: actions/download-artifact@v2
-        with:
-          name: logreader-Release-x64.7z
-          path: ./
-
-      - name: Download URL
+      - name: Download Artifact
         uses: actions/download-artifact@v2
         with:
-          name: upload_url
+          name: ${{ env.ARTIFACT_NAME }}
           path: ./
 
-      - id: set_upload_url
-        shell: sh
-        run: |
-          upload_url=`cat ./upload_url`
-          echo ::set-output name=upload_url::$upload_url
-
-      - name: Upload to Release
+      - name: Upload Artifact to Release
         id: upload_to_release
         uses: actions/upload-release-asset@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          upload_url: ${{ steps.set_upload_url.outputs.upload_url }}
-          asset_path: ./logreader-Release-x64.7z
-          asset_name: logreader-Release-x64.7z
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./${{ env.ARTIFACT_NAME }}
+          asset_name: ${{ env.ARTIFACT_NAME }}
           asset_content_type: application/x-7z-compressed