-
Notifications
You must be signed in to change notification settings - Fork 63
Open
Labels
status:doneTask is completeTask is complete
Description
Summary
URI.escape and URI.encode were removed in Ruby 3.0. There's a comment in core/app/models/workarea/navigation/redirect.rb:36 noting this, but we need to verify the fix is complete and check for any other occurrences.
Also check vendored active_shipping code which has multiple uses.
Scope
core/app/models/workarea/navigation/redirect.rb— has comment about removalcore/vendor/active_shipping/— vendored code with URI.escape usage
Approach
Replace with CGI.escape, URI::DEFAULT_PARSER.escape, or Addressable::URI.encode depending on context.
Objective
Ensure zero URI.escape/URI.encode calls remain that would crash on Ruby 3.0+.
Client impact
None.
Acceptance Criteria
- No
URI.escapeorURI.encodein non-vendor application code - Vendored code either fixed or shimmed
- Tests pass on Ruby 2.7.8
Verification Plan
grep -rn 'URI\.\(escape\|encode\)' --include='*.rb' core/app core/lib admin/ storefront/ | grep -v vendorreturns zero- Run core test suite
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
status:doneTask is completeTask is complete