WA-CI-006: Fix next branch CI baseline failures

[kitcommerce]

Summary

The next branch has been failing CI consistently since 2026-03-02 with multiple issues.

Objective

Restore green CI on the next branch so the review pipeline can function.

Root Causes

1. Rubocop: 980 Layout/EmptyLineAfterMagicComment offenses (auto-correctable)

• Introduced by: PR Add frozen_string_literal: true to all app Ruby files (WA-NEW-037) #733 (WA-NEW-037: frozen_string_literal), merged 2026-03-02
• # frozen_string_literal: true was added to many files without an empty line after the magic comment
• Fix: bundle exec rubocop --autocorrect (all offenses are auto-correctable)

2. MiddlewareStackTest failures (3 tests)

• Introduced by: PR WA-NEW-040: Fix Rack::Attack compatibility with Rails 7 / Rack 3 #731 (WA-NEW-040: Rack::Attack), merged 2026-03-02
• Tests expect Rack::Attack at index 3 but it is at index 1
• Actual: ["Rack::Sendfile", "Rack::Attack", "Rack::Timeout", ...]
• Fix: Middleware initializer ordering or test expectations need adjustment
• Files: core/test/integration/workarea/middleware_stack_test.rb and Rack::Attack initializer

3. PublishingIntegrationTest / SegmentOverridesIntegrationTest failures

• BSON::ObjectId comparison failures — hardcoded IDs in expected output vs actual
• May be flaky tests or fixtures that changed; needs investigation

Acceptance Criteria

• bundle exec rubocop passes with zero offenses on next
• MiddlewareStackTest all 3 failing tests pass
• PublishingIntegrationTest#test_publishing passes
• SegmentOverridesIntegrationTest#test_creates_segment_overrides passes
• Full CI green on next branch

Verification Plan

1. bundle exec rubocop --autocorrect
2. bundle exec rails test core/test/integration/workarea/middleware_stack_test.rb
3. Push to next and verify CI passes

Client impact

None — test/lint fixes only, no behavior changes.

[kitcommerce]

PR opened: #749

Two commits:

1. Rubocop autocorrect (980 offenses)
2. Test fixes: MiddlewareStackTest algorithm + BSON assertion types

[kitcommerce]

Build Gate Failed — PR #749

CI completed with 3 failures. Two distinct root causes:

Failure 1: core_tests + Rails 6.1 (default) — test

Workarea::MountPointTest#test_find_returns_nil_when_route_raises_during_traversal:
NoMethodError: undefined method `stub` for #<ActionDispatch::Routing::RouteSet:...>
    core/test/lib/workarea/mount_point_test.rb:58

Likely fix: PR #746 (WA-CI-005: MountPoint.unwrap_app fix) merged at 16:14 ET today. PR #749 predates that merge and needs to rebase on current next to pick up the fix.

Failure 2: Rails 7.1 — test

bundle lock -- BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile
Could not find compatible versions
Because rails >= 7.1.0, < 7.1.3.2 requires actionpack = 7.1.0|7.1.1|7.1.2|7.1.3|7.1.3.1
...dependency resolution conflict in gemfiles/rails_7_1.gemfile

Fix needed: Update gemfiles/rails_7_1.gemfile.lock or loosen/pin the Rails 7.1 version constraint in that gemfile to resolve the bundler conflict.

Action required:

1. git rebase origin/next to pick up MountPoint fix from PR WA-CI-005: Fix MountPoint.unwrap_app to stop at Class objects (next CI regression) #746
2. Fix gemfiles/rails_7_1.gemfile bundler resolution (likely needs bundle lock --update=rails in that gemfile context)
3. Push and re-run CI

[kitcommerce]

CI completed on PR #749 — gate:build-failed.

The "Rails 6.1 (default) — test" check failed (completed 2026-03-04T00:07:59Z). All other 14 checks passed.

Details: https://github.com/workarea-commerce/workarea/actions/runs/22647514758/job/65639027714

Fix agent being dispatched to investigate the Rails 6.1 test failures and push a resolution.