Add migration to backfill is_task=true on core tasks

Author: Mark90

orchestrator/migrations/versions/schema/2020-10-19_a76b9185b334_add_generic_workflows_to_core.py

@@ -17,6 +17,7 @@
 branch_labels = None
 depends_on = None
 
+# NOTE: this migration forgot to insert these workflows with is_task=true. Make sure to correct that if you copy this.
 workflows = [
     {"name": "modify_note", "description": "Modify Note", "workflow_id": uuid4(), "target": "MODIFY"},
     {"name": "task_clean_up_tasks", "description": "Clean up old tasks", "workflow_id": uuid4(), "target": "SYSTEM"},

orchestrator/migrations/versions/schema/2021-04-06_3c8b9185c221_add_validate_products_task.py

@@ -17,6 +17,7 @@
 branch_labels = None
 depends_on = None
 
+# NOTE: this migration forgot to insert these workflows with is_task=true. Make sure to correct that if you copy this.
 workflows = [
     {"name": "task_validate_products", "description": "Validate products", "workflow_id": uuid4(), "target": "SYSTEM"},
 ]

orchestrator/migrations/versions/schema/2025-11-18_961eddbd4c13_create_linker_table_workflow_apscheduler.py

@@ -17,7 +17,7 @@
 branch_labels = None
 depends_on = None
 
-
+# NOTE: this migration forgot to insert these workflows with is_task=true. Make sure to correct that if you copy this.
 workflows = [
     {
         "name": "task_validate_subscriptions",

orchestrator/migrations/versions/schema/2025-12-10_9736496e3eba_set_is_task_true_on_certain_tasks.py

@@ -0,0 +1,40 @@
+"""Set is_task=true on certain tasks.
+
+This is required to make them appear in the completed tasks in the UI, and for the cleanup task to be able to
+remove them.
+
+Revision ID: 9736496e3eba
+Revises: 961eddbd4c13
+Create Date: 2025-12-10 16:42:29.060382
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "9736496e3eba"
+down_revision = "961eddbd4c13"
+branch_labels = None
+depends_on = None
+
+task_names = [
+    # Added in a76b9185b334
+    "task_clean_up_tasks",
+    "task_resume_workflows",
+    # Added in 3c8b9185c221
+    "task_validate_products",
+    # Added in 961eddbd4c13
+    "task_validate_subscriptions",
+]
+
+
+def upgrade() -> None:
+    conn = op.get_bind()
+    query = sa.text("UPDATE workflows SET is_task=true WHERE name = :task_name and is_task=false")
+    for task_name in task_names:
+        conn.execute(query, parameters={"task_name": task_name})
+
+
+def downgrade() -> None:
+    pass  # Does not make sense to downgrade back to a 'bad' state.