From 54b06b86d566b60c5a5e5e4c10e8a4e451611972 Mon Sep 17 00:00:00 2001 From: Igor van Spengen Date: Wed, 10 Dec 2025 13:33:52 +0100 Subject: [PATCH 1/5] Update docs --- docs/guides/tasks.md | 1 + docs/guides/upgrading/4.0.md | 15 +++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/docs/guides/tasks.md b/docs/guides/tasks.md index 10dec5879..e31e15cab 100644 --- a/docs/guides/tasks.md +++ b/docs/guides/tasks.md @@ -245,6 +245,7 @@ python main.py scheduler load-initial-schedule ``` > Remember, that if you do not explicitly import these, they will not be available to the scheduler. +> Importing schedules more than once will not create duplicates. ### Manually executing tasks When doing development, it is possible to manually make the scheduler run your task even if your Orchestrator instance is not in "scheduler mode." diff --git a/docs/guides/upgrading/4.0.md b/docs/guides/upgrading/4.0.md index 02ad7c06e..e8116bb27 100644 --- a/docs/guides/upgrading/4.0.md +++ b/docs/guides/upgrading/4.0.md @@ -80,12 +80,10 @@ The 4.7.0 migration will create the `apscheduler_jobs` table if missing, so upgr ### Who needs to take action? -**Users upgrading from 4.4–4.6:** - - Nothing special required; your scheduler data already exists. +Everyone who is upgrading to >= 4.7.0 needs to take action. Your previous schedules will exist but will be removed +on the next runtime because the schedule code has been removed. -**Users upgrading from <4.4 who used the old decorator:** - - Your schedules will not automatically reappear. Restore them by running: - - + - Re-create them by running: ``` python main.py scheduler load-initial-schedule ``` @@ -93,4 +91,9 @@ The 4.7.0 migration will create the `apscheduler_jobs` table if missing, so upgr Make sure your schedule definitions are imported so the scheduler can discover them. **Users who never used the decorator:** -- No action required; the migration creates the table and you can add schedules normally. +- You still need to run the command above to ensure the old schedules are created in the database. +- the migration creates the table and you can add schedules normally via the API. + + +> Remember, that if you do not explicitly import these, they will not be available to the scheduler. +> Importing schedules more than once will not create duplicates. From 6b081a2a39f8385cb08ceca110e59e009524a426 Mon Sep 17 00:00:00 2001 From: Igor van Spengen Date: Wed, 10 Dec 2025 13:37:44 +0100 Subject: [PATCH 2/5] update docs --- docs/guides/tasks.md | 2 +- docs/guides/upgrading/4.0.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/guides/tasks.md b/docs/guides/tasks.md index e31e15cab..5fee3b0f4 100644 --- a/docs/guides/tasks.md +++ b/docs/guides/tasks.md @@ -245,7 +245,7 @@ python main.py scheduler load-initial-schedule ``` > Remember, that if you do not explicitly import these, they will not be available to the scheduler. -> Importing schedules more than once will not create duplicates. +> Importing schedules more than once will create duplicates. ### Manually executing tasks When doing development, it is possible to manually make the scheduler run your task even if your Orchestrator instance is not in "scheduler mode." diff --git a/docs/guides/upgrading/4.0.md b/docs/guides/upgrading/4.0.md index e8116bb27..fd2dc94c3 100644 --- a/docs/guides/upgrading/4.0.md +++ b/docs/guides/upgrading/4.0.md @@ -96,4 +96,4 @@ on the next runtime because the schedule code has been removed. > Remember, that if you do not explicitly import these, they will not be available to the scheduler. -> Importing schedules more than once will not create duplicates. +> Importing schedules more than once will create duplicates. From 7ae02610bf07477d1ace911663d54a95b6ec2358 Mon Sep 17 00:00:00 2001 From: Igor van Spengen Date: Wed, 10 Dec 2025 13:40:29 +0100 Subject: [PATCH 3/5] update docs --- docs/guides/upgrading/4.0.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/guides/upgrading/4.0.md b/docs/guides/upgrading/4.0.md index fd2dc94c3..f1f55256a 100644 --- a/docs/guides/upgrading/4.0.md +++ b/docs/guides/upgrading/4.0.md @@ -80,8 +80,17 @@ The 4.7.0 migration will create the `apscheduler_jobs` table if missing, so upgr ### Who needs to take action? -Everyone who is upgrading to >= 4.7.0 needs to take action. Your previous schedules will exist but will be removed -on the next runtime because the schedule code has been removed. +Everyone who is upgrading to >= 4.7.0 needs to take action. +The following schedules will exist in the APScheduler database table: + + task_resume_workflows + task_clean_up_tasks + task_validate_subscriptions + +These schedules exist, but the code to run these schedules has been removed. e.g. removing the decorator +`@scheduler.scheduled_job(...)` from the codebase for these schedules. + +You will need to follow the instructions below if you want to keep these schedules running. - Re-create them by running: ``` From d7b9df5a6eaf47a613e2029081d63071eecae257 Mon Sep 17 00:00:00 2001 From: Igor van Spengen Date: Wed, 10 Dec 2025 13:42:01 +0100 Subject: [PATCH 4/5] update docs --- docs/guides/upgrading/4.0.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/guides/upgrading/4.0.md b/docs/guides/upgrading/4.0.md index f1f55256a..4eb1a7ed4 100644 --- a/docs/guides/upgrading/4.0.md +++ b/docs/guides/upgrading/4.0.md @@ -87,10 +87,9 @@ The following schedules will exist in the APScheduler database table: task_clean_up_tasks task_validate_subscriptions -These schedules exist, but the code to run these schedules has been removed. e.g. removing the decorator -`@scheduler.scheduled_job(...)` from the codebase for these schedules. +They will however be removed once the scheduler service starts and can no longer find these schedules in the codebase. -You will need to follow the instructions below if you want to keep these schedules running. +If you want to keep these schedules running, you will need to re-create them using the new Scheduler API. - Re-create them by running: ``` From 1a18abe53d6d204ed67f88c707d6849604817593 Mon Sep 17 00:00:00 2001 From: Igor van Spengen Date: Wed, 10 Dec 2025 14:40:26 +0100 Subject: [PATCH 5/5] update docs --- docs/guides/upgrading/4.0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/guides/upgrading/4.0.md b/docs/guides/upgrading/4.0.md index 4eb1a7ed4..984b30549 100644 --- a/docs/guides/upgrading/4.0.md +++ b/docs/guides/upgrading/4.0.md @@ -80,7 +80,7 @@ The 4.7.0 migration will create the `apscheduler_jobs` table if missing, so upgr ### Who needs to take action? -Everyone who is upgrading to >= 4.7.0 needs to take action. +Everyone who is upgrading to >= 4.7.0 needs to take action. The following schedules will exist in the APScheduler database table: task_resume_workflows