Skip to content

Commit 98c00a0

Browse files
authored
Merge pull request #89 from workfloworchestrator/fix-show-minus-button
Show minus button in ArrayField even if min_items value is not provided.
2 parents a8e57f5 + 5b3ac1d commit 98c00a0

File tree

7 files changed

+26
-25
lines changed

7 files changed

+26
-25
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'pydantic-forms': patch
3+
---
4+
5+
Exports util functions and RenderFields component. Bugfixes
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'pydantic-forms': patch
3+
---
4+
5+
Show minus button in ArrayField even if min_items value is not provided.

frontend/packages/pydantic-forms/src/components/fields/ArrayField.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,9 @@ export const ArrayField = ({ pydanticFormField }: PydanticFormElementProps) => {
4646
]}
4747
extraTriggerFields={[arrayName]}
4848
/>
49-
{!minItems ||
50-
(minItems && fields.length > minItems && (
51-
<span
52-
style={{ fontSize: '24px' }}
53-
onClick={() => remove(index)}
54-
>
55-
-
56-
</span>
57-
))}
49+
{(!minItems || (minItems && fields.length > minItems)) && (
50+
<span onClick={() => remove(index)}>-</span>
51+
)}
5852
</div>
5953
);
6054
};

frontend/packages/pydantic-forms/src/components/render/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ export * from './FormRenderer';
33
export * from './RenderForm';
44
export * from './RenderFormErrors';
55
export * from './RenderReactHookFormErrors';
6+
export * from './RenderFields';

frontend/packages/pydantic-forms/src/components/zodValidationsPresets.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const zodValidationPresets: PydanticFormZodValidationPresets = {
3737
try {
3838
validationRule = validationRule?.regex(
3939
new RegExp(pattern),
40-
'De invoer is niet volgens het juiste formaat',
40+
`De invoer is niet volgens het juiste formaat: ${pattern}`,
4141
);
4242
} catch (error) {
4343
console.error(

frontend/packages/pydantic-forms/src/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ export * from './types';
22
export * from './PydanticForm';
33
export * from './core';
44
export * from './components';
5+
export * from './utils';

frontend/packages/pydantic-forms/src/types.ts

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,7 @@ export interface PydanticFormField {
106106
oneOf?: PydanticFormFieldAnyOfDef[];
107107
allOf?: PydanticFormFieldAnyOfDef[];
108108

109-
uniforms?: {
110-
disabled: boolean;
111-
sensitive: boolean;
112-
password: boolean;
113-
};
109+
uniforms?: UniformProperties;
114110
arrayItem?: PydanticFormField;
115111
properties?: Properties;
116112
}
@@ -436,11 +432,7 @@ export interface PydanticFormPropertySchemaParsed
436432
default?: string | null;
437433
format: PydanticFormFieldFormat;
438434

439-
uniforms?: {
440-
disabled: boolean;
441-
sensitive: boolean;
442-
password: boolean;
443-
};
435+
uniforms?: UniformProperties;
444436

445437
properties?: ParsedProperties;
446438
}
@@ -470,6 +462,13 @@ export interface PydanticFormFieldAnyOfItemParsed
470462
properties?: ParsedProperties;
471463
}
472464

465+
type UniformProperties = {
466+
disabled: boolean;
467+
sensitive: boolean;
468+
password: boolean;
469+
[key: string]: string | boolean | number;
470+
};
471+
473472
export interface PydanticFormPropertySchemaRawJson
474473
extends Omit<PydanticFormBaseSchema, 'type'>,
475474
PydanticFormFieldValidations,
@@ -483,11 +482,7 @@ export interface PydanticFormPropertySchemaRawJson
483482
default?: string | null;
484483
format: PydanticFormFieldFormat;
485484

486-
uniforms?: {
487-
disabled: boolean;
488-
sensitive: boolean;
489-
password: boolean;
490-
};
485+
uniforms?: UniformProperties;
491486

492487
properties?: RawJsonProperties;
493488
}

0 commit comments

Comments
 (0)