Merge pull request #148 from workfloworchestrator/2076-values-drop-on-errors

2076 values drop on errors

Author: DutchBen

frontend/.changeset/busy-trees-raise.md

@@ -0,0 +1,5 @@
+---
+'pydantic-forms': patch
+---
+
+Fix error where resetForm is called to often clearing initialData in some cases

frontend/packages/pydantic-forms/src/components/fields/ArrayField.tsx

@@ -9,15 +9,6 @@ import { itemizeArrayItem } from '@/utils';
 import { RenderFields } from '../render';
 
 export const ArrayField = ({ pydanticFormField }: PydanticFormElementProps) => {
-    // TODO/NOTE: Default array values on nested object fields are not displayed correctly.
-    // This looks like its a react-hook-form issue. It doesn't - so far - occur in WFO context so we
-    // will not fix for now. Observed behavior:
-    // - The default values are set.
-    // - The array shows without items
-    // - As soon as one item is added, the other items are automatically shown.
-    // As possible fix is to do a setValue of the array field in useEffect.
-    // Running a rhf.reset() in the RenderForm component works but introduces other issues, resetting the form when errors occur.
-
     const { rhf, config } = usePydanticFormContext();
 
     const { control } = rhf;

frontend/packages/pydantic-forms/src/core/PydanticFormContextProvider.tsx

@@ -255,7 +255,16 @@ function PydanticFormContextProvider({
             return;
         }
 
-        // when we receive a form from the JSON, we fully reset the scheme
+        // when we receive a new form from JSON, we fully reset the form
+        if (apiResponse?.form && rawSchema !== apiResponse.form) {
+            resetFormData();
+            setRawSchema(apiResponse.form);
+            if (apiResponse.meta) {
+                setHasNext(!!apiResponse.meta.hasNext);
+            }
+            setErrorDetails(undefined);
+        }
+
         if (apiResponse?.form) {
             resetFormData();
             setRawSchema(apiResponse.form);
@@ -271,7 +280,8 @@ function PydanticFormContextProvider({
         }
 
         setIsSending(false);
-    }, [apiResponse, onSuccess, resetFormData, rhf, skipSuccessNotice]);
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [apiResponse]); // Avoid completing the dependencies array here to avoid unwanted resetFormData calls
 
     // a useeffect for filling data whenever formdefinition or labels update