Fix PHPStan level 9 errors

Copilot · swissspidy · Copilot · commit 338552c34184 · 2025-11-04T14:36:12.000Z
Co-authored-by: swissspidy &lt;841956+swissspidy@users.noreply.github.com&gt;
diff --git a/src/Export_Command.php b/src/Export_Command.php
@@ -181,7 +181,7 @@ public function __invoke( $_, $assoc_args ) {
 			'wp_export_new_file',
 			static function ( $file_path ) {
 				WP_CLI::log( sprintf( 'Writing to file %s', $file_path ) );
-				Utils\wp_clear_object_cache();
+				Utils\wp_clear_object_cache(); // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.wp_clear_object_cacheDeprecatedRemoved
 			}
 		);
 
@@ -190,15 +190,15 @@ static function ( $file_path ) {
 				wp_export(
 					[
 						'filters'     => $this->export_args,
-						'writer'      => 'WP_Export_File_Writer',
+						'writer'      => WP_Export_File_Writer::class,
 						'writer_args' => 'php://output',
 					]
 				);
 			} else {
 				wp_export(
 					[
 						'filters'     => $this->export_args,
-						'writer'      => 'WP_Export_Split_Files_Writer',
+						'writer'      => WP_Export_Split_Files_Writer::class,
 						'writer_args' => [
 							'max_file_size'         => $this->max_file_size,
 							'destination_directory' => $this->wxr_path,
@@ -234,6 +234,7 @@ private function validate_args( $args ) {
 
 		foreach ( $args as $key => $value ) {
 			if ( is_callable( [ $this, 'check_' . $key ] ) ) {
+				/** @phpstan-ignore argument.type */
 				$result = call_user_func( [ $this, 'check_' . $key ], $value );
 				if ( false === $result ) {
 					$has_errors = true;
@@ -281,11 +282,11 @@ private function check_start_date( $date ) {
 		}
 
 		$time = strtotime( $date );
-		if ( ! empty( $date ) && ! $time ) {
+		if ( ! empty( $date ) && false === $time ) {
 			WP_CLI::warning( sprintf( 'The start_date %s is invalid.', $date ) );
 			return false;
 		}
-		$this->export_args['start_date'] = date( 'Y-m-d', $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
+		$this->export_args['start_date'] = date( 'Y-m-d', (int) $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
 		return true;
 	}
 
@@ -300,11 +301,11 @@ private function check_end_date( $date ) {
 		}
 
 		$time = strtotime( $date );
-		if ( ! empty( $date ) && ! $time ) {
+		if ( ! empty( $date ) && false === $time ) {
 			WP_CLI::warning( sprintf( 'The end_date %s is invalid.', $date ) );
 			return false;
 		}
-		$this->export_args['end_date'] = date( 'Y-m-d', $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
+		$this->export_args['end_date'] = date( 'Y-m-d', (int) $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
 		return true;
 	}
 
@@ -420,8 +421,8 @@ private function check_author( $author ) {
 		}
 
 		// phpcs:ignore WordPress.WP.DeprecatedFunctions.get_users_of_blogFound -- Fallback.
-		$authors = function_exists( 'get_users' ) ? get_users() : get_users_of_blog();
-		if ( empty( $authors ) || is_wp_error( $authors ) ) {
+		$authors = function_exists( 'get_users' ) ? get_users() : get_users_of_blog(); // phpstan-ignore-line
+		if ( empty( $authors ) ) {
 			WP_CLI::warning( 'Could not find any authors in this blog.' );
 			return false;
 		}
@@ -447,6 +448,9 @@ private function check_author( $author ) {
 		return true;
 	}
 
+	/**
+	 * @phpstan-ignore method.unused
+	 */
 	private function check_max_num_posts( $num ) {
 		if ( null !== $num && ( ! is_numeric( $num ) || $num <= 0 ) ) {
 			WP_CLI::warning( 'max_num_posts should be a positive integer.' );
@@ -473,7 +477,7 @@ private function check_category( $category ) {
 		}
 
 		$term = category_exists( $category );
-		if ( empty( $term ) || is_wp_error( $term ) ) {
+		if ( empty( $term ) ) {
 			WP_CLI::warning( sprintf( 'Could not find a category matching %s.', $category ) );
 			return false;
 		}
@@ -492,7 +496,7 @@ private function check_post_status( $status ) {
 		}
 
 		$stati = get_post_stati();
-		if ( empty( $stati ) || is_wp_error( $stati ) ) {
+		if ( empty( $stati ) ) {
 			WP_CLI::warning( 'Could not find any post stati.' );
 			return false;
 		}
diff --git a/src/WP_Export_Oxymel.php b/src/WP_Export_Oxymel.php
@@ -10,7 +10,7 @@ public function optional( $tag_name, $contents ) {
 
 	public function optional_cdata( $tag_name, $contents ) {
 		if ( $contents ) {
-			$this->$tag_name->contains->cdata( $contents )->end;
+			$this->$tag_name->contains->cdata( $contents )->end; // phpstan-ignore-line
 		}
 		return $this;
 	}
diff --git a/src/WP_Export_Query.php b/src/WP_Export_Query.php
@@ -122,7 +122,7 @@ public function custom_taxonomies_terms() {
 		}
 		$custom_taxonomies = get_taxonomies( [ '_builtin' => false ] );
 		// phpcs:ignore WordPress.WP.DeprecatedParameters.Get_termsParam2Found -- Deprecated, but we need to support older versions of WordPress.
-		$custom_terms = (array) get_terms( $custom_taxonomies, [ 'get' => 'all' ] );
+		$custom_terms = (array) get_terms( $custom_taxonomies, [ 'get' => 'all' ] ); // phpstan-ignore-line
 		$custom_terms = $this->process_orphaned_terms( $custom_terms );
 		$custom_terms = self::topologically_sort_terms( $custom_terms );
 		return $custom_terms;
@@ -323,7 +323,7 @@ private function bloginfo_rss( $section ) {
 
 	private function find_user_from_any_object( $user ) {
 		if ( is_numeric( $user ) ) {
-			return get_user_by( 'id', $user );
+			return get_user_by( 'id', (int) $user );
 		} elseif ( is_string( $user ) ) {
 			return get_user_by( 'login', $user );
 		} elseif ( isset( $user->ID ) ) {
diff --git a/src/WP_Export_WXR_Formatter.php b/src/WP_Export_WXR_Formatter.php
@@ -224,7 +224,7 @@ public function post( $post ) {
 			->tag( 'wp:postmeta' )->contains
 				->tag( 'wp:meta_key', $meta->meta_key )
 				->tag( 'wp:meta_value' )->contains->cdata( $meta->meta_value )->end
-				->end;
+				->end; // phpstan-ignore-line
 		}
 		foreach ( $post->comments as $comment ) {
 			$oxymel
@@ -242,16 +242,16 @@ public function post( $post ) {
 				->tag( 'wp:comment_parent', $comment->comment_parent )
 				->tag( 'wp:comment_user_id', $comment->user_id )
 				->oxymel( $this->comment_meta( $comment ) )
-				->end;
+				->end; // phpstan-ignore-line
 		}
 		$oxymel
-			->end;
+			->end; // phpstan-ignore-line
 		return $oxymel->to_string();
 	}
 
 	public function footer() {
 		$oxymel = new Oxymel();
-		return $oxymel->close_channel->close_rss->to_string();
+		return $oxymel->close_channel->close_rss->to_string(); // phpstan-ignore-line
 	}
 
 	protected function terms( $terms ) {
@@ -269,7 +269,7 @@ protected function terms( $terms ) {
 				$oxymel
 				->optional_cdata( 'wp:term_name', $term->name )
 				->optional_cdata( 'wp:term_description', $term->description )
-				->end;
+				->end; // phpstan-ignore-line
 		}
 		return $oxymel->to_string();
 	}
@@ -285,7 +285,7 @@ protected function comment_meta( $comment ) {
 			$oxymel->tag( 'wp:commentmeta' )->contains
 				->tag( 'wp:meta_key', $meta->meta_key )
 				->tag( 'wp:meta_value' )->contains->cdata( $meta->meta_value )->end
-			->end;
+			->end; // phpstan-ignore-line
 		}
 		return $oxymel;
 	}
diff --git a/src/WP_Map_Iterator.php b/src/WP_Map_Iterator.php
@@ -1,5 +1,8 @@
 <?php
 
+/**
+ * @extends IteratorIterator<mixed, mixed, \Iterator<mixed>>
+ */
 class WP_Map_Iterator extends IteratorIterator {
 	/**
 	 * @var callable
diff --git a/src/WP_Post_IDs_Iterator.php b/src/WP_Post_IDs_Iterator.php
@@ -91,7 +91,8 @@ public function valid() {
 	private function load_next_posts_from_db() {
 		$next_batch_post_ids = array_splice( $this->ids_left, 0, $this->limit );
 		$in_post_ids_sql     = _wp_export_build_IN_condition( 'ID', $next_batch_post_ids );
-		$this->results       = $this->db->get_results( "SELECT * FROM {$this->db->posts} WHERE {$in_post_ids_sql}" );
+		$results             = $this->db->get_results( "SELECT * FROM {$this->db->posts} WHERE {$in_post_ids_sql}" );
+		$this->results       = is_array( $results ) ? $results : array();
 		if ( ! $this->results ) {
 			if ( $this->db->last_error ) {
 				throw new WP_Iterator_Exception( "Database error: {$this->db->last_error}" );

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ public function __invoke( $_, $assoc_args ) {`
`181`	`181`	`'wp_export_new_file',`
`182`	`182`	`static function ( $file_path ) {`
`183`	`183`	`WP_CLI::log( sprintf( 'Writing to file %s', $file_path ) );`
`184`		`- Utils\wp_clear_object_cache();`
	`184`	`+ Utils\wp_clear_object_cache(); // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.wp_clear_object_cacheDeprecatedRemoved`
`185`	`185`	`}`
`186`	`186`	`);`
`187`	`187`
`@@ -190,15 +190,15 @@ static function ( $file_path ) {`
`190`	`190`	`wp_export(`
`191`	`191`	`[`
`192`	`192`	`'filters' => $this->export_args,`
`193`		`- 'writer' => 'WP_Export_File_Writer',`
	`193`	`+ 'writer' => WP_Export_File_Writer::class,`
`194`	`194`	`'writer_args' => 'php://output',`
`195`	`195`	`]`
`196`	`196`	`);`
`197`	`197`	`} else {`
`198`	`198`	`wp_export(`
`199`	`199`	`[`
`200`	`200`	`'filters' => $this->export_args,`
`201`		`- 'writer' => 'WP_Export_Split_Files_Writer',`
	`201`	`+ 'writer' => WP_Export_Split_Files_Writer::class,`
`202`	`202`	`'writer_args' => [`
`203`	`203`	`'max_file_size' => $this->max_file_size,`
`204`	`204`	`'destination_directory' => $this->wxr_path,`
`@@ -234,6 +234,7 @@ private function validate_args( $args ) {`
`234`	`234`
`235`	`235`	`foreach ( $args as $key => $value ) {`
`236`	`236`	`if ( is_callable( [ $this, 'check_' . $key ] ) ) {`
	`237`	`+ /** @phpstan-ignore argument.type */`
`237`	`238`	`$result = call_user_func( [ $this, 'check_' . $key ], $value );`
`238`	`239`	`if ( false === $result ) {`
`239`	`240`	`$has_errors = true;`
`@@ -281,11 +282,11 @@ private function check_start_date( $date ) {`
`281`	`282`	`}`
`282`	`283`
`283`	`284`	`$time = strtotime( $date );`
`284`		`- if ( ! empty( $date ) && ! $time ) {`
	`285`	`+ if ( ! empty( $date ) && false === $time ) {`
`285`	`286`	`WP_CLI::warning( sprintf( 'The start_date %s is invalid.', $date ) );`
`286`	`287`	`return false;`
`287`	`288`	`}`
`288`		`- $this->export_args['start_date'] = date( 'Y-m-d', $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date`
	`289`	`+ $this->export_args['start_date'] = date( 'Y-m-d', (int) $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date`
`289`	`290`	`return true;`
`290`	`291`	`}`
`291`	`292`
`@@ -300,11 +301,11 @@ private function check_end_date( $date ) {`
`300`	`301`	`}`
`301`	`302`
`302`	`303`	`$time = strtotime( $date );`
`303`		`- if ( ! empty( $date ) && ! $time ) {`
	`304`	`+ if ( ! empty( $date ) && false === $time ) {`
`304`	`305`	`WP_CLI::warning( sprintf( 'The end_date %s is invalid.', $date ) );`
`305`	`306`	`return false;`
`306`	`307`	`}`
`307`		`- $this->export_args['end_date'] = date( 'Y-m-d', $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date`
	`308`	`+ $this->export_args['end_date'] = date( 'Y-m-d', (int) $time ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date`
`308`	`309`	`return true;`
`309`	`310`	`}`
`310`	`311`
`@@ -420,8 +421,8 @@ private function check_author( $author ) {`
`420`	`421`	`}`
`421`	`422`
`422`	`423`	`// phpcs:ignore WordPress.WP.DeprecatedFunctions.get_users_of_blogFound -- Fallback.`
`423`		`- $authors = function_exists( 'get_users' ) ? get_users() : get_users_of_blog();`
`424`		`- if ( empty( $authors ) \|\| is_wp_error( $authors ) ) {`
	`424`	`+ $authors = function_exists( 'get_users' ) ? get_users() : get_users_of_blog(); // phpstan-ignore-line`
	`425`	`+ if ( empty( $authors ) ) {`
`425`	`426`	`WP_CLI::warning( 'Could not find any authors in this blog.' );`
`426`	`427`	`return false;`
`427`	`428`	`}`
`@@ -447,6 +448,9 @@ private function check_author( $author ) {`
`447`	`448`	`return true;`
`448`	`449`	`}`
`449`	`450`
	`451`	`+ /**`
	`452`	`+ * @phpstan-ignore method.unused`
	`453`	`+ */`
`450`	`454`	`private function check_max_num_posts( $num ) {`
`451`	`455`	`if ( null !== $num && ( ! is_numeric( $num ) \|\| $num <= 0 ) ) {`
`452`	`456`	`WP_CLI::warning( 'max_num_posts should be a positive integer.' );`
`@@ -473,7 +477,7 @@ private function check_category( $category ) {`
`473`	`477`	`}`
`474`	`478`
`475`	`479`	`$term = category_exists( $category );`
`476`		`- if ( empty( $term ) \|\| is_wp_error( $term ) ) {`
	`480`	`+ if ( empty( $term ) ) {`
`477`	`481`	`WP_CLI::warning( sprintf( 'Could not find a category matching %s.', $category ) );`
`478`	`482`	`return false;`
`479`	`483`	`}`
`@@ -492,7 +496,7 @@ private function check_post_status( $status ) {`
`492`	`496`	`}`
`493`	`497`
`494`	`498`	`$stati = get_post_stati();`
`495`		`- if ( empty( $stati ) \|\| is_wp_error( $stati ) ) {`
	`499`	`+ if ( empty( $stati ) ) {`
`496`	`500`	`WP_CLI::warning( 'Could not find any post stati.' );`
`497`	`501`	`return false;`
`498`	`502`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public function optional( $tag_name, $contents ) {`
`10`	`10`
`11`	`11`	`public function optional_cdata( $tag_name, $contents ) {`
`12`	`12`	`if ( $contents ) {`
`13`		`- $this->$tag_name->contains->cdata( $contents )->end;`
	`13`	`+ $this->$tag_name->contains->cdata( $contents )->end; // phpstan-ignore-line`
`14`	`14`	`}`
`15`	`15`	`return $this;`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ public function post( $post ) {`
`224`	`224`	`->tag( 'wp:postmeta' )->contains`
`225`	`225`	`->tag( 'wp:meta_key', $meta->meta_key )`
`226`	`226`	`->tag( 'wp:meta_value' )->contains->cdata( $meta->meta_value )->end`
`227`		`- ->end;`
	`227`	`+ ->end; // phpstan-ignore-line`
`228`	`228`	`}`
`229`	`229`	`foreach ( $post->comments as $comment ) {`
`230`	`230`	`$oxymel`
`@@ -242,16 +242,16 @@ public function post( $post ) {`
`242`	`242`	`->tag( 'wp:comment_parent', $comment->comment_parent )`
`243`	`243`	`->tag( 'wp:comment_user_id', $comment->user_id )`
`244`	`244`	`->oxymel( $this->comment_meta( $comment ) )`
`245`		`- ->end;`
	`245`	`+ ->end; // phpstan-ignore-line`
`246`	`246`	`}`
`247`	`247`	`$oxymel`
`248`		`- ->end;`
	`248`	`+ ->end; // phpstan-ignore-line`
`249`	`249`	`return $oxymel->to_string();`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`public function footer() {`
`253`	`253`	`$oxymel = new Oxymel();`
`254`		`- return $oxymel->close_channel->close_rss->to_string();`
	`254`	`+ return $oxymel->close_channel->close_rss->to_string(); // phpstan-ignore-line`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`protected function terms( $terms ) {`
`@@ -269,7 +269,7 @@ protected function terms( $terms ) {`
`269`	`269`	`$oxymel`
`270`	`270`	`->optional_cdata( 'wp:term_name', $term->name )`
`271`	`271`	`->optional_cdata( 'wp:term_description', $term->description )`
`272`		`- ->end;`
	`272`	`+ ->end; // phpstan-ignore-line`
`273`	`273`	`}`
`274`	`274`	`return $oxymel->to_string();`
`275`	`275`	`}`
`@@ -285,7 +285,7 @@ protected function comment_meta( $comment ) {`
`285`	`285`	`$oxymel->tag( 'wp:commentmeta' )->contains`
`286`	`286`	`->tag( 'wp:meta_key', $meta->meta_key )`
`287`	`287`	`->tag( 'wp:meta_value' )->contains->cdata( $meta->meta_value )->end`
`288`		`- ->end;`
	`288`	`+ ->end; // phpstan-ignore-line`
`289`	`289`	`}`
`290`	`290`	`return $oxymel;`
`291`	`291`	`}`