Include term meta in export file #114
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
I have added a scenario and 2 tests. |
|
I have fixed the indentation. |
|
|
||
| When I run `wp export --post_type=page --post_status=draft` | ||
| And save STDOUT 'Writing to file %s' as {EXPORT_FILE} | ||
| Then save STDOUT 'Writing to file %s' as {EXPORT_FILE} |
There was a problem hiding this comment.
The Then ... steps normally denote assertion steps, but this is still setup. If we would want to be more correct with the Behat syntax here, we would not turn it into When...Then, but rather into Given... And to show that this is still setup, and not the act/assert part.
But given this is unrelated to the current PR, I would just avoid these changes for now to keep the PR more focused.
There was a problem hiding this comment.
I have followed the examples in the previous tests in export.features.
Perhaps the similar rows must be changed as well.
| <!-- For help understanding the `testVersion` configuration setting: | ||
| https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions --> | ||
| <config name="testVersion" value="5.6-"/> | ||
| <config name="testVersion" value="7.2-"/> |
There was a problem hiding this comment.
Is this coming from a missing rebase or did You manually introduce this unrelated change?
There was a problem hiding this comment.
It doesn't talk to me. I have not changed this.
|
PR looks good, but a few unrelated changes should be stripped from this. |
5 participants
Fixes in #42