`test_archive` does not raise exception on incorrect password

[0ndt]

Hello,

I'm using patoolib.test_archive() to verify password-protected archives. When I provide an incorrect password, the function outputs error messages like:

ERROR: Wrong password : [IN]49.36.64.49[fateclan]\some_file.txt

However, it doesn't raise a PatoolError or any other exception, making it challenging to programmatically detect incorrect passwords.

Expected Behavior:

When an incorrect password is supplied, test_archive() should raise an exception (e.g., PatoolError) to allow developers to handle such cases appropriately.

Actual Behavior:

The function logs error messages to stdout/stderr but does not raise any exceptions, even when the password is incorrect.

Steps to Reproduce:

import patoolib
from patoolib.util import PatoolError

try:
    patoolib.test_archive("protected.rar", password="wrongpassword", interactive=False)
    print("Password is correct.")
except PatoolError as e:
    print("Password is incorrect:", e)

In this scenario, even with an incorrect password, no exception is raised.

Environment:

• patool version: [4.0.1]
• Python version: [3.12.10]

Thank you for your work on patool.

[wummel]

I cannot reproduce this error with 7z or rar.
In order for test_archive() to raise PatoolError the underlying archive program must return an exit code != 0

Your report does not mention what underlying archive program is used, so please the output of your command, preferrably with verbosity=1.

[0ndt]

Thank you for your response!

I'm using 7z as the underlying archive program. When running patoolib.test_archive() with an incorrect password, I do see error messages like:

ERROR: Wrong password : [IN]49.36.64.49[fateclan]\Chrome\Default\Passwords.txt

However, the function does not raise a PatoolError, which makes it hard to detect incorrect passwords programmatically.

Here's a sample of the code I'm using:

import patoolib
from patoolib.util import PatoolError

try:
    patoolib.test_archive("protected.rar", password="wrongpassword", interactive=False, verbosity=1)
    print("Password is correct.")
except PatoolError as e:
    print("Password is incorrect:", e)

And the output I get (truncated for brevity):

ERROR: Wrong password : [IN]file2.txt

Despite the clear "wrong password" messages, the command exits with code 0, so patool treats it as a success.

[wummel]

Hm, I still cannot reproduce this:

INFO patool: Testing tests/data/p.rar ...
INFO patool: detected format rar for archive tests/data/p.rar
INFO patool: running /usr/bin/7z t -y -pwrongpassword -- tests/data/p.rar
INFO patool:     with input=''

7-Zip 24.09 (x64) : Copyright (c) 1999-2024 Igor Pavlov : 2024-11-29
 64-bit locale=de_DE.UTF-8 Threads:12 OPEN_MAX:1024, ASM

Scanning the drive for archives:
1 file, 158 bytes (1 KiB)

Testing archive: tests/data/p.rar
--
Path = tests/data/p.rar
Type = Rar5
Physical Size = 158
Characteristics = Locator QuickOpen:0
Encrypted = -
Solid = -
Blocks = 2
Method = v6:128K:m5
Multivolume = -
Volumes = 1

ERROR: Wrong password : t/t.txt

Sub items Errors: 1

Archives with Errors: 1

Sub items Errors: 1
Password is incorrect: Command `['/usr/bin/7z', 't', '-y', '-pwrongpassword', '--', 'tests/data/p.rar']' returned non-zero exit status 2

The script:

import patoolib                                                                                                      from patoolib.util import PatoolError

try:
    patoolib.test_archive("tests/data/p.rar", password="wrongpassword", interactive=False, verbosity=1)                  print("Password is correct.")
except PatoolError as e:
    print("Password is incorrect:", e)

If you provide more complete output from your script (like above), or at least some more information about your system (OS version, 7z version) I can try to reproduce the error.