Fix code review issues: loop conditions, indexing, shell quoting

Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>

Author: Copilot

.github/workflows/linux-build.yml

@@ -45,13 +45,17 @@ jobs:
               -DCCAP_BUILD_TESTS=ON
     
     - name: Build
-      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel $(nproc)
+      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel "$(nproc)"
 
     - name: Verify GLFW examples build status
       working-directory: build/${{ matrix.build_type }}
       run: |
         echo "Checking built examples:"
-        ls -la | grep -E "(glfw|example)" || echo "No GLFW examples found"
+        if compgen -G "*glfw*" > /dev/null || compgen -G "*example*" > /dev/null; then
+          ls -la *glfw* *example* 2>/dev/null || true
+        else
+          echo "No GLFW examples found"
+        fi
         
         if [ "${{ matrix.build_type }}" = "Release" ]; then
           echo "Release build - checking if GLFW examples were built with system GLFW:"
@@ -124,13 +128,17 @@ jobs:
               -DCCAP_BUILD_TESTS=ON
     
     - name: Build
-      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel $(nproc)
+      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel "$(nproc)"
 
     - name: Verify build outputs
       working-directory: build/${{ matrix.build_type }}
       run: |
         echo "Checking built examples:"
-        ls -la | grep -E "(glfw|example)" || echo "No examples found"
+        if compgen -G "*glfw*" > /dev/null || compgen -G "*example*" > /dev/null; then
+          ls -la *glfw* *example* 2>/dev/null || true
+        else
+          echo "No examples found"
+        fi
         echo "✓ Build completed successfully"
     
     - name: Run Unit Tests
@@ -186,12 +194,12 @@ jobs:
               -DCCAP_BUILD_TESTS=ON
   
     - name: Build ARM64
-      run: cmake --build build/arm64/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel $(nproc)
+      run: cmake --build build/arm64/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel "$(nproc)"
 
     - name: Build ARM64 test target (Release only)
       if: matrix.build_type == 'Release'
       run: |
-        cmake --build build/arm64/${{ matrix.build_type }} --config ${{ matrix.build_type }} --target ccap_convert_test --parallel $(nproc)
+        cmake --build build/arm64/${{ matrix.build_type }} --config ${{ matrix.build_type }} --target ccap_convert_test --parallel "$(nproc)"
 
     - name: Install QEMU for ARM64 test emulation (PRs and main push, Release only)
       if: (github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/main')) && matrix.build_type == 'Release'
@@ -222,7 +230,11 @@ jobs:
       working-directory: build/arm64/${{ matrix.build_type }}
       run: |
         echo "Checking built ARM64 binaries:"
-        ls -la | grep -E "(ccap|example)" || echo "No examples found"
+        if compgen -G "*ccap*" > /dev/null || compgen -G "*example*" > /dev/null; then
+          ls -la *ccap* *example* 2>/dev/null || true
+        else
+          echo "No examples found"
+        fi
         echo "Verifying ARM64 architecture:"
         file libccap.a | grep -q "aarch64" && echo "✓ Library is ARM64" || echo "⚠ Library architecture verification failed"
         if [ -f "0-print_camera" ]; then
@@ -275,7 +287,7 @@ jobs:
               -DCCAP_BUILD_TESTS=ON
     
     - name: Build
-      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel $(nproc)
+      run: cmake --build build/${{ matrix.build_type }} --config ${{ matrix.build_type }} --parallel "$(nproc)"
 
     - name: Run Unit Tests
       if: matrix.build_type == 'Release'

src/ccap_convert.cpp

@@ -496,7 +496,7 @@ void yuyvToRgb_common(const uint8_t* src, int srcStride, uint8_t* dst, int dstSt
 
         for (int x = 0; x < width; x += 2) {
             // YUYV format: Y0 U0 Y1 V0 (4 bytes for 2 pixels)
-            int baseIdx = (x / 2) * 4;
+            int baseIdx = x * 2;
             int y0 = srcRow[baseIdx + 0]; // Y0
             int u = srcRow[baseIdx + 1];  // U0
             int y1 = srcRow[baseIdx + 2]; // Y1
@@ -552,7 +552,7 @@ void uyvyToRgb_common(const uint8_t* src, int srcStride, uint8_t* dst, int dstSt
 
         for (int x = 0; x < width; x += 2) {
             // UYVY format: U0 Y0 V0 Y1 (4 bytes for 2 pixels)
-            int baseIdx = (x / 2) * 4;
+            int baseIdx = x * 2;
             int u = srcRow[baseIdx + 0];  // U0
             int y0 = srcRow[baseIdx + 1]; // Y0
             int v = srcRow[baseIdx + 2];  // V0

src/ccap_convert_avx2.cpp

@@ -1178,8 +1178,7 @@ AVX2_TARGET void yuyvToRgb_avx2_imp(const uint8_t* src, int srcStride, uint8_t*
         }
 
         // Handle remaining pixels (scalar implementation)
-        for (; x < width; x += 2) {
-            if (x + 1 >= width) break; // YUYV needs to be processed in pairs
+        for (; x + 1 < width; x += 2) {
 
             // YUYV format: Y0 U0 Y1 V0 (4 bytes for 2 pixels)
             int baseIdx = x * 2;
@@ -1405,8 +1404,7 @@ AVX2_TARGET void uyvyToRgb_avx2_imp(const uint8_t* src, int srcStride, uint8_t*
         }
 
         // Handle remaining pixels (scalar implementation)
-        for (; x < width; x += 2) {
-            if (x + 1 >= width) break; // UYVY requires paired processing
+        for (; x + 1 < width; x += 2) {
 
             // UYVY format: U0 Y0 V0 Y1 (4 bytes for 2 pixels)
             int baseIdx = x * 2;