Skip to content

Commit cd5e222

Browse files
committed
quicktest: test tags being copied on vdi clone and snapshot
Fail if tags are not copied, this follows behaviour for VMs Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
1 parent f7e1f97 commit cd5e222

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

ocaml/quicktest/quicktest_vdi.ml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ module A = Quicktest_args
22

33
let ( let@ ) f x = f x
44

5+
let tags = ["quick"; "test"]
6+
57
(** If VDI_CREATE and VDI_DELETE are present then make sure VDIs appear and disappear correctly
68
VDI_CREATE should make a fresh disk; VDI_DELETE should remove it *)
79
let vdi_create_destroy rpc session_id sr_info () =
@@ -175,6 +177,7 @@ let check_clone_snapshot_fields rpc session_id original_vdi new_vdi =
175177
, fun vdi -> vdi.API.vDI_virtual_size |> Int64.to_string
176178
)
177179
; (`Different, "location", fun vdi -> vdi.API.vDI_location)
180+
; (`Same, "tags", fun vdi -> String.concat ", " vdi.API.vDI_tags)
178181
]
179182
in
180183
let a = Client.Client.VDI.get_record ~rpc ~session_id ~self:original_vdi in
@@ -202,10 +205,12 @@ let check_vdi_snapshot rpc session_id vdi =
202205

203206
let test_vdi_snapshot rpc session_id sr_info () =
204207
let@ vdi = Qt.VDI.with_any rpc session_id sr_info in
208+
Client.Client.VDI.set_tags ~rpc ~session_id ~self:vdi ~value:tags ;
205209
check_vdi_snapshot rpc session_id vdi
206210

207211
let test_vdi_clone rpc session_id sr_info () =
208212
let@ vdi = Qt.VDI.with_any rpc session_id sr_info in
213+
Client.Client.VDI.set_tags ~rpc ~session_id ~self:vdi ~value:tags ;
209214
let vdi' = Client.Client.VDI.clone ~rpc ~session_id ~vdi ~driver_params:[] in
210215
let@ () = Qt.VDI.with_destroyed rpc session_id vdi' in
211216
check_clone_snapshot_fields rpc session_id vdi vdi'
@@ -221,6 +226,7 @@ let vbd_create_helper ~rpc ~session_id ~vM ~vDI ?(userdevice = "autodetect") ()
221226
(** Check that snapshot works regardless which host has the VDI activated *)
222227
let vdi_snapshot_in_pool rpc session_id sr_info () =
223228
let@ vdi = Qt.VDI.with_any rpc session_id sr_info in
229+
Client.Client.VDI.set_tags ~rpc ~session_id ~self:vdi ~value:tags ;
224230
let localhost =
225231
Client.Client.Host.get_by_uuid ~rpc ~session_id ~uuid:Qt.localhost_uuid
226232
in

0 commit comments

Comments
 (0)