fix(linstorvolumemanager): don't allow InUse volumes to be deleted

Check for usage status before deleting a linstor volume and raise an appropriate error if this happens

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>

Author: klmp200

drivers/linstorvolumemanager.py

@@ -15,7 +15,7 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 
-from sm_typing import override
+from sm_typing import Dict, override
 
 import errno
 import json
@@ -682,10 +682,16 @@ def destroy_volume(self, volume_uuid):
         Destroy a volume.
         :param str volume_uuid: The volume uuid to destroy.
         """
-
         self._ensure_volume_exists(volume_uuid)
         self.ensure_volume_is_not_locked(volume_uuid)
 
+        is_volume_in_use = any(node["in-use"] for node in self.get_resource_info(volume_uuid)["nodes"].values())
+        if is_volume_in_use:
+            raise LinstorVolumeManagerError(
+                f"Could not destroy volume `{volume_uuid}` as it is currently in use",
+                LinstorVolumeManagerError.ERR_VOLUME_DESTROY
+            )
+
         # Mark volume as destroyed.
         volume_properties = self._get_volume_properties(volume_uuid)
         volume_properties[self.PROP_NOT_EXISTS] = self.STATE_NOT_EXISTS
@@ -1741,6 +1747,21 @@ def get_resources_info(self):
 
         return resources
 
+    def get_resource_info(self, volume_uuid: str) -> Dict:
+        """
+        Give all resources info with provided uuid on current group name.
+        :param: volume_uuid
+        :rtype: dict
+        """
+        for volume in self.get_resources_info().values():
+            if volume["uuid"] == volume_uuid:
+                return volume
+
+        raise LinstorVolumeManagerError(
+            f"Could not find info about volume `{volume_uuid}`",
+            LinstorVolumeManagerError.ERR_VOLUME_DESTROY
+        )
+
     def get_database_path(self):
         """
         Get the database path.