Skip to content

Commit 9891855

Browse files
committed
Merge remote-tracking branch 'origin/update-from-template' into develop
2 parents 7ca2a87 + eff887a commit 9891855

File tree

9 files changed

+61
-20
lines changed

9 files changed

+61
-20
lines changed

.config/pmd/ruleset.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@
5959
<!-- Prohibits singleton pattern -->
6060
<exclude name="MutableStaticState"/>
6161

62+
<!-- Checks LoC, already handled by Checkstyle -->
63+
<exclude name="NcssCount"/>
64+
6265
<!-- Some override methods or Junit require this -->
6366
<exclude name="SignatureDeclareThrowsException"/>
6467

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ jobs:
157157
cache: 'maven'
158158

159159
- name: Build site
160-
run: ../mvnw -B site -DskipTests
160+
run: ../mvnw -B compile site -DskipTests -T2C
161161
working-directory: ${{ env.PRIMARY_MAVEN_MODULE }}
162162

163163
- name: Deploy to Github pages

.github/workflows/sonar.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
- '.idea/**'
1212
- 'assets/**'
1313
pull_request:
14-
types: [opened, synchronize, reopened]
14+
branches: [ develop ]
1515
paths-ignore:
1616
- '**.md'
1717
- '.config/**'

.github/workflows/test-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
2525

2626
- name: Publish to OSSRH
27-
run: ../mvnw -B deploy -Possrh
27+
run: ../mvnw -B deploy -Possrh -DskipTests
2828
working-directory: ${{ env.PRIMARY_MAVEN_MODULE }}
2929
env:
3030
MAVEN_CENTRAL_USERNAME: ${{ secrets.S01_OSS_SONATYPE_MAVEN_USERNAME }}

.mvn/wrapper/maven-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
# KIND, either express or implied. See the License for the
1515
# specific language governing permissions and limitations
1616
# under the License.
17-
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.8/apache-maven-3.9.8-bin.zip
17+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip

CONTRIBUTING.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,31 @@ If the ``develop`` is ready for release, create a pull request to the ``master``
4444

4545
When the release is finished do the following:
4646
* Merge the auto-generated PR (with the incremented version number) back into the ``develop``
47+
48+
### Release failures
49+
50+
There are 2 modes of release failure:
51+
1. The remote server was e.g. down and non of the artifacts got published
52+
2. There was a build failure during release and only parts of the artifacts got released
53+
54+
In case 1 we can re-release the existing version,<br/>in case 2 we have to release a new version when we can't get the artifacts deleted (as is the case with Maven Central)
55+
56+
#### How-to: Re-Releasing an existing version
57+
58+
1. Delete the release on GitHub
59+
2. Delete the release Git tag from the repo (locally and remote!)
60+
3. Delete the ``master``-Branch and re-create it from the ``develop`` branch (or reset it to the state before the release-workflow commits have been done)
61+
* This requires __temporarily__ removing the branch protection
62+
* Once this was done a new release is triggered immediately!
63+
64+
#### How-to: Releasing a new version
65+
66+
1. Merge the ``master`` branch back into ``develop`` (or another temporary branch)
67+
2. Make sure all master branch versions are prepared for a new release<br/>e.g. if the broken release was ``1.0.0`` the version should now be at ``1.0.1-SNAPSHOT`` - the ``SNAPSHOT`` is important for the workflow!
68+
3. Mark the broken release as broken e.g. inside the Changelog, GitHub Release page, etc.<br/>
69+
You can use something like this:
70+
```
71+
> [!WARNING]
72+
> This release is broken as my cat accidentally clicked the abort button during the process
73+
```
74+
4. Merge the changes back into the ``master`` branch to trigger a new release

pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@
4040
<plugin>
4141
<groupId>org.apache.maven.plugins</groupId>
4242
<artifactId>maven-checkstyle-plugin</artifactId>
43-
<version>3.4.0</version>
43+
<version>3.5.0</version>
4444
<dependencies>
4545
<dependency>
4646
<groupId>com.puppycrawl.tools</groupId>
4747
<artifactId>checkstyle</artifactId>
48-
<version>10.17.0</version>
48+
<version>10.18.1</version>
4949
</dependency>
5050
</dependencies>
5151
<configuration>
@@ -70,7 +70,7 @@
7070
<plugin>
7171
<groupId>org.apache.maven.plugins</groupId>
7272
<artifactId>maven-pmd-plugin</artifactId>
73-
<version>3.23.0</version>
73+
<version>3.25.0</version>
7474
<configuration>
7575
<includeTests>true</includeTests>
7676
<printFailingErrors>true</printFailingErrors>
@@ -82,12 +82,12 @@
8282
<dependency>
8383
<groupId>net.sourceforge.pmd</groupId>
8484
<artifactId>pmd-core</artifactId>
85-
<version>7.3.0</version>
85+
<version>7.5.0</version>
8686
</dependency>
8787
<dependency>
8888
<groupId>net.sourceforge.pmd</groupId>
8989
<artifactId>pmd-java</artifactId>
90-
<version>7.3.0</version>
90+
<version>7.5.0</version>
9191
</dependency>
9292
</dependencies>
9393
</plugin>
@@ -99,7 +99,7 @@
9999
<plugin>
100100
<groupId>org.apache.maven.plugins</groupId>
101101
<artifactId>maven-jxr-plugin</artifactId>
102-
<version>3.4.0</version>
102+
<version>3.5.0</version>
103103
</plugin>
104104
</plugins>
105105
</reporting>

renovate.json5

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,16 @@
1010
],
1111
"enabled": false
1212
},
13+
{
14+
"description": "Group net.sourceforge.pmd",
15+
"matchPackagePatterns": [
16+
"^net.sourceforge.pmd"
17+
],
18+
"datasources": [
19+
"maven"
20+
],
21+
"groupName": "net.sourceforge.pmd"
22+
},
1323
{
1424
"description": "Group Spring Boot",
1525
"matchPackagePatterns": [

spring-security-advanced-authentication-ui/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,12 @@
112112
<plugin>
113113
<groupId>org.apache.maven.plugins</groupId>
114114
<artifactId>maven-site-plugin</artifactId>
115-
<version>4.0.0-M15</version>
115+
<version>4.0.0-M16</version>
116116
</plugin>
117117
<plugin>
118118
<groupId>org.apache.maven.plugins</groupId>
119119
<artifactId>maven-project-info-reports-plugin</artifactId>
120-
<version>3.6.1</version>
120+
<version>3.7.0</version>
121121
</plugin>
122122
</plugins>
123123
</pluginManagement>
@@ -165,7 +165,7 @@
165165
<plugin>
166166
<groupId>org.apache.maven.plugins</groupId>
167167
<artifactId>maven-javadoc-plugin</artifactId>
168-
<version>3.7.0</version>
168+
<version>3.10.0</version>
169169
<executions>
170170
<execution>
171171
<id>attach-javadocs</id>
@@ -227,7 +227,7 @@
227227
<plugin>
228228
<groupId>org.apache.maven.plugins</groupId>
229229
<artifactId>maven-gpg-plugin</artifactId>
230-
<version>3.2.4</version>
230+
<version>3.2.6</version>
231231
<executions>
232232
<execution>
233233
<id>sign-artifacts</id>
@@ -270,12 +270,12 @@
270270
<plugin>
271271
<groupId>org.apache.maven.plugins</groupId>
272272
<artifactId>maven-checkstyle-plugin</artifactId>
273-
<version>3.4.0</version>
273+
<version>3.5.0</version>
274274
<dependencies>
275275
<dependency>
276276
<groupId>com.puppycrawl.tools</groupId>
277277
<artifactId>checkstyle</artifactId>
278-
<version>10.17.0</version>
278+
<version>10.18.1</version>
279279
</dependency>
280280
</dependencies>
281281
<configuration>
@@ -300,7 +300,7 @@
300300
<plugin>
301301
<groupId>org.apache.maven.plugins</groupId>
302302
<artifactId>maven-pmd-plugin</artifactId>
303-
<version>3.23.0</version>
303+
<version>3.25.0</version>
304304
<configuration>
305305
<includeTests>true</includeTests>
306306
<printFailingErrors>true</printFailingErrors>
@@ -312,12 +312,12 @@
312312
<dependency>
313313
<groupId>net.sourceforge.pmd</groupId>
314314
<artifactId>pmd-core</artifactId>
315-
<version>7.3.0</version>
315+
<version>7.5.0</version>
316316
</dependency>
317317
<dependency>
318318
<groupId>net.sourceforge.pmd</groupId>
319319
<artifactId>pmd-java</artifactId>
320-
<version>7.3.0</version>
320+
<version>7.5.0</version>
321321
</dependency>
322322
</dependencies>
323323
</plugin>
@@ -329,7 +329,7 @@
329329
<plugin>
330330
<groupId>org.apache.maven.plugins</groupId>
331331
<artifactId>maven-jxr-plugin</artifactId>
332-
<version>3.4.0</version>
332+
<version>3.5.0</version>
333333
</plugin>
334334
</plugins>
335335
</reporting>

0 commit comments

Comments
 (0)