Provided example of an addon outdated

[QuackieMackie]

https://xenforo.com/docs/dev/lets-build-an-add-on/#xf-20-requirements

At the bottom of this document, theres a downloadable zip file, if you upload that into Xenforo 2.3.6 it appears fine, it has no problems getting added.

But if you open your forum again you get this error:

PHP Fatal error:  Declaration of Demo\Portal\XF\Entity\Thread::canFeatureUnfeature() must be compatible with XF\Entity\Thread::canFeatureUnfeature(&$error = null): bool in C:\inetpub\wwwroot\xenforo\src\addons\Demo\Portal\XF\Entity\Thread.php on line 7

[chrisdeeming]

So the awkward thing about this is that the demo add-on preceded us having any sort of actual content featuring in the core.

In an ideal world, we'd come up with an entirely new add-on to demonstrate the add-on system. Perhaps one that is more extensive.

[QuackieMackie]

So the awkward thing about this is that the demo add-on preceded us having any sort of actual content featuring in the core.

In an ideal world, we'd come up with an entirely new add-on to demonstrate the add-on system. Perhaps one that is more extensive.

In my PR #67 I added a new add-on. It was smaller and quicker to write. Could we not do something similar instead of one huge add-on?

Multiple add-ons that use concepts rather one add-on that uses all the concepts.
For example:

• An add-on that creates an api scope.
• An add-on that creates a new web hook.
• An add-on that creates a new thread type.
• etc...

This would be easier to refactor for each new version of Xenforo.