From cff19626691d3c582a49a761b0536774b90a7427 Mon Sep 17 00:00:00 2001 From: Edward Hennis Date: Wed, 20 Jan 2021 16:57:48 -0500 Subject: [PATCH 1/3] Log Validator Lists received from peers --- src/xrpld/overlay/detail/PeerImp.cpp | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp index b85536c6f1b..60614f08e10 100644 --- a/src/xrpld/overlay/detail/PeerImp.cpp +++ b/src/xrpld/overlay/detail/PeerImp.cpp @@ -2142,6 +2142,24 @@ PeerImp::onValidatorListMessage( return; } + { + JLOG(p_journal_.debug()) << "Manifest: " << base64_decode(manifest); + JLOG(p_journal_.debug()) << "Version: " << version; + JLOG(p_journal_.debug()) << "Hash: " << hash; + std::size_t count = 1; + for (auto const& blob : blobs) + { + JLOG(p_journal_.debug()) + << "Blob " << count << " Signature: " << blob.signature; + JLOG(p_journal_.debug()) + << "Blob " << count << " blob: " << base64_decode(blob.blob); + JLOG(p_journal_.debug()) + << "Blob " << count << " manifest: " + << (blob.manifest ? base64_decode(*blob.manifest) : "NONE"); + ++count; + } + } + auto const applyResult = app_.validators().applyListsAndBroadcast( manifest, version, From 73cd1c7e6d638eb0a037a867ff604b47d4219413 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Thu, 20 Mar 2025 12:04:06 -0400 Subject: [PATCH 2/3] Log everything in one message. Split log messages suck. --- src/xrpld/overlay/detail/PeerImp.cpp | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp index 60614f08e10..69ad6b074f2 100644 --- a/src/xrpld/overlay/detail/PeerImp.cpp +++ b/src/xrpld/overlay/detail/PeerImp.cpp @@ -2142,22 +2142,23 @@ PeerImp::onValidatorListMessage( return; } + if (auto const sink = p_journal_.debug()) { - JLOG(p_journal_.debug()) << "Manifest: " << base64_decode(manifest); - JLOG(p_journal_.debug()) << "Version: " << version; - JLOG(p_journal_.debug()) << "Hash: " << hash; + std::stringstream str; + str << "Manifest: " << base64_decode(manifest); + str << " Version: " << version; + str << " Hash: " << hash; std::size_t count = 1; for (auto const& blob : blobs) { - JLOG(p_journal_.debug()) - << "Blob " << count << " Signature: " << blob.signature; - JLOG(p_journal_.debug()) - << "Blob " << count << " blob: " << base64_decode(blob.blob); - JLOG(p_journal_.debug()) - << "Blob " << count << " manifest: " + str << " Blob " << count << ":"; + str << " Signature: " << blob.signature; + str << " blob: " << base64_decode(blob.blob); + str << " manifest: " << (blob.manifest ? base64_decode(*blob.manifest) : "NONE"); ++count; } + sink << str.str(); } auto const applyResult = app_.validators().applyListsAndBroadcast( From 2c8f6ccd09028818195026d4e0a04c6af2c3f6d5 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Wed, 28 Jan 2026 20:10:54 -0500 Subject: [PATCH 3/3] Fix formatting --- src/xrpld/overlay/detail/PeerImp.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp index d5b160b6ff2..cfb010f9396 100644 --- a/src/xrpld/overlay/detail/PeerImp.cpp +++ b/src/xrpld/overlay/detail/PeerImp.cpp @@ -1976,8 +1976,7 @@ PeerImp::onValidatorListMessage( str << " Blob " << count << ":"; str << " Signature: " << blob.signature; str << " blob: " << base64_decode(blob.blob); - str << " manifest: " - << (blob.manifest ? base64_decode(*blob.manifest) : "NONE"); + str << " manifest: " << (blob.manifest ? base64_decode(*blob.manifest) : "NONE"); ++count; } sink << str.str();