Code standards

Author: Yandawl

README.md

@@ -6,45 +6,45 @@ An asynchronous Python client for XIVAPI
 [![Python 3.6](https://img.shields.io/badge/python-3.6-green.svg)](https://www.python.org/downloads/release/python-360/)
 
 ## Requirements
-```
+```python
 python>=3.6.0
 asyncio
 aiohttp
 ```
 
 ## Installation
-```
+```python
 pip install xivapi-py
 ```
 
 ## Supported API end points
 
-* /character/search
-* /character/id
-* /character/verify
-* /character/update
-* /freecompany/search
-* /freecompany/id
-* /linkshell/search
-* /linkshell/id
-* /pvpteam/search
-* /pvpteam/id
-* /index/search (e.g. recipe, item, action, pvpaction, mount, e.t.c.)
-* /index/id
-* /lore/search
-* /market/item/id?servers=Phoenix,Odin
-* /market/item/id?dc=Chaos
-* /lodestone
-* /lodestone/news
-* /lodestone/notices
-* /lodestone/maintenance
-* /lodestone/updates
-* /lodestone/status
-* /lodestone/worldstatus
-* /lodestone/devblog
-* /lodestone/devposts
-* /lodestone/deepdungeon
-* /lodestone/feasts
+*   /character/search
+*   /character/id
+*   /character/verify
+*   /character/update
+*   /freecompany/search
+*   /freecompany/id
+*   /linkshell/search
+*   /linkshell/id
+*   /pvpteam/search
+*   /pvpteam/id
+*   /index/search (e.g. recipe, item, action, pvpaction, mount, e.t.c.)
+*   /index/id
+*   /lore/search
+*   /market/item/id?servers=Phoenix,Odin
+*   /market/item/id?dc=Chaos
+*   /lodestone
+*   /lodestone/news
+*   /lodestone/notices
+*   /lodestone/maintenance
+*   /lodestone/updates
+*   /lodestone/status
+*   /lodestone/worldstatus
+*   /lodestone/devblog
+*   /lodestone/devposts
+*   /lodestone/deepdungeon
+*   /lodestone/feasts
 
 ## Documentation
 https://xivapi.com/docs/

xivapi/client.py

@@ -1,10 +1,7 @@
-import asyncio
 import logging
 from typing import List
 
-import aiohttp
-
-from .exceptions import XIVAPIBadRequest, XIVAPIForbidden, XIVAPINotFound, XIVAPIServiceUnavailable, XIVAPIInvalidLanguage, XIVAPIError, XIVAPIInvalidIndex, XIVAPIInvalidColumns, XIVAPIInvalidWorlds, XIVAPIInvalidDatacenter
+from .exceptions import XIVAPIBadRequest, XIVAPIForbidden, XIVAPINotFound, XIVAPIServiceUnavailable, XIVAPIInvalidLanguage, XIVAPIError, XIVAPIInvalidIndex, XIVAPIInvalidColumns, XIVAPIInvalidWorlds
 from .decorators import timed
 from .models import Filter, Sort
 
@@ -242,7 +239,7 @@ async def pvpteam_by_id(self, lodestone_id):
 
 
     @timed
-    async def index_search(self, name, indexes=[], columns=[], filters: List[Filter]=list(), sort: Sort=None, page=1, language="en"):
+    async def index_search(self, name, indexes=(), columns=(), filters: List[Filter]=(), sort: Sort=None, page=1, language="en"):
         """|coro|
         Search for data from on specific indexes.
         Parameters
@@ -339,7 +336,7 @@ async def index_search(self, name, indexes=[], columns=[], filters: List[Filter]
                 })
 
             body["body"]["query"]["bool"]["filter"] = filts
-        
+
         if sort:
             body["body"]["sort"] = [{
                 sort.Field: "asc" if sort.Ascending else "desc"
@@ -351,7 +348,7 @@ async def index_search(self, name, indexes=[], columns=[], filters: List[Filter]
 
 
     @timed
-    async def index_by_id(self, index, content_id: int, columns=[], language="en"):
+    async def index_by_id(self, index, content_id: int, columns=(), language="en"):
         """|coro|
         Request data from a given index by ID.
         Parameters

xivapi/models.py

@@ -1,6 +1,6 @@
 from .exceptions import XIVAPIInvalidFilter
 
-class Filter: 
+class Filter:
     """
     Model class for DQL filters
     """
@@ -18,7 +18,7 @@ def __init__(self, field: str, comparison: str, value: int):
         self.Value = value
 
 
-class Sort: 
+class Sort:
     """
     Model class for sort field
     """