diff --git a/.gitignore b/.gitignore index 67045665db..00012f8f10 100644 --- a/.gitignore +++ b/.gitignore @@ -1,104 +1,47 @@ +# Java / Maven +target/ +!**/src/main/**/target/ +!**/src/test/**/target/ +*.class +*.jar +*.war +*.ear + +# Maven wrapper +.mvn/wrapper/maven-wrapper.jar + +# IDE +.idea/ +*.iws +*.iml +*.ipr +.project +.classpath +.factorypath +.settings/ +.springBeans +.sts4-cache +.apt_generated +.vscode/ +/nbproject/private/ +/nbbuild/ +/dist/ +/nbdist/ +/.nb-gradle/ + +# OS +.DS_Store +Thumbs.db + # Logs -logs *.log -npm-debug.log* -yarn-debug.log* -yarn-error.log* -lerna-debug.log* - -# Diagnostic reports (https://nodejs.org/api/report.html) -report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json - -# Runtime data -pids -*.pid -*.seed -*.pid.lock - -# Directory for instrumented libs generated by jscoverage/JSCover -lib-cov - -# Coverage directory used by tools like istanbul -coverage -*.lcov - -# nyc test coverage -.nyc_output - -# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) -.grunt - -# Bower dependency directory (https://bower.io/) -bower_components - -# node-waf configuration -.lock-wscript - -# Compiled binary addons (https://nodejs.org/api/addons.html) -build/Release - -# Dependency directories -node_modules/ -jspm_packages/ - -# TypeScript v1 declaration files -typings/ - -# TypeScript cache -*.tsbuildinfo - -# Optional npm cache directory -.npm -# Optional eslint cache -.eslintcache - -# Microbundle cache -.rpt2_cache/ -.rts2_cache_cjs/ -.rts2_cache_es/ -.rts2_cache_umd/ - -# Optional REPL history -.node_repl_history - -# Output of 'npm pack' -*.tgz - -# Yarn Integrity file -.yarn-integrity - -# dotenv environment variables file +# Environment .env .env.test -# parcel-bundler cache (https://parceljs.org/) -.cache - -# Next.js build output -.next - -# Nuxt.js build / generate output -.nuxt -dist - -# Gatsby files -.cache/ -# Comment in the public line in if your project uses Gatsby and *not* Next.js -# https://nextjs.org/blog/next-9-1#public-directory-support -# public - -# vuepress build output -.vuepress/dist - -# Serverless directories -.serverless/ - -# FuseBox cache -.fusebox/ - -# DynamoDB Local files -.dynamodb/ - -# TernJS port file -.tern-port +# Build +build/ +!**/src/main/**/build/ +!**/src/test/**/build/ +HELP.md diff --git a/docker-compose.yml b/docker-compose.yml index 0e8807f21c..24717ad2e5 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -3,10 +3,17 @@ services: postgres: image: postgres:14 ports: - - "5432:5432" + - "5433:5432" environment: - POSTGRES_USER=postgres - POSTGRES_PASSWORD=postgres + volumes: + - postgres_data:/var/lib/postgresql/data + healthcheck: + test: ["CMD-SHELL", "pg_isready -U postgres"] + interval: 5s + timeout: 5s + retries: 5 zookeeper: image: confluentinc/cp-zookeeper:5.5.3 environment: @@ -23,3 +30,20 @@ services: KAFKA_JMX_PORT: 9991 ports: - 9092:9092 + healthcheck: + test: ["CMD-SHELL", "kafka-broker-api-versions --bootstrap-server localhost:9092"] + interval: 10s + timeout: 10s + retries: 10 + redis: + image: redis:7-alpine + ports: + - "6379:6379" + healthcheck: + test: ["CMD", "redis-cli", "ping"] + interval: 5s + timeout: 5s + retries: 5 + +volumes: + postgres_data: diff --git a/yape-code-challenge/.dockerignore b/yape-code-challenge/.dockerignore new file mode 100644 index 0000000000..1044af2144 --- /dev/null +++ b/yape-code-challenge/.dockerignore @@ -0,0 +1,6 @@ +target/ +.git +*.md +.idea/ +*.iml +.DS_Store diff --git a/yape-code-challenge/.gitattributes b/yape-code-challenge/.gitattributes new file mode 100644 index 0000000000..3b41682ac5 --- /dev/null +++ b/yape-code-challenge/.gitattributes @@ -0,0 +1,2 @@ +/mvnw text eol=lf +*.cmd text eol=crlf diff --git a/yape-code-challenge/.gitignore b/yape-code-challenge/.gitignore new file mode 100644 index 0000000000..667aaef0c8 --- /dev/null +++ b/yape-code-challenge/.gitignore @@ -0,0 +1,33 @@ +HELP.md +target/ +.mvn/wrapper/maven-wrapper.jar +!**/src/main/**/target/ +!**/src/test/**/target/ + +### STS ### +.apt_generated +.classpath +.factorypath +.project +.settings +.springBeans +.sts4-cache + +### IntelliJ IDEA ### +.idea +*.iws +*.iml +*.ipr + +### NetBeans ### +/nbproject/private/ +/nbbuild/ +/dist/ +/nbdist/ +/.nb-gradle/ +build/ +!**/src/main/**/build/ +!**/src/test/**/build/ + +### VS Code ### +.vscode/ diff --git a/yape-code-challenge/.mvn/wrapper/maven-wrapper.properties b/yape-code-challenge/.mvn/wrapper/maven-wrapper.properties new file mode 100644 index 0000000000..8dea6c227c --- /dev/null +++ b/yape-code-challenge/.mvn/wrapper/maven-wrapper.properties @@ -0,0 +1,3 @@ +wrapperVersion=3.3.4 +distributionType=only-script +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/apache-maven-3.9.12-bin.zip diff --git a/yape-code-challenge/Dockerfile b/yape-code-challenge/Dockerfile new file mode 100644 index 0000000000..f6e6cd9980 --- /dev/null +++ b/yape-code-challenge/Dockerfile @@ -0,0 +1,15 @@ +FROM eclipse-temurin:17-jdk AS build +WORKDIR /app +COPY .mvn/ .mvn/ +COPY mvnw pom.xml ./ +RUN ./mvnw dependency:go-offline -B +COPY src/ src/ +RUN ./mvnw clean package -DskipTests -B + +FROM eclipse-temurin:17-jre +WORKDIR /app +RUN groupadd -r appgroup && useradd -r -g appgroup appuser +COPY --from=build /app/target/*.jar app.jar +USER appuser +EXPOSE 8080 +ENTRYPOINT ["java", "-jar", "app.jar"] diff --git a/yape-code-challenge/mvnw b/yape-code-challenge/mvnw new file mode 100755 index 0000000000..bd8896bf22 --- /dev/null +++ b/yape-code-challenge/mvnw @@ -0,0 +1,295 @@ +#!/bin/sh +# ---------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ---------------------------------------------------------------------------- + +# ---------------------------------------------------------------------------- +# Apache Maven Wrapper startup batch script, version 3.3.4 +# +# Optional ENV vars +# ----------------- +# JAVA_HOME - location of a JDK home dir, required when download maven via java source +# MVNW_REPOURL - repo url base for downloading maven distribution +# MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +# MVNW_VERBOSE - true: enable verbose log; debug: trace the mvnw script; others: silence the output +# ---------------------------------------------------------------------------- + +set -euf +[ "${MVNW_VERBOSE-}" != debug ] || set -x + +# OS specific support. +native_path() { printf %s\\n "$1"; } +case "$(uname)" in +CYGWIN* | MINGW*) + [ -z "${JAVA_HOME-}" ] || JAVA_HOME="$(cygpath --unix "$JAVA_HOME")" + native_path() { cygpath --path --windows "$1"; } + ;; +esac + +# set JAVACMD and JAVACCMD +set_java_home() { + # For Cygwin and MinGW, ensure paths are in Unix format before anything is touched + if [ -n "${JAVA_HOME-}" ]; then + if [ -x "$JAVA_HOME/jre/sh/java" ]; then + # IBM's JDK on AIX uses strange locations for the executables + JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACCMD="$JAVA_HOME/jre/sh/javac" + else + JAVACMD="$JAVA_HOME/bin/java" + JAVACCMD="$JAVA_HOME/bin/javac" + + if [ ! -x "$JAVACMD" ] || [ ! -x "$JAVACCMD" ]; then + echo "The JAVA_HOME environment variable is not defined correctly, so mvnw cannot run." >&2 + echo "JAVA_HOME is set to \"$JAVA_HOME\", but \"\$JAVA_HOME/bin/java\" or \"\$JAVA_HOME/bin/javac\" does not exist." >&2 + return 1 + fi + fi + else + JAVACMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v java + )" || : + JAVACCMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v javac + )" || : + + if [ ! -x "${JAVACMD-}" ] || [ ! -x "${JAVACCMD-}" ]; then + echo "The java/javac command does not exist in PATH nor is JAVA_HOME set, so mvnw cannot run." >&2 + return 1 + fi + fi +} + +# hash string like Java String::hashCode +hash_string() { + str="${1:-}" h=0 + while [ -n "$str" ]; do + char="${str%"${str#?}"}" + h=$(((h * 31 + $(LC_CTYPE=C printf %d "'$char")) % 4294967296)) + str="${str#?}" + done + printf %x\\n $h +} + +verbose() { :; } +[ "${MVNW_VERBOSE-}" != true ] || verbose() { printf %s\\n "${1-}"; } + +die() { + printf %s\\n "$1" >&2 + exit 1 +} + +trim() { + # MWRAPPER-139: + # Trims trailing and leading whitespace, carriage returns, tabs, and linefeeds. + # Needed for removing poorly interpreted newline sequences when running in more + # exotic environments such as mingw bash on Windows. + printf "%s" "${1}" | tr -d '[:space:]' +} + +scriptDir="$(dirname "$0")" +scriptName="$(basename "$0")" + +# parse distributionUrl and optional distributionSha256Sum, requires .mvn/wrapper/maven-wrapper.properties +while IFS="=" read -r key value; do + case "${key-}" in + distributionUrl) distributionUrl=$(trim "${value-}") ;; + distributionSha256Sum) distributionSha256Sum=$(trim "${value-}") ;; + esac +done <"$scriptDir/.mvn/wrapper/maven-wrapper.properties" +[ -n "${distributionUrl-}" ] || die "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" + +case "${distributionUrl##*/}" in +maven-mvnd-*bin.*) + MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ + case "${PROCESSOR_ARCHITECTURE-}${PROCESSOR_ARCHITEW6432-}:$(uname -a)" in + *AMD64:CYGWIN* | *AMD64:MINGW*) distributionPlatform=windows-amd64 ;; + :Darwin*x86_64) distributionPlatform=darwin-amd64 ;; + :Darwin*arm64) distributionPlatform=darwin-aarch64 ;; + :Linux*x86_64*) distributionPlatform=linux-amd64 ;; + *) + echo "Cannot detect native platform for mvnd on $(uname)-$(uname -m), use pure java version" >&2 + distributionPlatform=linux-amd64 + ;; + esac + distributionUrl="${distributionUrl%-bin.*}-$distributionPlatform.zip" + ;; +maven-mvnd-*) MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ ;; +*) MVN_CMD="mvn${scriptName#mvnw}" _MVNW_REPO_PATTERN=/org/apache/maven/ ;; +esac + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +[ -z "${MVNW_REPOURL-}" ] || distributionUrl="$MVNW_REPOURL$_MVNW_REPO_PATTERN${distributionUrl#*"$_MVNW_REPO_PATTERN"}" +distributionUrlName="${distributionUrl##*/}" +distributionUrlNameMain="${distributionUrlName%.*}" +distributionUrlNameMain="${distributionUrlNameMain%-bin}" +MAVEN_USER_HOME="${MAVEN_USER_HOME:-${HOME}/.m2}" +MAVEN_HOME="${MAVEN_USER_HOME}/wrapper/dists/${distributionUrlNameMain-}/$(hash_string "$distributionUrl")" + +exec_maven() { + unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || : + exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec $MAVEN_HOME/bin/$MVN_CMD" +} + +if [ -d "$MAVEN_HOME" ]; then + verbose "found existing MAVEN_HOME at $MAVEN_HOME" + exec_maven "$@" +fi + +case "${distributionUrl-}" in +*?-bin.zip | *?maven-mvnd-?*-?*.zip) ;; +*) die "distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found '${distributionUrl-}'" ;; +esac + +# prepare tmp dir +if TMP_DOWNLOAD_DIR="$(mktemp -d)" && [ -d "$TMP_DOWNLOAD_DIR" ]; then + clean() { rm -rf -- "$TMP_DOWNLOAD_DIR"; } + trap clean HUP INT TERM EXIT +else + die "cannot create temp dir" +fi + +mkdir -p -- "${MAVEN_HOME%/*}" + +# Download and Install Apache Maven +verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +verbose "Downloading from: $distributionUrl" +verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +# select .zip or .tar.gz +if ! command -v unzip >/dev/null; then + distributionUrl="${distributionUrl%.zip}.tar.gz" + distributionUrlName="${distributionUrl##*/}" +fi + +# verbose opt +__MVNW_QUIET_WGET=--quiet __MVNW_QUIET_CURL=--silent __MVNW_QUIET_UNZIP=-q __MVNW_QUIET_TAR='' +[ "${MVNW_VERBOSE-}" != true ] || __MVNW_QUIET_WGET='' __MVNW_QUIET_CURL='' __MVNW_QUIET_UNZIP='' __MVNW_QUIET_TAR=v + +# normalize http auth +case "${MVNW_PASSWORD:+has-password}" in +'') MVNW_USERNAME='' MVNW_PASSWORD='' ;; +has-password) [ -n "${MVNW_USERNAME-}" ] || MVNW_USERNAME='' MVNW_PASSWORD='' ;; +esac + +if [ -z "${MVNW_USERNAME-}" ] && command -v wget >/dev/null; then + verbose "Found wget ... using wget" + wget ${__MVNW_QUIET_WGET:+"$__MVNW_QUIET_WGET"} "$distributionUrl" -O "$TMP_DOWNLOAD_DIR/$distributionUrlName" || die "wget: Failed to fetch $distributionUrl" +elif [ -z "${MVNW_USERNAME-}" ] && command -v curl >/dev/null; then + verbose "Found curl ... using curl" + curl ${__MVNW_QUIET_CURL:+"$__MVNW_QUIET_CURL"} -f -L -o "$TMP_DOWNLOAD_DIR/$distributionUrlName" "$distributionUrl" || die "curl: Failed to fetch $distributionUrl" +elif set_java_home; then + verbose "Falling back to use Java to download" + javaSource="$TMP_DOWNLOAD_DIR/Downloader.java" + targetZip="$TMP_DOWNLOAD_DIR/$distributionUrlName" + cat >"$javaSource" <<-END + public class Downloader extends java.net.Authenticator + { + protected java.net.PasswordAuthentication getPasswordAuthentication() + { + return new java.net.PasswordAuthentication( System.getenv( "MVNW_USERNAME" ), System.getenv( "MVNW_PASSWORD" ).toCharArray() ); + } + public static void main( String[] args ) throws Exception + { + setDefault( new Downloader() ); + java.nio.file.Files.copy( java.net.URI.create( args[0] ).toURL().openStream(), java.nio.file.Paths.get( args[1] ).toAbsolutePath().normalize() ); + } + } + END + # For Cygwin/MinGW, switch paths to Windows format before running javac and java + verbose " - Compiling Downloader.java ..." + "$(native_path "$JAVACCMD")" "$(native_path "$javaSource")" || die "Failed to compile Downloader.java" + verbose " - Running Downloader.java ..." + "$(native_path "$JAVACMD")" -cp "$(native_path "$TMP_DOWNLOAD_DIR")" Downloader "$distributionUrl" "$(native_path "$targetZip")" +fi + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +if [ -n "${distributionSha256Sum-}" ]; then + distributionSha256Result=false + if [ "$MVN_CMD" = mvnd.sh ]; then + echo "Checksum validation is not supported for maven-mvnd." >&2 + echo "Please disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + elif command -v sha256sum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | sha256sum -c - >/dev/null 2>&1; then + distributionSha256Result=true + fi + elif command -v shasum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | shasum -a 256 -c >/dev/null 2>&1; then + distributionSha256Result=true + fi + else + echo "Checksum validation was requested but neither 'sha256sum' or 'shasum' are available." >&2 + echo "Please install either command, or disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + fi + if [ $distributionSha256Result = false ]; then + echo "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised." >&2 + echo "If you updated your Maven version, you need to update the specified distributionSha256Sum property." >&2 + exit 1 + fi +fi + +# unzip and move +if command -v unzip >/dev/null; then + unzip ${__MVNW_QUIET_UNZIP:+"$__MVNW_QUIET_UNZIP"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -d "$TMP_DOWNLOAD_DIR" || die "failed to unzip" +else + tar xzf${__MVNW_QUIET_TAR:+"$__MVNW_QUIET_TAR"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -C "$TMP_DOWNLOAD_DIR" || die "failed to untar" +fi + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +actualDistributionDir="" + +# First try the expected directory name (for regular distributions) +if [ -d "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain" ]; then + if [ -f "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain/bin/$MVN_CMD" ]; then + actualDistributionDir="$distributionUrlNameMain" + fi +fi + +# If not found, search for any directory with the Maven executable (for snapshots) +if [ -z "$actualDistributionDir" ]; then + # enable globbing to iterate over items + set +f + for dir in "$TMP_DOWNLOAD_DIR"/*; do + if [ -d "$dir" ]; then + if [ -f "$dir/bin/$MVN_CMD" ]; then + actualDistributionDir="$(basename "$dir")" + break + fi + fi + done + set -f +fi + +if [ -z "$actualDistributionDir" ]; then + verbose "Contents of $TMP_DOWNLOAD_DIR:" + verbose "$(ls -la "$TMP_DOWNLOAD_DIR")" + die "Could not find Maven distribution directory in extracted archive" +fi + +verbose "Found extracted Maven distribution directory: $actualDistributionDir" +printf %s\\n "$distributionUrl" >"$TMP_DOWNLOAD_DIR/$actualDistributionDir/mvnw.url" +mv -- "$TMP_DOWNLOAD_DIR/$actualDistributionDir" "$MAVEN_HOME" || [ -d "$MAVEN_HOME" ] || die "fail to move MAVEN_HOME" + +clean || : +exec_maven "$@" diff --git a/yape-code-challenge/mvnw.cmd b/yape-code-challenge/mvnw.cmd new file mode 100644 index 0000000000..92450f9327 --- /dev/null +++ b/yape-code-challenge/mvnw.cmd @@ -0,0 +1,189 @@ +<# : batch portion +@REM ---------------------------------------------------------------------------- +@REM Licensed to the Apache Software Foundation (ASF) under one +@REM or more contributor license agreements. See the NOTICE file +@REM distributed with this work for additional information +@REM regarding copyright ownership. The ASF licenses this file +@REM to you under the Apache License, Version 2.0 (the +@REM "License"); you may not use this file except in compliance +@REM with the License. You may obtain a copy of the License at +@REM +@REM http://www.apache.org/licenses/LICENSE-2.0 +@REM +@REM Unless required by applicable law or agreed to in writing, +@REM software distributed under the License is distributed on an +@REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +@REM KIND, either express or implied. See the License for the +@REM specific language governing permissions and limitations +@REM under the License. +@REM ---------------------------------------------------------------------------- + +@REM ---------------------------------------------------------------------------- +@REM Apache Maven Wrapper startup batch script, version 3.3.4 +@REM +@REM Optional ENV vars +@REM MVNW_REPOURL - repo url base for downloading maven distribution +@REM MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +@REM MVNW_VERBOSE - true: enable verbose log; others: silence the output +@REM ---------------------------------------------------------------------------- + +@IF "%__MVNW_ARG0_NAME__%"=="" (SET __MVNW_ARG0_NAME__=%~nx0) +@SET __MVNW_CMD__= +@SET __MVNW_ERROR__= +@SET __MVNW_PSMODULEP_SAVE=%PSModulePath% +@SET PSModulePath= +@FOR /F "usebackq tokens=1* delims==" %%A IN (`powershell -noprofile "& {$scriptDir='%~dp0'; $script='%__MVNW_ARG0_NAME__%'; icm -ScriptBlock ([Scriptblock]::Create((Get-Content -Raw '%~f0'))) -NoNewScope}"`) DO @( + IF "%%A"=="MVN_CMD" (set __MVNW_CMD__=%%B) ELSE IF "%%B"=="" (echo %%A) ELSE (echo %%A=%%B) +) +@SET PSModulePath=%__MVNW_PSMODULEP_SAVE% +@SET __MVNW_PSMODULEP_SAVE= +@SET __MVNW_ARG0_NAME__= +@SET MVNW_USERNAME= +@SET MVNW_PASSWORD= +@IF NOT "%__MVNW_CMD__%"=="" ("%__MVNW_CMD__%" %*) +@echo Cannot start maven from wrapper >&2 && exit /b 1 +@GOTO :EOF +: end batch / begin powershell #> + +$ErrorActionPreference = "Stop" +if ($env:MVNW_VERBOSE -eq "true") { + $VerbosePreference = "Continue" +} + +# calculate distributionUrl, requires .mvn/wrapper/maven-wrapper.properties +$distributionUrl = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionUrl +if (!$distributionUrl) { + Write-Error "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" +} + +switch -wildcard -casesensitive ( $($distributionUrl -replace '^.*/','') ) { + "maven-mvnd-*" { + $USE_MVND = $true + $distributionUrl = $distributionUrl -replace '-bin\.[^.]*$',"-windows-amd64.zip" + $MVN_CMD = "mvnd.cmd" + break + } + default { + $USE_MVND = $false + $MVN_CMD = $script -replace '^mvnw','mvn' + break + } +} + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +if ($env:MVNW_REPOURL) { + $MVNW_REPO_PATTERN = if ($USE_MVND -eq $False) { "/org/apache/maven/" } else { "/maven/mvnd/" } + $distributionUrl = "$env:MVNW_REPOURL$MVNW_REPO_PATTERN$($distributionUrl -replace "^.*$MVNW_REPO_PATTERN",'')" +} +$distributionUrlName = $distributionUrl -replace '^.*/','' +$distributionUrlNameMain = $distributionUrlName -replace '\.[^.]*$','' -replace '-bin$','' + +$MAVEN_M2_PATH = "$HOME/.m2" +if ($env:MAVEN_USER_HOME) { + $MAVEN_M2_PATH = "$env:MAVEN_USER_HOME" +} + +if (-not (Test-Path -Path $MAVEN_M2_PATH)) { + New-Item -Path $MAVEN_M2_PATH -ItemType Directory | Out-Null +} + +$MAVEN_WRAPPER_DISTS = $null +if ((Get-Item $MAVEN_M2_PATH).Target[0] -eq $null) { + $MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists" +} else { + $MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] + "/wrapper/dists" +} + +$MAVEN_HOME_PARENT = "$MAVEN_WRAPPER_DISTS/$distributionUrlNameMain" +$MAVEN_HOME_NAME = ([System.Security.Cryptography.SHA256]::Create().ComputeHash([byte[]][char[]]$distributionUrl) | ForEach-Object {$_.ToString("x2")}) -join '' +$MAVEN_HOME = "$MAVEN_HOME_PARENT/$MAVEN_HOME_NAME" + +if (Test-Path -Path "$MAVEN_HOME" -PathType Container) { + Write-Verbose "found existing MAVEN_HOME at $MAVEN_HOME" + Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" + exit $? +} + +if (! $distributionUrlNameMain -or ($distributionUrlName -eq $distributionUrlNameMain)) { + Write-Error "distributionUrl is not valid, must end with *-bin.zip, but found $distributionUrl" +} + +# prepare tmp dir +$TMP_DOWNLOAD_DIR_HOLDER = New-TemporaryFile +$TMP_DOWNLOAD_DIR = New-Item -Itemtype Directory -Path "$TMP_DOWNLOAD_DIR_HOLDER.dir" +$TMP_DOWNLOAD_DIR_HOLDER.Delete() | Out-Null +trap { + if ($TMP_DOWNLOAD_DIR.Exists) { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } + } +} + +New-Item -Itemtype Directory -Path "$MAVEN_HOME_PARENT" -Force | Out-Null + +# Download and Install Apache Maven +Write-Verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +Write-Verbose "Downloading from: $distributionUrl" +Write-Verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +$webclient = New-Object System.Net.WebClient +if ($env:MVNW_USERNAME -and $env:MVNW_PASSWORD) { + $webclient.Credentials = New-Object System.Net.NetworkCredential($env:MVNW_USERNAME, $env:MVNW_PASSWORD) +} +[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 +$webclient.DownloadFile($distributionUrl, "$TMP_DOWNLOAD_DIR/$distributionUrlName") | Out-Null + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +$distributionSha256Sum = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionSha256Sum +if ($distributionSha256Sum) { + if ($USE_MVND) { + Write-Error "Checksum validation is not supported for maven-mvnd. `nPlease disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." + } + Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash + if ((Get-FileHash "$TMP_DOWNLOAD_DIR/$distributionUrlName" -Algorithm SHA256).Hash.ToLower() -ne $distributionSha256Sum) { + Write-Error "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised. If you updated your Maven version, you need to update the specified distributionSha256Sum property." + } +} + +# unzip and move +Expand-Archive "$TMP_DOWNLOAD_DIR/$distributionUrlName" -DestinationPath "$TMP_DOWNLOAD_DIR" | Out-Null + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +$actualDistributionDir = "" + +# First try the expected directory name (for regular distributions) +$expectedPath = Join-Path "$TMP_DOWNLOAD_DIR" "$distributionUrlNameMain" +$expectedMvnPath = Join-Path "$expectedPath" "bin/$MVN_CMD" +if ((Test-Path -Path $expectedPath -PathType Container) -and (Test-Path -Path $expectedMvnPath -PathType Leaf)) { + $actualDistributionDir = $distributionUrlNameMain +} + +# If not found, search for any directory with the Maven executable (for snapshots) +if (!$actualDistributionDir) { + Get-ChildItem -Path "$TMP_DOWNLOAD_DIR" -Directory | ForEach-Object { + $testPath = Join-Path $_.FullName "bin/$MVN_CMD" + if (Test-Path -Path $testPath -PathType Leaf) { + $actualDistributionDir = $_.Name + } + } +} + +if (!$actualDistributionDir) { + Write-Error "Could not find Maven distribution directory in extracted archive" +} + +Write-Verbose "Found extracted Maven distribution directory: $actualDistributionDir" +Rename-Item -Path "$TMP_DOWNLOAD_DIR/$actualDistributionDir" -NewName $MAVEN_HOME_NAME | Out-Null +try { + Move-Item -Path "$TMP_DOWNLOAD_DIR/$MAVEN_HOME_NAME" -Destination $MAVEN_HOME_PARENT | Out-Null +} catch { + if (! (Test-Path -Path "$MAVEN_HOME" -PathType Container)) { + Write-Error "fail to move MAVEN_HOME" + } +} finally { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } +} + +Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" diff --git a/yape-code-challenge/pom.xml b/yape-code-challenge/pom.xml new file mode 100644 index 0000000000..d7e01f63d2 --- /dev/null +++ b/yape-code-challenge/pom.xml @@ -0,0 +1,119 @@ + + + 4.0.0 + + org.springframework.boot + spring-boot-starter-parent + 3.5.10 + + + com.yaperos.codechallenge + code-challenge + 0.0.1-SNAPSHOT + code-challenge + Yape Code Challenge - Transaction and Anti-Fraud Services + + 17 + + + + org.springframework.boot + spring-boot-starter-data-jpa + + + org.springframework.boot + spring-boot-starter-validation + + + org.springframework.boot + spring-boot-starter-actuator + + + org.springdoc + springdoc-openapi-starter-webmvc-ui + 2.8.6 + + + org.springframework.boot + spring-boot-starter-web + + + org.springframework.kafka + spring-kafka + + + org.springframework.boot + spring-boot-starter-data-redis + + + org.springframework.boot + spring-boot-starter-cache + + + org.postgresql + postgresql + runtime + + + org.projectlombok + lombok + true + + + net.logstash.logback + logstash-logback-encoder + 8.0 + + + org.springframework.boot + spring-boot-starter-test + test + + + org.springframework.kafka + spring-kafka-test + test + + + com.h2database + h2 + test + + + org.awaitility + awaitility + test + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + + + + org.projectlombok + lombok + + + + + + org.springframework.boot + spring-boot-maven-plugin + + + + org.projectlombok + lombok + + + + + + + + diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/CodeChallengeApplication.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/CodeChallengeApplication.java new file mode 100644 index 0000000000..fa6c693a46 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/CodeChallengeApplication.java @@ -0,0 +1,13 @@ +package com.yaperos.codechallenge; + +import org.springframework.boot.SpringApplication; +import org.springframework.boot.autoconfigure.SpringBootApplication; + +@SpringBootApplication +public class CodeChallengeApplication { + + public static void main(String[] args) { + SpringApplication.run(CodeChallengeApplication.class, args); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudService.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudService.java new file mode 100644 index 0000000000..662140559c --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudService.java @@ -0,0 +1,28 @@ +package com.yaperos.codechallenge.antifraud.application.service; + +import com.yaperos.codechallenge.antifraud.domain.model.FraudCheckResult; +import com.yaperos.codechallenge.antifraud.domain.port.input.ValidateTransactionUseCase; +import com.yaperos.codechallenge.antifraud.domain.port.output.FraudResultPublisherPort; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.springframework.stereotype.Service; + +import java.math.BigDecimal; +import java.util.UUID; + +@Slf4j +@Service +@RequiredArgsConstructor +public class AntiFraudService implements ValidateTransactionUseCase { + + private final FraudResultPublisherPort fraudResultPublisher; + + @Override + public void validate(UUID transactionExternalId, BigDecimal value) { + log.info("Validating transaction: id={}, value={}", transactionExternalId, value); + FraudCheckResult result = FraudCheckResult.evaluate(transactionExternalId, value); + log.info("Fraud check result: id={}, status={}", transactionExternalId, result.getStatus()); + fraudResultPublisher.publishResult(result); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/model/FraudCheckResult.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/model/FraudCheckResult.java new file mode 100644 index 0000000000..a6212063f5 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/model/FraudCheckResult.java @@ -0,0 +1,29 @@ +package com.yaperos.codechallenge.antifraud.domain.model; + +import com.yaperos.codechallenge.shared.event.TransactionStatusType; +import lombok.Getter; + +import java.math.BigDecimal; +import java.util.UUID; + +@Getter +public class FraudCheckResult { + + private static final BigDecimal MAX_ALLOWED_VALUE = new BigDecimal("1000"); + + private final UUID transactionExternalId; + private final TransactionStatusType status; + + private FraudCheckResult(UUID transactionExternalId, TransactionStatusType status) { + this.transactionExternalId = transactionExternalId; + this.status = status; + } + + public static FraudCheckResult evaluate(UUID transactionExternalId, BigDecimal value) { + if (value.compareTo(MAX_ALLOWED_VALUE) > 0) { + return new FraudCheckResult(transactionExternalId, TransactionStatusType.REJECTED); + } + return new FraudCheckResult(transactionExternalId, TransactionStatusType.APPROVED); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/input/ValidateTransactionUseCase.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/input/ValidateTransactionUseCase.java new file mode 100644 index 0000000000..a271cbb9e7 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/input/ValidateTransactionUseCase.java @@ -0,0 +1,10 @@ +package com.yaperos.codechallenge.antifraud.domain.port.input; + +import java.math.BigDecimal; +import java.util.UUID; + +public interface ValidateTransactionUseCase { + + void validate(UUID transactionExternalId, BigDecimal value); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/output/FraudResultPublisherPort.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/output/FraudResultPublisherPort.java new file mode 100644 index 0000000000..8e7a17d480 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/domain/port/output/FraudResultPublisherPort.java @@ -0,0 +1,9 @@ +package com.yaperos.codechallenge.antifraud.domain.port.output; + +import com.yaperos.codechallenge.antifraud.domain.model.FraudCheckResult; + +public interface FraudResultPublisherPort { + + void publishResult(FraudCheckResult result); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/input/kafka/TransactionCreatedKafkaConsumer.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/input/kafka/TransactionCreatedKafkaConsumer.java new file mode 100644 index 0000000000..839115c61c --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/input/kafka/TransactionCreatedKafkaConsumer.java @@ -0,0 +1,28 @@ +package com.yaperos.codechallenge.antifraud.infrastructure.adapter.input.kafka; + +import com.yaperos.codechallenge.antifraud.domain.port.input.ValidateTransactionUseCase; +import com.yaperos.codechallenge.shared.config.KafkaTopicConfig; +import com.yaperos.codechallenge.shared.event.TransactionCreatedEvent; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.springframework.kafka.annotation.KafkaListener; +import org.springframework.stereotype.Component; + +@Slf4j +@Component +@RequiredArgsConstructor +public class TransactionCreatedKafkaConsumer { + + private final ValidateTransactionUseCase validateTransactionUseCase; + + @KafkaListener(topics = KafkaTopicConfig.TRANSACTION_CREATED_TOPIC, + groupId = "anti-fraud-group", + concurrency = "3", + properties = "spring.json.value.default.type=com.yaperos.codechallenge.shared.event.TransactionCreatedEvent") + public void consume(TransactionCreatedEvent event) { + log.info("Received transaction-created event: transactionId={}, value={}", + event.getTransactionExternalId(), event.getValue()); + validateTransactionUseCase.validate(event.getTransactionExternalId(), event.getValue()); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/output/kafka/FraudResultKafkaPublisher.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/output/kafka/FraudResultKafkaPublisher.java new file mode 100644 index 0000000000..df177f4f39 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/antifraud/infrastructure/adapter/output/kafka/FraudResultKafkaPublisher.java @@ -0,0 +1,32 @@ +package com.yaperos.codechallenge.antifraud.infrastructure.adapter.output.kafka; + +import com.yaperos.codechallenge.antifraud.domain.model.FraudCheckResult; +import com.yaperos.codechallenge.antifraud.domain.port.output.FraudResultPublisherPort; +import com.yaperos.codechallenge.shared.config.KafkaTopicConfig; +import com.yaperos.codechallenge.shared.event.TransactionStatusEvent; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.springframework.kafka.core.KafkaTemplate; +import org.springframework.stereotype.Component; + +@Slf4j +@Component +@RequiredArgsConstructor +public class FraudResultKafkaPublisher implements FraudResultPublisherPort { + + private final KafkaTemplate kafkaTemplate; + + @Override + public void publishResult(FraudCheckResult result) { + var event = new TransactionStatusEvent( + result.getTransactionExternalId(), + result.getStatus() + ); + log.info("Publishing transaction-status event: transactionId={}, status={}", + result.getTransactionExternalId(), result.getStatus()); + kafkaTemplate.send(KafkaTopicConfig.TRANSACTION_STATUS_TOPIC, + result.getTransactionExternalId().toString(), + event); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/CacheConfig.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/CacheConfig.java new file mode 100644 index 0000000000..967aa0ea29 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/CacheConfig.java @@ -0,0 +1,36 @@ +package com.yaperos.codechallenge.shared.config; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.jsontype.BasicPolymorphicTypeValidator; +import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule; +import org.springframework.cache.annotation.EnableCaching; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.data.redis.cache.RedisCacheConfiguration; +import org.springframework.data.redis.serializer.GenericJackson2JsonRedisSerializer; +import org.springframework.data.redis.serializer.RedisSerializationContext; + +import java.time.Duration; + +@Configuration +@EnableCaching +public class CacheConfig { + + @Bean + public RedisCacheConfiguration cacheConfiguration() { + ObjectMapper objectMapper = new ObjectMapper(); + objectMapper.registerModule(new JavaTimeModule()); + objectMapper.activateDefaultTyping( + BasicPolymorphicTypeValidator.builder() + .allowIfBaseType(Object.class) + .build(), + ObjectMapper.DefaultTyping.NON_FINAL); + + return RedisCacheConfiguration.defaultCacheConfig() + .entryTtl(Duration.ofMinutes(1)) + .serializeValuesWith( + RedisSerializationContext.SerializationPair + .fromSerializer(new GenericJackson2JsonRedisSerializer(objectMapper))); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaErrorConfig.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaErrorConfig.java new file mode 100644 index 0000000000..88260a6fd9 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaErrorConfig.java @@ -0,0 +1,37 @@ +package com.yaperos.codechallenge.shared.config; + +import lombok.extern.slf4j.Slf4j; +import org.apache.kafka.clients.consumer.ConsumerRecord; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.kafka.core.KafkaOperations; +import org.springframework.kafka.listener.CommonErrorHandler; +import org.springframework.kafka.listener.DeadLetterPublishingRecoverer; +import org.springframework.kafka.listener.DefaultErrorHandler; +import org.springframework.kafka.listener.RetryListener; +import org.springframework.util.backoff.FixedBackOff; + +@Slf4j +@Configuration +public class KafkaErrorConfig { + + @Bean + public CommonErrorHandler kafkaErrorHandler(KafkaOperations kafkaTemplate) { + DeadLetterPublishingRecoverer recoverer = new DeadLetterPublishingRecoverer(kafkaTemplate); + + DefaultErrorHandler errorHandler = new DefaultErrorHandler(recoverer, new FixedBackOff(1000L, 2)); + + errorHandler.addNotRetryableExceptions(IllegalStateException.class); + + errorHandler.setRetryListeners(new RetryListener() { + @Override + public void failedDelivery(ConsumerRecord record, Exception ex, int deliveryAttempt) { + log.warn("Kafka retry attempt {} for topic={} key={}: {}", + deliveryAttempt, record.topic(), record.key(), ex.getMessage()); + } + }); + + return errorHandler; + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaTopicConfig.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaTopicConfig.java new file mode 100644 index 0000000000..9734bd52d0 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/config/KafkaTopicConfig.java @@ -0,0 +1,46 @@ +package com.yaperos.codechallenge.shared.config; + +import org.apache.kafka.clients.admin.NewTopic; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.kafka.config.TopicBuilder; + +@Configuration +public class KafkaTopicConfig { + + public static final String TRANSACTION_CREATED_TOPIC = "transaction-created"; + public static final String TRANSACTION_STATUS_TOPIC = "transaction-status"; + + @Bean + public NewTopic transactionCreatedTopic() { + return TopicBuilder.name(TRANSACTION_CREATED_TOPIC) + .partitions(6) + .replicas(1) + .build(); + } + + @Bean + public NewTopic transactionStatusTopic() { + return TopicBuilder.name(TRANSACTION_STATUS_TOPIC) + .partitions(6) + .replicas(1) + .build(); + } + + @Bean + public NewTopic transactionCreatedDlt() { + return TopicBuilder.name(TRANSACTION_CREATED_TOPIC + ".DLT") + .partitions(6) + .replicas(1) + .build(); + } + + @Bean + public NewTopic transactionStatusDlt() { + return TopicBuilder.name(TRANSACTION_STATUS_TOPIC + ".DLT") + .partitions(6) + .replicas(1) + .build(); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionCreatedEvent.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionCreatedEvent.java new file mode 100644 index 0000000000..68fa189e23 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionCreatedEvent.java @@ -0,0 +1,20 @@ +package com.yaperos.codechallenge.shared.event; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.math.BigDecimal; +import java.util.UUID; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionCreatedEvent { + + private UUID transactionExternalId; + private BigDecimal value; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusEvent.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusEvent.java new file mode 100644 index 0000000000..592856fc9c --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusEvent.java @@ -0,0 +1,19 @@ +package com.yaperos.codechallenge.shared.event; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.util.UUID; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionStatusEvent { + + private UUID transactionExternalId; + private TransactionStatusType status; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusType.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusType.java new file mode 100644 index 0000000000..48d37d3a3d --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/event/TransactionStatusType.java @@ -0,0 +1,6 @@ +package com.yaperos.codechallenge.shared.event; + +public enum TransactionStatusType { + APPROVED, + REJECTED +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ErrorResponse.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ErrorResponse.java new file mode 100644 index 0000000000..4fff2b8724 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ErrorResponse.java @@ -0,0 +1,21 @@ +package com.yaperos.codechallenge.shared.exception; + +import lombok.AllArgsConstructor; +import lombok.Getter; + +import java.time.LocalDateTime; + +@Getter +@AllArgsConstructor +public class ErrorResponse { + + private final int status; + private final String error; + private final String message; + private final LocalDateTime timestamp; + + public static ErrorResponse of(int status, String error, String message) { + return new ErrorResponse(status, error, message, LocalDateTime.now()); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandler.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandler.java new file mode 100644 index 0000000000..a21314d030 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandler.java @@ -0,0 +1,90 @@ +package com.yaperos.codechallenge.shared.exception; + +import com.yaperos.codechallenge.transaction.domain.exception.InvalidTransferTypeException; +import com.yaperos.codechallenge.transaction.domain.exception.TransactionNotFoundException; +import lombok.extern.slf4j.Slf4j; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.http.converter.HttpMessageNotReadableException; +import org.springframework.web.bind.MethodArgumentNotValidException; +import org.springframework.web.bind.annotation.ExceptionHandler; +import org.springframework.web.bind.annotation.RestControllerAdvice; +import org.springframework.web.method.annotation.MethodArgumentTypeMismatchException; + +import java.util.List; + +@Slf4j +@RestControllerAdvice +public class GlobalExceptionHandler { + + @ExceptionHandler(TransactionNotFoundException.class) + public ResponseEntity handleTransactionNotFound(TransactionNotFoundException ex) { + log.warn("Transaction not found: {}", ex.getMessage()); + ErrorResponse body = ErrorResponse.of( + HttpStatus.NOT_FOUND.value(), + "Not Found", + ex.getMessage() + ); + return ResponseEntity.status(HttpStatus.NOT_FOUND).body(body); + } + + @ExceptionHandler(InvalidTransferTypeException.class) + public ResponseEntity handleInvalidTransferType(InvalidTransferTypeException ex) { + log.warn("Invalid transfer type: {}", ex.getMessage()); + ErrorResponse body = ErrorResponse.of( + HttpStatus.BAD_REQUEST.value(), + "Bad Request", + ex.getMessage() + ); + return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(body); + } + + @ExceptionHandler(HttpMessageNotReadableException.class) + public ResponseEntity handleMalformedJson(HttpMessageNotReadableException ex) { + log.warn("Malformed JSON request: {}", ex.getMessage()); + ErrorResponse body = ErrorResponse.of( + HttpStatus.BAD_REQUEST.value(), + "Bad Request", + "Malformed JSON request" + ); + return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(body); + } + + @ExceptionHandler(MethodArgumentTypeMismatchException.class) + public ResponseEntity handleTypeMismatch(MethodArgumentTypeMismatchException ex) { + log.warn("Type mismatch: {}", ex.getMessage()); + String message = String.format("Invalid value '%s' for parameter '%s'", ex.getValue(), ex.getName()); + ErrorResponse body = ErrorResponse.of( + HttpStatus.BAD_REQUEST.value(), + "Bad Request", + message + ); + return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(body); + } + + @ExceptionHandler(MethodArgumentNotValidException.class) + public ResponseEntity handleValidation(MethodArgumentNotValidException ex) { + log.warn("Validation failed: {}", ex.getMessage()); + List fieldErrors = ex.getBindingResult().getFieldErrors().stream() + .map(fe -> new ValidationErrorResponse.FieldError(fe.getField(), fe.getDefaultMessage())) + .toList(); + ValidationErrorResponse body = new ValidationErrorResponse( + HttpStatus.BAD_REQUEST.value(), + "Validation Failed", + fieldErrors + ); + return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(body); + } + + @ExceptionHandler(Exception.class) + public ResponseEntity handleGeneric(Exception ex) { + log.error("Unexpected error", ex); + ErrorResponse body = ErrorResponse.of( + HttpStatus.INTERNAL_SERVER_ERROR.value(), + "Internal Server Error", + "An unexpected error occurred" + ); + return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(body); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ValidationErrorResponse.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ValidationErrorResponse.java new file mode 100644 index 0000000000..73987c7e6f --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/shared/exception/ValidationErrorResponse.java @@ -0,0 +1,20 @@ +package com.yaperos.codechallenge.shared.exception; + +import java.time.LocalDateTime; +import java.util.List; + +public record ValidationErrorResponse( + int status, + String error, + List fieldErrors, + LocalDateTime timestamp +) { + + public ValidationErrorResponse(int status, String error, List fieldErrors) { + this(status, error, fieldErrors, LocalDateTime.now()); + } + + public record FieldError(String field, String message) { + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/application/service/TransactionService.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/application/service/TransactionService.java new file mode 100644 index 0000000000..4cb2c40d28 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/application/service/TransactionService.java @@ -0,0 +1,63 @@ +package com.yaperos.codechallenge.transaction.application.service; + +import com.yaperos.codechallenge.shared.event.TransactionStatusType; +import com.yaperos.codechallenge.transaction.domain.exception.TransactionNotFoundException; +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.model.TransferType; +import com.yaperos.codechallenge.transaction.domain.port.input.CreateTransactionUseCase; +import com.yaperos.codechallenge.transaction.domain.port.input.GetTransactionUseCase; +import com.yaperos.codechallenge.transaction.domain.port.input.UpdateTransactionStatusUseCase; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionEventPublisherPort; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionRepositoryPort; +import lombok.RequiredArgsConstructor; +import org.springframework.cache.annotation.CacheEvict; +import org.springframework.cache.annotation.Cacheable; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; + +import java.math.BigDecimal; +import java.util.UUID; + +@Service +@RequiredArgsConstructor +public class TransactionService implements CreateTransactionUseCase, GetTransactionUseCase, UpdateTransactionStatusUseCase { + + private final TransactionRepositoryPort transactionRepository; + private final TransactionEventPublisherPort eventPublisher; + + @Override + @Transactional + public Transaction create(UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + TransferType transferType, + BigDecimal value) { + Transaction transaction = Transaction.create(accountExternalIdDebit, accountExternalIdCredit, transferType, value); + Transaction saved = transactionRepository.save(transaction); + eventPublisher.publishTransactionCreated(saved); + return saved; + } + + @Override + @Transactional(readOnly = true) + @Cacheable(value = "transactions", key = "#transactionExternalId") + public Transaction getById(UUID transactionExternalId) { + return transactionRepository.findById(transactionExternalId) + .orElseThrow(() -> new TransactionNotFoundException(transactionExternalId)); + } + + @Override + @Transactional + @CacheEvict(value = "transactions", key = "#transactionExternalId") + public void updateStatus(UUID transactionExternalId, TransactionStatusType status) { + Transaction transaction = transactionRepository.findById(transactionExternalId) + .orElseThrow(() -> new TransactionNotFoundException(transactionExternalId)); + + switch (status) { + case APPROVED -> transaction.approve(); + case REJECTED -> transaction.reject(); + } + + transactionRepository.save(transaction); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/InvalidTransferTypeException.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/InvalidTransferTypeException.java new file mode 100644 index 0000000000..f6553e6df8 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/InvalidTransferTypeException.java @@ -0,0 +1,9 @@ +package com.yaperos.codechallenge.transaction.domain.exception; + +public class InvalidTransferTypeException extends RuntimeException { + + public InvalidTransferTypeException(int id) { + super("Unknown transfer type id: " + id); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/TransactionNotFoundException.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/TransactionNotFoundException.java new file mode 100644 index 0000000000..b33cf9b465 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/exception/TransactionNotFoundException.java @@ -0,0 +1,11 @@ +package com.yaperos.codechallenge.transaction.domain.exception; + +import java.util.UUID; + +public class TransactionNotFoundException extends RuntimeException { + + public TransactionNotFoundException(UUID transactionExternalId) { + super("Transaction not found: " + transactionExternalId); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/Transaction.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/Transaction.java new file mode 100644 index 0000000000..81c7e165f7 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/Transaction.java @@ -0,0 +1,55 @@ +package com.yaperos.codechallenge.transaction.domain.model; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; + +import java.math.BigDecimal; +import java.time.LocalDateTime; +import java.util.UUID; + +@Getter +@NoArgsConstructor +@AllArgsConstructor +public class Transaction implements java.io.Serializable { + + private UUID transactionExternalId; + private UUID accountExternalIdDebit; + private UUID accountExternalIdCredit; + private TransferType transferType; + private BigDecimal value; + private TransactionStatus status; + private LocalDateTime createdAt; + + public static Transaction create(UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + TransferType transferType, + BigDecimal value) { + return new Transaction( + UUID.randomUUID(), + accountExternalIdDebit, + accountExternalIdCredit, + transferType, + value, + TransactionStatus.PENDING, + LocalDateTime.now() + ); + } + + public void approve() { + if (this.status == TransactionStatus.APPROVED) return; + if (this.status != TransactionStatus.PENDING) { + throw new IllegalStateException("Transaction can only be approved from PENDING status"); + } + this.status = TransactionStatus.APPROVED; + } + + public void reject() { + if (this.status == TransactionStatus.REJECTED) return; + if (this.status != TransactionStatus.PENDING) { + throw new IllegalStateException("Transaction can only be rejected from PENDING status"); + } + this.status = TransactionStatus.REJECTED; + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransactionStatus.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransactionStatus.java new file mode 100644 index 0000000000..b1ef456c61 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransactionStatus.java @@ -0,0 +1,7 @@ +package com.yaperos.codechallenge.transaction.domain.model; + +public enum TransactionStatus { + PENDING, + APPROVED, + REJECTED +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransferType.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransferType.java new file mode 100644 index 0000000000..ece91b265c --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/model/TransferType.java @@ -0,0 +1,28 @@ +package com.yaperos.codechallenge.transaction.domain.model; + +import com.yaperos.codechallenge.transaction.domain.exception.InvalidTransferTypeException; +import lombok.Getter; + +@Getter +public enum TransferType { + + EXTERNAL(1, "External"); + + private final int id; + private final String name; + + TransferType(int id, String name) { + this.id = id; + this.name = name; + } + + public static TransferType fromId(int id) { + for (TransferType type : values()) { + if (type.id == id) { + return type; + } + } + throw new InvalidTransferTypeException(id); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/CreateTransactionUseCase.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/CreateTransactionUseCase.java new file mode 100644 index 0000000000..f13b62c7cf --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/CreateTransactionUseCase.java @@ -0,0 +1,16 @@ +package com.yaperos.codechallenge.transaction.domain.port.input; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.model.TransferType; + +import java.math.BigDecimal; +import java.util.UUID; + +public interface CreateTransactionUseCase { + + Transaction create(UUID accountExternalIdDebit, + UUID accountExternalIdCredit, + TransferType transferType, + BigDecimal value); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/GetTransactionUseCase.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/GetTransactionUseCase.java new file mode 100644 index 0000000000..588e0c7ca6 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/GetTransactionUseCase.java @@ -0,0 +1,11 @@ +package com.yaperos.codechallenge.transaction.domain.port.input; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; + +import java.util.UUID; + +public interface GetTransactionUseCase { + + Transaction getById(UUID transactionExternalId); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/UpdateTransactionStatusUseCase.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/UpdateTransactionStatusUseCase.java new file mode 100644 index 0000000000..a4c77f1642 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/input/UpdateTransactionStatusUseCase.java @@ -0,0 +1,11 @@ +package com.yaperos.codechallenge.transaction.domain.port.input; + +import com.yaperos.codechallenge.shared.event.TransactionStatusType; + +import java.util.UUID; + +public interface UpdateTransactionStatusUseCase { + + void updateStatus(UUID transactionExternalId, TransactionStatusType status); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionEventPublisherPort.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionEventPublisherPort.java new file mode 100644 index 0000000000..a8dae3b4fa --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionEventPublisherPort.java @@ -0,0 +1,9 @@ +package com.yaperos.codechallenge.transaction.domain.port.output; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; + +public interface TransactionEventPublisherPort { + + void publishTransactionCreated(Transaction transaction); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionRepositoryPort.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionRepositoryPort.java new file mode 100644 index 0000000000..f104f26af6 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/domain/port/output/TransactionRepositoryPort.java @@ -0,0 +1,14 @@ +package com.yaperos.codechallenge.transaction.domain.port.output; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; + +import java.util.Optional; +import java.util.UUID; + +public interface TransactionRepositoryPort { + + Transaction save(Transaction transaction); + + Optional findById(UUID transactionExternalId); + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/kafka/TransactionStatusKafkaConsumer.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/kafka/TransactionStatusKafkaConsumer.java new file mode 100644 index 0000000000..e11f14a355 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/kafka/TransactionStatusKafkaConsumer.java @@ -0,0 +1,34 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.kafka; + +import com.yaperos.codechallenge.shared.config.KafkaTopicConfig; +import com.yaperos.codechallenge.shared.event.TransactionStatusEvent; +import com.yaperos.codechallenge.transaction.domain.port.input.UpdateTransactionStatusUseCase; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.springframework.kafka.annotation.KafkaListener; +import org.springframework.stereotype.Component; + +@Slf4j +@Component +@RequiredArgsConstructor +public class TransactionStatusKafkaConsumer { + + private final UpdateTransactionStatusUseCase updateTransactionStatusUseCase; + + @KafkaListener(topics = KafkaTopicConfig.TRANSACTION_STATUS_TOPIC, + groupId = "transaction-status-group", + concurrency = "3", + properties = "spring.json.value.default.type=com.yaperos.codechallenge.shared.event.TransactionStatusEvent") + public void consume(TransactionStatusEvent event) { + log.info("Received transaction-status event: transactionId={}, status={}", + event.getTransactionExternalId(), event.getStatus()); + try { + updateTransactionStatusUseCase.updateStatus(event.getTransactionExternalId(), event.getStatus()); + } catch (Exception ex) { + log.error("Failed to process transaction-status event: transactionId={}, status={}", + event.getTransactionExternalId(), event.getStatus(), ex); + throw ex; + } + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionController.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionController.java new file mode 100644 index 0000000000..01f8f34829 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionController.java @@ -0,0 +1,44 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.model.TransferType; +import com.yaperos.codechallenge.transaction.domain.port.input.CreateTransactionUseCase; +import com.yaperos.codechallenge.transaction.domain.port.input.GetTransactionUseCase; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.CreateTransactionRequest; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.TransactionResponse; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.mapper.TransactionWebMapper; +import jakarta.validation.Valid; +import lombok.RequiredArgsConstructor; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.*; + +import java.util.UUID; + +@RestController +@RequestMapping("/transactions") +@RequiredArgsConstructor +public class TransactionController { + + private final CreateTransactionUseCase createTransactionUseCase; + private final GetTransactionUseCase getTransactionUseCase; + private final TransactionWebMapper mapper; + + @PostMapping + public ResponseEntity create(@Valid @RequestBody CreateTransactionRequest request) { + Transaction transaction = createTransactionUseCase.create( + request.getAccountExternalIdDebit(), + request.getAccountExternalIdCredit(), + TransferType.fromId(request.getTranferTypeId()), + request.getValue() + ); + return ResponseEntity.status(HttpStatus.CREATED).body(mapper.toResponse(transaction)); + } + + @GetMapping("/{id}") + public ResponseEntity getById(@PathVariable UUID id) { + Transaction transaction = getTransactionUseCase.getById(id); + return ResponseEntity.ok(mapper.toResponse(transaction)); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/CreateTransactionRequest.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/CreateTransactionRequest.java new file mode 100644 index 0000000000..d080aa43ce --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/CreateTransactionRequest.java @@ -0,0 +1,33 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto; + +import jakarta.validation.constraints.NotNull; +import jakarta.validation.constraints.Positive; +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.math.BigDecimal; +import java.util.UUID; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class CreateTransactionRequest { + + @NotNull + private UUID accountExternalIdDebit; + + @NotNull + private UUID accountExternalIdCredit; + + @NotNull + @Positive + private Integer tranferTypeId; + + @NotNull + @Positive + private BigDecimal value; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionResponse.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionResponse.java new file mode 100644 index 0000000000..310cf7d8f8 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionResponse.java @@ -0,0 +1,24 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.math.BigDecimal; +import java.time.LocalDateTime; +import java.util.UUID; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionResponse { + + private UUID transactionExternalId; + private TransactionTypeDto transactionType; + private TransactionStatusDto transactionStatus; + private BigDecimal value; + private LocalDateTime createdAt; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionStatusDto.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionStatusDto.java new file mode 100644 index 0000000000..affb6e83f3 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionStatusDto.java @@ -0,0 +1,16 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionStatusDto { + + private String name; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionTypeDto.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionTypeDto.java new file mode 100644 index 0000000000..e68be862b8 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/dto/TransactionTypeDto.java @@ -0,0 +1,16 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionTypeDto { + + private String name; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/mapper/TransactionWebMapper.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/mapper/TransactionWebMapper.java new file mode 100644 index 0000000000..f72ba3a6b6 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/mapper/TransactionWebMapper.java @@ -0,0 +1,22 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.mapper; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.TransactionResponse; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.TransactionStatusDto; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.TransactionTypeDto; +import org.springframework.stereotype.Component; + +@Component +public class TransactionWebMapper { + + public TransactionResponse toResponse(Transaction domain) { + return new TransactionResponse( + domain.getTransactionExternalId(), + new TransactionTypeDto(domain.getTransferType().getName()), + new TransactionStatusDto(domain.getStatus().name().toLowerCase()), + domain.getValue(), + domain.getCreatedAt() + ); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/kafka/TransactionKafkaPublisher.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/kafka/TransactionKafkaPublisher.java new file mode 100644 index 0000000000..818371c179 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/kafka/TransactionKafkaPublisher.java @@ -0,0 +1,31 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.output.kafka; + +import com.yaperos.codechallenge.shared.config.KafkaTopicConfig; +import com.yaperos.codechallenge.shared.event.TransactionCreatedEvent; +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionEventPublisherPort; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.springframework.kafka.core.KafkaTemplate; +import org.springframework.stereotype.Component; + +@Slf4j +@Component +@RequiredArgsConstructor +public class TransactionKafkaPublisher implements TransactionEventPublisherPort { + + private final KafkaTemplate kafkaTemplate; + + @Override + public void publishTransactionCreated(Transaction transaction) { + var event = new TransactionCreatedEvent( + transaction.getTransactionExternalId(), + transaction.getValue() + ); + log.info("Publishing transaction-created event for transaction: {}", transaction.getTransactionExternalId()); + kafkaTemplate.send(KafkaTopicConfig.TRANSACTION_CREATED_TOPIC, + transaction.getTransactionExternalId().toString(), + event); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/adapter/TransactionPersistenceAdapter.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/adapter/TransactionPersistenceAdapter.java new file mode 100644 index 0000000000..fe0d09c0f7 --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/adapter/TransactionPersistenceAdapter.java @@ -0,0 +1,33 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.adapter; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionRepositoryPort; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.mapper.TransactionPersistenceMapper; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.repository.SpringDataTransactionRepository; +import lombok.RequiredArgsConstructor; +import org.springframework.stereotype.Component; + +import java.util.Optional; +import java.util.UUID; + +@Component +@RequiredArgsConstructor +public class TransactionPersistenceAdapter implements TransactionRepositoryPort { + + private final SpringDataTransactionRepository repository; + private final TransactionPersistenceMapper mapper; + + @Override + public Transaction save(Transaction transaction) { + var entity = mapper.toJpaEntity(transaction); + var saved = repository.save(entity); + return mapper.toDomain(saved); + } + + @Override + public Optional findById(UUID transactionExternalId) { + return repository.findById(transactionExternalId) + .map(mapper::toDomain); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/entity/TransactionJpaEntity.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/entity/TransactionJpaEntity.java new file mode 100644 index 0000000000..4a6d47207a --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/entity/TransactionJpaEntity.java @@ -0,0 +1,46 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.entity; + +import com.yaperos.codechallenge.transaction.domain.model.TransactionStatus; +import com.yaperos.codechallenge.transaction.domain.model.TransferType; +import jakarta.persistence.*; +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; + +import java.math.BigDecimal; +import java.time.LocalDateTime; +import java.util.UUID; + +@Entity +@Table(name = "transactions") +@Getter +@Setter +@NoArgsConstructor +@AllArgsConstructor +public class TransactionJpaEntity { + + @Id + private UUID transactionExternalId; + + @Column(nullable = false) + private UUID accountExternalIdDebit; + + @Column(nullable = false) + private UUID accountExternalIdCredit; + + @Enumerated(EnumType.STRING) + @Column(nullable = false) + private TransferType transferType; + + @Column(name = "\"value\"", nullable = false) + private BigDecimal value; + + @Enumerated(EnumType.STRING) + @Column(nullable = false) + private TransactionStatus status; + + @Column(nullable = false) + private LocalDateTime createdAt; + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/mapper/TransactionPersistenceMapper.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/mapper/TransactionPersistenceMapper.java new file mode 100644 index 0000000000..65f5aa284e --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/mapper/TransactionPersistenceMapper.java @@ -0,0 +1,34 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.mapper; + +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.entity.TransactionJpaEntity; +import org.springframework.stereotype.Component; + +@Component +public class TransactionPersistenceMapper { + + public TransactionJpaEntity toJpaEntity(Transaction domain) { + TransactionJpaEntity entity = new TransactionJpaEntity(); + entity.setTransactionExternalId(domain.getTransactionExternalId()); + entity.setAccountExternalIdDebit(domain.getAccountExternalIdDebit()); + entity.setAccountExternalIdCredit(domain.getAccountExternalIdCredit()); + entity.setTransferType(domain.getTransferType()); + entity.setValue(domain.getValue()); + entity.setStatus(domain.getStatus()); + entity.setCreatedAt(domain.getCreatedAt()); + return entity; + } + + public Transaction toDomain(TransactionJpaEntity entity) { + return new Transaction( + entity.getTransactionExternalId(), + entity.getAccountExternalIdDebit(), + entity.getAccountExternalIdCredit(), + entity.getTransferType(), + entity.getValue(), + entity.getStatus(), + entity.getCreatedAt() + ); + } + +} diff --git a/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/repository/SpringDataTransactionRepository.java b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/repository/SpringDataTransactionRepository.java new file mode 100644 index 0000000000..43ceceb76f --- /dev/null +++ b/yape-code-challenge/src/main/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/output/persistence/repository/SpringDataTransactionRepository.java @@ -0,0 +1,9 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.repository; + +import com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.entity.TransactionJpaEntity; +import org.springframework.data.jpa.repository.JpaRepository; + +import java.util.UUID; + +public interface SpringDataTransactionRepository extends JpaRepository { +} diff --git a/yape-code-challenge/src/main/resources/application.yaml b/yape-code-challenge/src/main/resources/application.yaml new file mode 100644 index 0000000000..dcdf75874a --- /dev/null +++ b/yape-code-challenge/src/main/resources/application.yaml @@ -0,0 +1,49 @@ +server: + port: 8080 + servlet: + context-path: /api + +spring: + application: + name: code-challenge + datasource: + url: jdbc:postgresql://${DB_HOST:localhost}:${DB_PORT:5433}/${DB_NAME:postgres} + username: ${DB_USERNAME:postgres} + password: ${DB_PASSWORD:postgres} + jpa: + hibernate: + ddl-auto: update + show-sql: true + properties: + hibernate: + dialect: org.hibernate.dialect.PostgreSQLDialect + kafka: + bootstrap-servers: ${KAFKA_BOOTSTRAP_SERVERS:localhost:9092} + consumer: + group-id: code-challenge-group + auto-offset-reset: earliest + key-deserializer: org.apache.kafka.common.serialization.StringDeserializer + value-deserializer: org.springframework.kafka.support.serializer.JsonDeserializer + properties: + spring.json.trusted.packages: com.yaperos.codechallenge.* + producer: + key-serializer: org.apache.kafka.common.serialization.StringSerializer + value-serializer: org.springframework.kafka.support.serializer.JsonSerializer + + data: + redis: + host: ${REDIS_HOST:localhost} + port: ${REDIS_PORT:6379} + cache: + type: redis + redis: + time-to-live: 60000 + +management: + endpoints: + web: + exposure: + include: health,info + endpoint: + health: + show-details: when-authorized diff --git a/yape-code-challenge/src/main/resources/logback-spring.xml b/yape-code-challenge/src/main/resources/logback-spring.xml new file mode 100644 index 0000000000..916e3be193 --- /dev/null +++ b/yape-code-challenge/src/main/resources/logback-spring.xml @@ -0,0 +1,26 @@ + + + + + + + + + + + + + + + + traceId + spanId + + + + + + + + + diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/CodeChallengeApplicationTests.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/CodeChallengeApplicationTests.java new file mode 100644 index 0000000000..cea383e364 --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/CodeChallengeApplicationTests.java @@ -0,0 +1,17 @@ +package com.yaperos.codechallenge; + +import org.junit.jupiter.api.Test; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.kafka.test.context.EmbeddedKafka; +import org.springframework.test.context.ActiveProfiles; + +@SpringBootTest +@EmbeddedKafka(partitions = 1, topics = {"transaction-created", "transaction-status", "transaction-created.DLT", "transaction-status.DLT"}) +@ActiveProfiles("test") +class CodeChallengeApplicationTests { + + @Test + void contextLoads() { + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudServiceTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudServiceTest.java new file mode 100644 index 0000000000..dd0fe1e229 --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/antifraud/application/service/AntiFraudServiceTest.java @@ -0,0 +1,74 @@ +package com.yaperos.codechallenge.antifraud.application.service; + +import com.yaperos.codechallenge.antifraud.domain.model.FraudCheckResult; +import com.yaperos.codechallenge.antifraud.domain.port.output.FraudResultPublisherPort; +import com.yaperos.codechallenge.shared.event.TransactionStatusType; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.ArgumentCaptor; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; + +import java.math.BigDecimal; +import java.util.UUID; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.verify; + +@ExtendWith(MockitoExtension.class) +class AntiFraudServiceTest { + + @Mock + private FraudResultPublisherPort fraudResultPublisher; + + @InjectMocks + private AntiFraudService antiFraudService; + + @Test + void validate_shouldApproveTransactionWithValueLessThanOrEqualTo1000() { + UUID transactionId = UUID.randomUUID(); + + antiFraudService.validate(transactionId, new BigDecimal("1000")); + + ArgumentCaptor captor = ArgumentCaptor.forClass(FraudCheckResult.class); + verify(fraudResultPublisher).publishResult(captor.capture()); + assertEquals(TransactionStatusType.APPROVED, captor.getValue().getStatus()); + assertEquals(transactionId, captor.getValue().getTransactionExternalId()); + } + + @Test + void validate_shouldRejectTransactionWithValueGreaterThan1000() { + UUID transactionId = UUID.randomUUID(); + + antiFraudService.validate(transactionId, new BigDecimal("1001")); + + ArgumentCaptor captor = ArgumentCaptor.forClass(FraudCheckResult.class); + verify(fraudResultPublisher).publishResult(captor.capture()); + assertEquals(TransactionStatusType.REJECTED, captor.getValue().getStatus()); + assertEquals(transactionId, captor.getValue().getTransactionExternalId()); + } + + @Test + void validate_shouldApproveTransactionWithSmallValue() { + UUID transactionId = UUID.randomUUID(); + + antiFraudService.validate(transactionId, new BigDecimal("120")); + + ArgumentCaptor captor = ArgumentCaptor.forClass(FraudCheckResult.class); + verify(fraudResultPublisher).publishResult(captor.capture()); + assertEquals(TransactionStatusType.APPROVED, captor.getValue().getStatus()); + } + + @Test + void validate_shouldRejectTransactionWithLargeValue() { + UUID transactionId = UUID.randomUUID(); + + antiFraudService.validate(transactionId, new BigDecimal("5000")); + + ArgumentCaptor captor = ArgumentCaptor.forClass(FraudCheckResult.class); + verify(fraudResultPublisher).publishResult(captor.capture()); + assertEquals(TransactionStatusType.REJECTED, captor.getValue().getStatus()); + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandlerTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandlerTest.java new file mode 100644 index 0000000000..958213cd10 --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/shared/exception/GlobalExceptionHandlerTest.java @@ -0,0 +1,50 @@ +package com.yaperos.codechallenge.shared.exception; + +import com.yaperos.codechallenge.transaction.domain.exception.InvalidTransferTypeException; +import com.yaperos.codechallenge.transaction.domain.exception.TransactionNotFoundException; +import org.junit.jupiter.api.Test; +import org.springframework.http.ResponseEntity; + +import java.util.UUID; + +import static org.junit.jupiter.api.Assertions.*; + +class GlobalExceptionHandlerTest { + + private final GlobalExceptionHandler handler = new GlobalExceptionHandler(); + + @Test + void handleTransactionNotFound_shouldReturn404() { + UUID id = UUID.randomUUID(); + TransactionNotFoundException ex = new TransactionNotFoundException(id); + + ResponseEntity response = handler.handleTransactionNotFound(ex); + + assertEquals(404, response.getStatusCode().value()); + assertEquals("Not Found", response.getBody().getError()); + assertTrue(response.getBody().getMessage().contains(id.toString())); + } + + @Test + void handleInvalidTransferType_shouldReturn400() { + InvalidTransferTypeException ex = new InvalidTransferTypeException(999); + + ResponseEntity response = handler.handleInvalidTransferType(ex); + + assertEquals(400, response.getStatusCode().value()); + assertEquals("Bad Request", response.getBody().getError()); + assertTrue(response.getBody().getMessage().contains("999")); + } + + @Test + void handleGeneric_shouldReturn500() { + Exception ex = new RuntimeException("something broke"); + + ResponseEntity response = handler.handleGeneric(ex); + + assertEquals(500, response.getStatusCode().value()); + assertEquals("Internal Server Error", response.getBody().getError()); + assertEquals("An unexpected error occurred", response.getBody().getMessage()); + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/TransactionFlowIntegrationTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/TransactionFlowIntegrationTest.java new file mode 100644 index 0000000000..b3a71c44de --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/TransactionFlowIntegrationTest.java @@ -0,0 +1,112 @@ +package com.yaperos.codechallenge.transaction; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.yaperos.codechallenge.transaction.domain.model.TransactionStatus; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.CreateTransactionRequest; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.dto.TransactionResponse; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.output.persistence.repository.SpringDataTransactionRepository; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.http.MediaType; +import org.springframework.kafka.test.context.EmbeddedKafka; +import org.springframework.test.context.ActiveProfiles; +import org.springframework.test.web.servlet.MockMvc; +import org.springframework.test.web.servlet.MvcResult; + +import java.math.BigDecimal; +import java.util.UUID; +import java.util.concurrent.TimeUnit; + +import static org.awaitility.Awaitility.await; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; + +@SpringBootTest +@AutoConfigureMockMvc +@EmbeddedKafka(partitions = 1, topics = {"transaction-created", "transaction-status", "transaction-created.DLT", "transaction-status.DLT"}) +@ActiveProfiles("test") +class TransactionFlowIntegrationTest { + + @Autowired + private MockMvc mockMvc; + + @Autowired + private ObjectMapper objectMapper; + + @Autowired + private SpringDataTransactionRepository repository; + + @Test + void shouldCreateTransactionAndApproveViaKafka() throws Exception { + CreateTransactionRequest request = new CreateTransactionRequest( + UUID.randomUUID(), + UUID.randomUUID(), + 1, + new BigDecimal("120") + ); + + MvcResult result = mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content(objectMapper.writeValueAsString(request))) + .andExpect(status().isCreated()) + .andExpect(jsonPath("$.transactionExternalId").exists()) + .andExpect(jsonPath("$.transactionStatus.name").value("pending")) + .andExpect(jsonPath("$.value").value(120)) + .andReturn(); + + TransactionResponse response = objectMapper.readValue( + result.getResponse().getContentAsString(), TransactionResponse.class); + UUID transactionId = response.getTransactionExternalId(); + assertNotNull(transactionId); + + // Wait for Kafka to process the transaction through anti-fraud and back + await().atMost(10, TimeUnit.SECONDS).untilAsserted(() -> { + var entity = repository.findById(transactionId).orElseThrow(); + assertEquals(TransactionStatus.APPROVED, entity.getStatus()); + }); + + // Verify via GET endpoint + mockMvc.perform(get("/transactions/{id}", transactionId)) + .andExpect(status().isOk()) + .andExpect(jsonPath("$.transactionStatus.name").value("approved")); + } + + @Test + void shouldCreateTransactionAndRejectViaKafka() throws Exception { + CreateTransactionRequest request = new CreateTransactionRequest( + UUID.randomUUID(), + UUID.randomUUID(), + 1, + new BigDecimal("1500") + ); + + MvcResult result = mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content(objectMapper.writeValueAsString(request))) + .andExpect(status().isCreated()) + .andExpect(jsonPath("$.transactionStatus.name").value("pending")) + .andReturn(); + + TransactionResponse response = objectMapper.readValue( + result.getResponse().getContentAsString(), TransactionResponse.class); + UUID transactionId = response.getTransactionExternalId(); + + // Wait for Kafka to process the transaction through anti-fraud and back + await().atMost(10, TimeUnit.SECONDS).untilAsserted(() -> { + var entity = repository.findById(transactionId).orElseThrow(); + assertEquals(TransactionStatus.REJECTED, entity.getStatus()); + }); + + // Verify via GET endpoint + mockMvc.perform(get("/transactions/{id}", transactionId)) + .andExpect(status().isOk()) + .andExpect(jsonPath("$.transactionStatus.name").value("rejected")); + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/application/service/TransactionServiceTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/application/service/TransactionServiceTest.java new file mode 100644 index 0000000000..513e1c1101 --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/application/service/TransactionServiceTest.java @@ -0,0 +1,107 @@ +package com.yaperos.codechallenge.transaction.application.service; + +import com.yaperos.codechallenge.shared.event.TransactionStatusType; +import com.yaperos.codechallenge.transaction.domain.exception.TransactionNotFoundException; +import com.yaperos.codechallenge.transaction.domain.model.Transaction; +import com.yaperos.codechallenge.transaction.domain.model.TransactionStatus; +import com.yaperos.codechallenge.transaction.domain.model.TransferType; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionEventPublisherPort; +import com.yaperos.codechallenge.transaction.domain.port.output.TransactionRepositoryPort; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; + +import java.math.BigDecimal; +import java.util.Optional; +import java.util.UUID; + +import static org.junit.jupiter.api.Assertions.*; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.*; + +@ExtendWith(MockitoExtension.class) +class TransactionServiceTest { + + @Mock + private TransactionRepositoryPort transactionRepository; + + @Mock + private TransactionEventPublisherPort eventPublisher; + + @InjectMocks + private TransactionService transactionService; + + private UUID debitId; + private UUID creditId; + + @BeforeEach + void setUp() { + debitId = UUID.randomUUID(); + creditId = UUID.randomUUID(); + } + + @Test + void create_shouldSaveAndPublishEvent() { + when(transactionRepository.save(any(Transaction.class))) + .thenAnswer(invocation -> invocation.getArgument(0)); + + Transaction result = transactionService.create(debitId, creditId, TransferType.EXTERNAL, new BigDecimal("500")); + + assertNotNull(result); + assertEquals(TransactionStatus.PENDING, result.getStatus()); + assertEquals(new BigDecimal("500"), result.getValue()); + verify(transactionRepository).save(any(Transaction.class)); + verify(eventPublisher).publishTransactionCreated(any(Transaction.class)); + } + + @Test + void getById_shouldReturnTransaction() { + Transaction transaction = Transaction.create(debitId, creditId, TransferType.EXTERNAL, new BigDecimal("200")); + when(transactionRepository.findById(transaction.getTransactionExternalId())) + .thenReturn(Optional.of(transaction)); + + Transaction result = transactionService.getById(transaction.getTransactionExternalId()); + + assertEquals(transaction.getTransactionExternalId(), result.getTransactionExternalId()); + } + + @Test + void getById_shouldThrowWhenNotFound() { + UUID id = UUID.randomUUID(); + when(transactionRepository.findById(id)).thenReturn(Optional.empty()); + + assertThrows(TransactionNotFoundException.class, () -> transactionService.getById(id)); + } + + @Test + void updateStatus_shouldApproveTransaction() { + Transaction transaction = Transaction.create(debitId, creditId, TransferType.EXTERNAL, new BigDecimal("100")); + when(transactionRepository.findById(transaction.getTransactionExternalId())) + .thenReturn(Optional.of(transaction)); + when(transactionRepository.save(any(Transaction.class))) + .thenAnswer(invocation -> invocation.getArgument(0)); + + transactionService.updateStatus(transaction.getTransactionExternalId(), TransactionStatusType.APPROVED); + + assertEquals(TransactionStatus.APPROVED, transaction.getStatus()); + verify(transactionRepository).save(transaction); + } + + @Test + void updateStatus_shouldRejectTransaction() { + Transaction transaction = Transaction.create(debitId, creditId, TransferType.EXTERNAL, new BigDecimal("1500")); + when(transactionRepository.findById(transaction.getTransactionExternalId())) + .thenReturn(Optional.of(transaction)); + when(transactionRepository.save(any(Transaction.class))) + .thenAnswer(invocation -> invocation.getArgument(0)); + + transactionService.updateStatus(transaction.getTransactionExternalId(), TransactionStatusType.REJECTED); + + assertEquals(TransactionStatus.REJECTED, transaction.getStatus()); + verify(transactionRepository).save(transaction); + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/domain/model/TransactionTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/domain/model/TransactionTest.java new file mode 100644 index 0000000000..a89365a9cc --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/domain/model/TransactionTest.java @@ -0,0 +1,97 @@ +package com.yaperos.codechallenge.transaction.domain.model; + +import com.yaperos.codechallenge.transaction.domain.exception.InvalidTransferTypeException; +import org.junit.jupiter.api.Test; + +import java.math.BigDecimal; +import java.util.UUID; + +import static org.junit.jupiter.api.Assertions.*; + +class TransactionTest { + + @Test + void create_shouldInitializeWithPendingStatus() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), + UUID.randomUUID(), + TransferType.EXTERNAL, + new BigDecimal("500") + ); + + assertNotNull(transaction.getTransactionExternalId()); + assertEquals(TransactionStatus.PENDING, transaction.getStatus()); + assertEquals(new BigDecimal("500"), transaction.getValue()); + assertEquals(TransferType.EXTERNAL, transaction.getTransferType()); + assertNotNull(transaction.getCreatedAt()); + } + + @Test + void approve_shouldChangeStatusToApproved() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("100")); + + transaction.approve(); + + assertEquals(TransactionStatus.APPROVED, transaction.getStatus()); + } + + @Test + void reject_shouldChangeStatusToRejected() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("2000")); + + transaction.reject(); + + assertEquals(TransactionStatus.REJECTED, transaction.getStatus()); + } + + @Test + void approve_shouldBeIdempotentWhenAlreadyApproved() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("100")); + transaction.approve(); + + assertDoesNotThrow(transaction::approve); + assertEquals(TransactionStatus.APPROVED, transaction.getStatus()); + } + + @Test + void reject_shouldBeIdempotentWhenAlreadyRejected() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("2000")); + transaction.reject(); + + assertDoesNotThrow(transaction::reject); + assertEquals(TransactionStatus.REJECTED, transaction.getStatus()); + } + + @Test + void approve_shouldThrowWhenAlreadyRejected() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("2000")); + transaction.reject(); + + assertThrows(IllegalStateException.class, transaction::approve); + } + + @Test + void reject_shouldThrowWhenAlreadyApproved() { + Transaction transaction = Transaction.create( + UUID.randomUUID(), UUID.randomUUID(), TransferType.EXTERNAL, new BigDecimal("100")); + transaction.approve(); + + assertThrows(IllegalStateException.class, transaction::reject); + } + + @Test + void transferType_fromId_shouldReturnCorrectType() { + assertEquals(TransferType.EXTERNAL, TransferType.fromId(1)); + } + + @Test + void transferType_fromId_shouldThrowForUnknownId() { + assertThrows(InvalidTransferTypeException.class, () -> TransferType.fromId(999)); + } + +} diff --git a/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionControllerErrorTest.java b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionControllerErrorTest.java new file mode 100644 index 0000000000..317db94ca7 --- /dev/null +++ b/yape-code-challenge/src/test/java/com/yaperos/codechallenge/transaction/infrastructure/adapter/input/web/TransactionControllerErrorTest.java @@ -0,0 +1,89 @@ +package com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web; + +import com.yaperos.codechallenge.transaction.domain.exception.TransactionNotFoundException; +import com.yaperos.codechallenge.transaction.domain.port.input.CreateTransactionUseCase; +import com.yaperos.codechallenge.transaction.domain.port.input.GetTransactionUseCase; +import com.yaperos.codechallenge.transaction.infrastructure.adapter.input.web.mapper.TransactionWebMapper; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; +import org.springframework.test.context.bean.override.mockito.MockitoBean; +import org.springframework.context.annotation.Import; +import org.springframework.http.MediaType; +import org.springframework.test.web.servlet.MockMvc; + +import java.util.UUID; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; + +@WebMvcTest(TransactionController.class) +@Import(com.yaperos.codechallenge.shared.exception.GlobalExceptionHandler.class) +class TransactionControllerErrorTest { + + @Autowired + private MockMvc mockMvc; + + @MockitoBean + private CreateTransactionUseCase createTransactionUseCase; + + @MockitoBean + private GetTransactionUseCase getTransactionUseCase; + + @MockitoBean + private TransactionWebMapper mapper; + + @Test + void getById_shouldReturn404WhenNotFound() throws Exception { + UUID id = UUID.randomUUID(); + when(getTransactionUseCase.getById(any(UUID.class))) + .thenThrow(new TransactionNotFoundException(id)); + + mockMvc.perform(get("/transactions/{id}", id)) + .andExpect(status().isNotFound()) + .andExpect(jsonPath("$.status").value(404)) + .andExpect(jsonPath("$.error").value("Not Found")); + } + + @Test + void create_shouldReturn400ForInvalidTransferType() throws Exception { + String body = """ + { + "accountExternalIdDebit": "%s", + "accountExternalIdCredit": "%s", + "tranferTypeId": 999, + "value": 100 + } + """.formatted(UUID.randomUUID(), UUID.randomUUID()); + + mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content(body)) + .andExpect(status().isBadRequest()) + .andExpect(jsonPath("$.status").value(400)) + .andExpect(jsonPath("$.error").value("Bad Request")); + } + + @Test + void create_shouldReturn400ForMalformedBody() throws Exception { + mockMvc.perform(post("/transactions") + .contentType(MediaType.APPLICATION_JSON) + .content("{not valid json")) + .andExpect(status().isBadRequest()) + .andExpect(jsonPath("$.status").value(400)) + .andExpect(jsonPath("$.message").value("Malformed JSON request")); + } + + @Test + void getById_shouldReturn400ForInvalidUuid() throws Exception { + mockMvc.perform(get("/transactions/{id}", "not-a-uuid")) + .andExpect(status().isBadRequest()) + .andExpect(jsonPath("$.status").value(400)) + .andExpect(jsonPath("$.error").value("Bad Request")); + } + +} diff --git a/yape-code-challenge/src/test/resources/application-test.yaml b/yape-code-challenge/src/test/resources/application-test.yaml new file mode 100644 index 0000000000..202d0bfc8d --- /dev/null +++ b/yape-code-challenge/src/test/resources/application-test.yaml @@ -0,0 +1,31 @@ +spring: + cache: + type: simple + datasource: + url: jdbc:h2:mem:testdb;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE + driver-class-name: org.h2.Driver + username: sa + password: + jpa: + hibernate: + ddl-auto: create-drop + show-sql: true + database-platform: org.hibernate.dialect.H2Dialect + kafka: + bootstrap-servers: ${spring.embedded.kafka.brokers} + consumer: + auto-offset-reset: earliest + group-id: test-group + key-deserializer: org.apache.kafka.common.serialization.StringDeserializer + value-deserializer: org.springframework.kafka.support.serializer.JsonDeserializer + properties: + spring.json.trusted.packages: com.yaperos.codechallenge.* + producer: + key-serializer: org.apache.kafka.common.serialization.StringSerializer + value-serializer: org.springframework.kafka.support.serializer.JsonSerializer + +management: + endpoints: + web: + exposure: + include: health