Merge pull request #37 from rondale-sc/use-notify-property-change

Utilize notifyPropertyChange instead of property(Will|Did)Change

Author: lukemelia

.travis.yml

@@ -5,7 +5,7 @@ node_js:
   # so that your addon works for all apps
   - "4"
 
-sudo: false
+sudo: required
 dist: trusty
 
 addons:

addon/mixin.js

@@ -12,6 +12,7 @@ const {
   getProperties,
   defineProperty,
   meta,
+  notifyPropertyChange,
 } = Ember;
 
 const keys = Object.keys || Ember.keys;
@@ -71,7 +72,6 @@ export default Ember.Mixin.create({
       return;
     }
 
-    this.propertyWillChange(key);
 
     if (current === value) {
       delete buffer[key];
@@ -83,7 +83,7 @@ export default Ember.Mixin.create({
       set(this, 'hasBufferedChanges', true);
     }
 
-    this.propertyDidChange(key);
+    notifyPropertyChange(this, key);
 
     return value;
   },
@@ -116,8 +116,7 @@ export default Ember.Mixin.create({
         return;
       }
 
-      this.propertyWillChange(key);
-      this.propertyDidChange(key);
+      notifyPropertyChange(this, key);
     });
 
     if (empty(get(this, 'buffer'))) {

package.json

@@ -24,7 +24,8 @@
     "test": "ember try:each"
   },
   "dependencies": {
-    "ember-cli-babel": "^6.6.0"
+    "ember-cli-babel": "^6.6.0",
+    "ember-notify-property-change-polyfill": "^0.0.1"
   },
   "devDependencies": {
     "broccoli-asset-rev": "^2.4.5",

yarn.lock

@@ -2195,6 +2195,13 @@ ember-load-initializers@^1.0.0:
   dependencies:
     ember-cli-babel "^6.0.0-beta.7"
 
+ember-notify-property-change-polyfill@^0.0.1:
+  version "0.0.1"
+  resolved "https://registry.yarnpkg.com/ember-notify-property-change-polyfill/-/ember-notify-property-change-polyfill-0.0.1.tgz#636f75e2aaf67e2c56cb13e7139499226fd60d55"
+  dependencies:
+    ember-cli-babel "^6.6.0"
+    ember-cli-version-checker "^2.1.0"
+
 ember-qunit@^2.2.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/ember-qunit/-/ember-qunit-2.2.0.tgz#3cdf400031c93a38de781a7304819738753b7f99"