Merge pull request #42 from yapplabs/deprecations

Eliminate use of deprecated APIs in ember 3.24

Author: lukemelia

addon/mixins/col-pick.js

@@ -60,7 +60,7 @@ export default Mixin.create({
     var colorScheme = this.colorScheme;
 
     if (layout && colorScheme) {
-      var colpick = (this._colpick = this.$().colpick({
+      var colpick = (this._colpick = $(this.element).colpick({
         layout: layout,
         colorScheme: colorScheme,
         submit: 0,
@@ -78,8 +78,7 @@ export default Mixin.create({
           }
         },
         onHide: () => {
-          // eslint-disable-next-line ember/closure-actions
-          this.sendAction('onHide');
+          this.onHide?.();
         },
       }));
 
@@ -105,7 +104,7 @@ export default Mixin.create({
 
   popup: function () {
     if (this._state === 'inDOM') {
-      return $('#' + this.$().data('colpickId'));
+      return $('#' + $(this.element).data('colpickId'));
     }
   },
 

tests/dummy/config/deprecation-workflow.js

@@ -1,13 +1,5 @@
 /* eslint-disable no-undef */
 self.deprecationWorkflow = self.deprecationWorkflow || {};
 self.deprecationWorkflow.config = {
-  workflow: [
-    {
-      handler: 'silence',
-      matchId: 'ember-views.curly-components.jquery-element',
-    },
-    { handler: 'silence', matchId: 'ember-source.deprecation-without-for' },
-    { handler: 'silence', matchId: 'ember-source.deprecation-without-since' },
-    { handler: 'silence', matchId: 'ember-component.send-action' },
-  ],
+  workflow: [],
 };