Skip to content

Commit 2f88411

Browse files
committed
fix: ai review
1 parent 3aec811 commit 2f88411

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

src/containers/App/Content.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import routes, {getClusterPath} from '../../routes';
1414
import type {RootState} from '../../store';
1515
import {authenticationApi} from '../../store/reducers/authentication/authentication';
1616
import {
17-
useAllCapablitiesStatus,
17+
useAllCapabilitiesStatus,
1818
useClusterWithoutAuthInUI,
1919
useMetaCapabilitiesLoaded,
2020
useMetaCapabilitiesQuery,
@@ -235,7 +235,7 @@ function GetNodesList() {
235235
}
236236

237237
function GetCapabilities({children}: {children: React.ReactNode}) {
238-
const {error, loading} = useAllCapablitiesStatus();
238+
const {error, loading} = useAllCapabilitiesStatus();
239239

240240
//do nothing, authentication is in progress upon redirect
241241
if (isRedirectToAuth(error)) {

src/containers/Header/Header.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {checkIsClustersPage, checkIsTenantPage, getClusterPath} from '../../rout
1919
import {environment} from '../../store';
2020
import {
2121
useAddClusterFeatureAvailable,
22-
useAllCapablitiesStatus,
22+
useAllCapabilitiesStatus,
2323
useDatabasesAvailable,
2424
useDeleteDatabaseFeatureAvailable,
2525
useEditDatabaseFeatureAvailable,
@@ -51,7 +51,7 @@ import './Header.scss';
5151
const b = cn('header');
5252

5353
function Header() {
54-
const {loading} = useAllCapablitiesStatus();
54+
const {loading} = useAllCapabilitiesStatus();
5555
const {page, pageBreadcrumbsOptions} = useTypedSelector((state) => state.header);
5656
const singleClusterMode = useTypedSelector((state) => state.singleClusterMode);
5757
const isUserAllowedToMakeChanges = useIsUserAllowedToMakeChanges();

src/store/reducers/capabilities/hooks.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import React from 'react';
2+
13
import type {Capability, MetaCapability, SecuritySetting} from '../../../types/api/capabilities';
24
import {uiFactory} from '../../../uiFactory/uiFactory';
35
import {useTypedSelector} from '../../../utils/hooks';
@@ -30,7 +32,7 @@ export function useCapabilitiesLoaded() {
3032
return Boolean(data || error);
3133
}
3234

33-
export function useAllCapablitiesStatus() {
35+
export function useAllCapabilitiesStatus() {
3436
const {data, error} = useCapabilitiesQuery();
3537

3638
useMetaCapabilitiesQuery();
@@ -39,7 +41,10 @@ export function useAllCapablitiesStatus() {
3941

4042
const capabilitiesLoaded = Boolean(data || error);
4143

42-
return {error, loading: !capabilitiesLoaded || !metaCapabilitiesLoaded};
44+
return React.useMemo(
45+
() => ({error, loading: !capabilitiesLoaded || !metaCapabilitiesLoaded}),
46+
[error, capabilitiesLoaded, metaCapabilitiesLoaded],
47+
);
4348
}
4449

4550
const useGetFeatureVersion = (feature: Capability) => {

0 commit comments

Comments
 (0)