update rsbuild envs

Author: artemmufazalov

package.json

@@ -67,7 +67,6 @@
     "start": "rsbuild dev",
     "dev": "DISABLE_ESLINT_PLUGIN=true TSC_COMPILE_ON_ERROR=true REACT_APP_BACKEND=http://localhost:8765 REACT_APP_META_BACKEND=undefined rsbuild dev",
     "build": "rm -rf build && DISABLE_ESLINT_PLUGIN=true CI=true rsbuild build",
-    "//build:embedded": "echo 'PUBLIC_URL is a setting for create-react-app. Embedded version is built and hosted as is on ydb servers, with no way of knowing the final URL pattern. PUBLIC_URL=. keeps paths to all static relative, allowing servers to handle them as needed'",
     "build:embedded": "GENERATE_SOURCEMAP=false REACT_APP_BACKEND=http://localhost:8765 REACT_APP_META_BACKEND=undefined npm run build",
     "build:embedded-mc": "GENERATE_SOURCEMAP=false PUBLIC_URL=. REACT_APP_BACKEND= REACT_APP_META_BACKEND= npm run build",
     "build:embedded:archive": "npm run build:embedded && mv build embedded-ui && cp CHANGELOG.md embedded-ui/CHANGELOG.md && zip -r embedded-ui.zip embedded-ui && rm -rf embedded-ui",

rsbuild.config.ts

@@ -4,19 +4,52 @@ import {pluginSass} from '@rsbuild/plugin-sass';
 import {pluginSvgr} from '@rsbuild/plugin-svgr';
 import MonacoWebpackPlugin from 'monaco-editor-webpack-plugin';
 
+/**
+ * List of environment variables that should be accessible in HTML and JavaScript files.
+ * These variables are injected into the client-side code via process.env definitions.
+ */
+const APP_VARS = [
+    'DISABLE_ESLINT_PLUGIN',
+    'TSC_COMPILE_ON_ERROR',
+    'REACT_APP_DISABLE_CHECKS',
+
+    // Backend configuration
+    'REACT_APP_BACKEND',
+    'REACT_APP_META_BACKEND',
+    'META_YDB_BACKEND',
+];
+
+/**
+ * Prepares environment variables to be exposed in client-side code.
+ *
+ * This function:
+ * 1. Loads environment variables from .env files using rsbuild's loadEnv()
+ * 2. Explicitly checks process.env for each variable (prioritizes process.env over .env file values)
+ * 3. Stringifies values for safe injection into JavaScript code via source.define
+ *
+ * CRITICAL FOR CI: We must explicitly pass process.env variables to source.define,
+ * otherwise they are not accessible in client code in CI (GitHub Actions).
+ * rsbuild's loadEnv() only reads from .env files, not from process.env by default.
+ */
 const prepareEnvVars = () => {
-    // Load values from .env
+    // Load values from .env files (if they exist)
     const {parsed} = loadEnv();
 
     const result: Record<string, string> = {};
 
-    // Additionall stringify vars to prevent errors with invalid symbols
-    // rsbuild parses values additionally
-    Object.entries(parsed).forEach(([key, value]) => {
-        result[key] = JSON.stringify(value);
+    APP_VARS.forEach((name) => {
+        // Priority: process.env > .env file
+        // This ensures CI-provided env vars (from GitHub Actions, Playwright webServer, etc.)
+        // take precedence over .env file values
+        const value = process.env[name] ?? parsed[name];
+        // Stringify for safe injection into JavaScript code
+        result[name] = JSON.stringify(value);
     });
 
-    return result;
+    return {
+        // Without this, environment variables would not be available in index.html or JavaScript
+        'process.env': result,
+    };
 };
 
 export default defineConfig({
@@ -38,6 +71,7 @@ export default defineConfig({
             'node_modules/@gravity-ui/websql-autocomplete',
             'node_modules/antlr4ng',
         ],
+        define: prepareEnvVars(),
     },
     output: {
         distPath: {
@@ -49,12 +83,8 @@ export default defineConfig({
         template: './public/index.html',
     },
     tools: {
-        rspack(config, {appendPlugins, rspack}) {
+        rspack(config, {appendPlugins}) {
             appendPlugins([
-                new rspack.DefinePlugin({
-                    // Without it vars from .env are not available in index.html
-                    'process.env': prepareEnvVars(),
-                }),
                 new MonacoWebpackPlugin({
                     languages: ['yaml'],
                     customLanguages: [