fix(Header): wait for capabilities before show content #3145
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| return Boolean(data || error); | ||
| } | ||
|
|
||
| export function useAllCapablitiesStatus() { |
Contributor
There was a problem hiding this comment.
syntax: typo: 'Capablities' should be 'Capabilities'
Suggested change
| export function useAllCapablitiesStatus() { | |
| export function useAllCapabilitiesStatus() { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/store/reducers/capabilities/hooks.ts
Line: 33:33
Comment:
**syntax:** typo: 'Capablities' should be 'Capabilities'
```suggestion
export function useAllCapabilitiesStatus() {
```
How can I resolve this? If you propose a fix, please make it concise.
src/containers/App/Content.tsx
Outdated
| import {authenticationApi} from '../../store/reducers/authentication/authentication'; | ||
| import { | ||
| useCapabilitiesQuery, | ||
| useAllCapablitiesStatus, |
Contributor
There was a problem hiding this comment.
syntax: typo: 'Capablities' should be 'Capabilities'
Suggested change
| useAllCapablitiesStatus, | |
| useAllCapabilitiesStatus, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/containers/App/Content.tsx
Line: 17:17
Comment:
**syntax:** typo: 'Capablities' should be 'Capabilities'
```suggestion
useAllCapabilitiesStatus,
```
How can I resolve this? If you propose a fix, please make it concise.
src/containers/Header/Header.tsx
Outdated
| import {environment} from '../../store'; | ||
| import { | ||
| useAddClusterFeatureAvailable, | ||
| useAllCapablitiesStatus, |
Contributor
There was a problem hiding this comment.
syntax: typo: 'Capablities' should be 'Capabilities'
Suggested change
| useAllCapablitiesStatus, | |
| useAllCapabilitiesStatus, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/containers/Header/Header.tsx
Line: 22:22
Comment:
**syntax:** typo: 'Capablities' should be 'Capabilities'
```suggestion
useAllCapabilitiesStatus,
```
How can I resolve this? If you propose a fix, please make it concise.
Copilot finished reviewing on behalf of
Raubzeug
November 28, 2025 15:11
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a timing issue where the Header component could render before capabilities data is fully loaded. A new custom hook useAllCapablitiesStatus centralizes the logic for checking both cluster and meta capabilities loading status, which is then used to conditionally render Header content.
Key changes:
- Created a reusable hook to check the combined loading state of both capabilities queries
- Modified Header to wait for capabilities to load before rendering its content
- Refactored Content.tsx to use the new hook, eliminating code duplication
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/store/reducers/capabilities/hooks.ts | Introduces new hook useAllCapablitiesStatus to centralize capabilities loading state checking |
| src/containers/Header/Header.tsx | Updates Header to wait for capabilities before rendering content using the new hook |
| src/containers/App/Content.tsx | Refactors to use the new centralized hook, removing duplicated logic |
| // It is always true if there is no meta, since request finishes with an error | ||
| const metaCapabilitiesLoaded = useMetaCapabilitiesLoaded(); | ||
|
|
||
| const capabilitiesLoaded = Boolean(data || error); |
Member
There was a problem hiding this comment.
There is hook useCapabilitiesLoaded for capabilities. So you can use:
useCapabilitiesQuery()
useMetaCapabilitiesQuery()
const capabilitiesLoaded = useCapabilitiesLoaded()
const metaCapabilitiesLoaded = useMetaCapabilitiesLoaded()
It doesn't change much, but it hide loading logic within one hook
Contributor
Author
There was a problem hiding this comment.
Thanks! i've totally forgot abt this hook. Reworked logic a bit.
artemmufazalov
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 66.06 MB | Main: 66.06 MB
Diff: +0.59 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information