-
Notifications
You must be signed in to change notification settings - Fork 17
chore: regenerate package.lock with 11 npm, fix canvas conflict #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "typescript": "$typescript", | ||
| "monaco-editor": "$monaco-editor" | ||
| "monaco-editor": "$monaco-editor", | ||
| "canvas": "^2.11.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's optional peer in jest-environment-jsdom@30.2.0 - it requires canvas@3.0.0. Also it's required by paranoid.
jest-environment-jsdom is used for tests and works well with lower canvas version, so I set version to what is required by paranoid.
This override can be deleted, when we get rid of paranoid and move to graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR regenerates package-lock.json with npm 11 (correcting the mistake from PR #3137 which used npm 10) and resolves a dependency conflict with the canvas package by adding it to the overrides section.
Key changes:
- Added
canvas: ^2.11.2to package.json overrides to resolve dependency conflicts - Regenerated package-lock.json with npm 11, which updates peer dependency metadata
- Canvas package is correctly marked as optional since it's only needed for Node.js server-side rendering (used by the qrcode library)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added canvas: ^2.11.2 to overrides section to resolve dependency conflict with the qrcode package |
| package-lock.json | Regenerated lockfile with npm 11, updating peer dependency flags and adding canvas 2.11.2 as an optional dependency |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
By mistake I made my rsbuild PR with 10 npm: #3137
Now package.lock is regenerated with correct 11 npm, dependency conflict with
canvasis fixedCI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.32 MB | Main: 62.32 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information
Greptile Overview
Greptile Summary
This PR regenerates
package-lock.jsonwith npm 11 (correcting the previous npm 10 version used in PR #3137) and resolves acanvasdependency conflict by adding it to theoverridessection.Key changes:
canvas^2.11.2 topackage.jsonoverrides to resolve peer dependency conflictpackage-lock.jsonwith npm 11, resulting in lockfileVersion 3 formatcanvaspackage added as optional dependency with native build support via@mapbox/node-pre-gypThe changes are administrative in nature - no functional code is modified. This ensures proper dependency alignment and resolves the canvas conflict that may have been causing installation issues.
Confidence Score: 5/5
Important Files Changed
File Analysis
canvas^2.11.2 tooverridessection to resolve peer dependency conflictcanvasas optional dependency with@mapbox/node-pre-gypsupport, adjusted peer dependency flagsSequence Diagram
sequenceDiagram participant Dev as Developer participant npm as npm 11 participant pkg as package.json participant lock as package-lock.json participant canvas as canvas package Dev->>pkg: Add canvas to overrides Note over pkg: canvas: ^2.11.2 Dev->>npm: Run npm install npm->>pkg: Read package.json npm->>pkg: Process overrides section npm->>canvas: Resolve canvas dependency canvas->>npm: Return version 2.11.2 npm->>lock: Generate lockfileVersion 3 Note over lock: Update peer flags Note over lock: Add @mapbox/node-pre-gyp lock-->>npm: Lockfile updated npm-->>Dev: Installation complete