Skip to content

Violation Comparison Logic (Possible Bug) #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DeHopen opened this issue May 14, 2025 · 0 comments
Open

Violation Comparison Logic (Possible Bug) #1339

DeHopen opened this issue May 14, 2025 · 0 comments

Comments

@DeHopen
Copy link
Contributor

DeHopen commented May 14, 2025

@yegor256

In Violation.Default.compareTo:

return this.vldtr.compareToIgnoreCase(other.validator());

  • Problem: This only compares the validator name, not the file, line, or message, which may not provide a meaningful ordering for violations.

  • Consequence: Sorting violations may not be stable or useful.

  • Fix: Consider comparing all relevant fields for a more robust ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DeHopen