Fix #2248

yhirose · yhirose · commit 84796738fc5d · 2025-11-25T22:22:07.000-05:00
diff --git a/test/test.cc b/test/test.cc
@@ -7618,7 +7618,14 @@ TEST(SNI_AutoDetectionTest, SNI_Logic) {
       SSLClient cli("::1", PORT);
       cli.enable_server_certificate_verification(false);
       auto res = cli.Get("/sni?expected=");
-      ASSERT_TRUE(res);
+
+      // NOTE: This may fail if the server is listening on IPv4 only
+      // (e.g., when localhost resolves to 127.0.0.1 only)
+      if (res) {
+        EXPECT_EQ(StatusCode::OK_200, res->status);
+      } else {
+        EXPECT_EQ(Error::Connection, res.error());
+      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -7618,7 +7618,14 @@ TEST(SNI_AutoDetectionTest, SNI_Logic) {`
`7618`	`7618`	`SSLClient cli("::1", PORT);`
`7619`	`7619`	`cli.enable_server_certificate_verification(false);`
`7620`	`7620`	`auto res = cli.Get("/sni?expected=");`
`7621`		`- ASSERT_TRUE(res);`
	`7621`	`+`
	`7622`	`+ // NOTE: This may fail if the server is listening on IPv4 only`
	`7623`	`+ // (e.g., when localhost resolves to 127.0.0.1 only)`
	`7624`	`+ if (res) {`
	`7625`	`+ EXPECT_EQ(StatusCode::OK_200, res->status);`
	`7626`	`+ } else {`
	`7627`	`+ EXPECT_EQ(Error::Connection, res.error());`
	`7628`	`+ }`
`7622`	`7629`	`}`
`7623`	`7630`	`}`
`7624`	`7631`	`}`