Feature: Recognize secret references in NGINX-specific annotations for `Ingress`

[dabico]

For an ingress definition like:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: example-ingress
  namespace: example
  annotations:
    cert-manager.io/cluster-issuer: "letsencrypt"
    nginx.ingress.kubernetes.io/auth-type: basic
    nginx.ingress.kubernetes.io/auth-secret: example-ingress-auth
    nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
spec:
  ingressClassName: nginx
  tls:
    - hosts: [] # Host names go here...
      secretName: example-ingress-tls
  rules: [] # Ingress rules go here...

example-ingress-tls is correctly recognized as a used secret, but the example-ingress-auth used in the ingress-nginx-specific annotation is not. It would be cool if kor would also check a pre-defined list of annotations for secret references (at least for ingresses).

[yonahd]

Hi @dabico I'm not sure we want to support this as nginx ingress is deprecated.
Also it puts the project in a complicated position to support all crd implementations

[dabico]

I'm not sure we want to support this as nginx ingress is deprecated

That's true, probably late by now to add support for it. You can close this ticket or reformulate it. I'll leave the choice up to you. Might just be enough to document it as a "false positive" or something along those line.