Skip to content

Feature (helm): add configuration options in values.yaml for all kor arguments #562

@sleeyax

Description

@sleeyax

Is your feature request related to a problem? Please describe.

Currently, it's possible to customize all kor parameters through the args value in values.yaml. It's great that this option exists, but if you have a lot of parameters to specify this isn't ergonomic:

--set "cronJob.args={pvc\,secret,--delete,--no-interactive,--include-namespaces=$PROJECT_NAME}" \

Also, another minor related issue: when cronJob.namespaced is specified, it overrides all the other args specified.

I think a decision should be made here to either opt for full customization of the parameters through values.yaml (preferred) or deprecate namespaced in favor of args.

Describe the solution you'd like

Add configuration options for each flag to values.yaml.

For example:

cronJob:
  resources: []
  delete: false
  excludeLabels: []
  excludeNamespaces: []
  groupBy: namespace
  ignoreOwnerReferences: false
  includeLabels: ""
  includeNamespaces: []
  kubeconfig: ""
  newerThan: ""
  noInteractive: false
  olderThan: ""
  output: table
  showReason: false
  slack:
    authToken: ""
    channel: ""
    webhookUrl: ""
  verbose: false

Describe alternatives you've considered

Specifying all the args as shown above works for now (as long as cronJob.namespaced is unspecified).

Additional context

/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions