chore: use strings.Contains and strings.ContainsRune instead strings.Index

testwill · testwill · commit e10bc75933e0 · 2024-03-16T10:42:23.000+08:00
Signed-off-by: guoguangwu &lt;guoguangwug@gmail.com&gt;
diff --git a/baselib.go b/baselib.go
@@ -410,7 +410,7 @@ func baseToNumber(L *LState) int {
 		L.Push(lv)
 	case LString:
 		str := strings.Trim(string(lv), " \n\t")
-		if strings.Index(str, ".") > -1 {
+		if strings.ContainsRune(str, '.') {
 			if v, err := strconv.ParseFloat(str, LNumberBit); err != nil {
 				L.Push(LNil)
 			} else {
diff --git a/parse/lexer.go b/parse/lexer.go
@@ -512,7 +512,7 @@ func dump(node interface{}, level int, s string) string {
 		tt := rt.Elem()
 		indicies := []int{}
 		for i := 0; i < tt.NumField(); i++ {
-			if strings.Index(tt.Field(i).Name, "Base") > -1 {
+			if strings.Contains(tt.Field(i).Name, "Base") {
 				continue
 			}
 			indicies = append(indicies, i)

Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ func dump(node interface{}, level int, s string) string {`
`512`	`512`	`tt := rt.Elem()`
`513`	`513`	`indicies := []int{}`
`514`	`514`	`for i := 0; i < tt.NumField(); i++ {`
`515`		`- if strings.Index(tt.Field(i).Name, "Base") > -1 {`
	`515`	`+ if strings.Contains(tt.Field(i).Name, "Base") {`
`516`	`516`	`continue`
`517`	`517`	`}`
`518`	`518`	`indicies = append(indicies, i)`