Conversation
Elegant macOS-inspired circular traffic light buttons for Zen Browser. Optimized for all layouts
with deep customization.
Signed-off-by: Rahul Pal <146630485+GoldLion123RP@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Zen Browser mod/theme (“Zen Traffic Lights”) to the theme-store repository, providing macOS-style circular window controls with user-configurable behavior via preferences.
Changes:
- Introduces a new theme folder with
chrome.cssimplementing the traffic-light UI and preference-driven variants. - Adds theme metadata (
theme.json) and preference definitions (preferences.json) for the store/mod settings UI. - Adds end-user documentation files (README, contributing, code of conduct) and a per-theme license file.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/theme.json | Declares theme metadata and asset pointers for store consumption. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/preferences.json | Defines toggles backing the CSS behavior. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/chrome.css | Implements traffic-light styling, hover modes, icons, and sizing/animation prefs. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/README.md | Provides installation and customization instructions. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/LICENSE | Adds a per-theme license file. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/CONTRIBUTING.md | Contributing guidelines for the theme. |
| themes/3ffef3a7-cdb7-40a0-9510-96f0db1b1536/CODE_OF_CONDUCT.md | Code of conduct for contributors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "style": "chrome.css", | ||
| "readme": "README.md", | ||
| "preferences": "preferences.json", | ||
| "image": "image.png", |
There was a problem hiding this comment.
In this repo, theme assets are referenced via raw.githubusercontent.com URLs (and the README filename is readme.md lowercase). Using relative paths (chrome.css, README.md, preferences.json, image.png) and the uppercase README name will likely break the theme-store tooling and consumers that expect the static asset URLs. Update these fields to the standard raw GitHub URLs and rename README.md to readme.md accordingly.
| "style": "chrome.css", | |
| "readme": "README.md", | |
| "preferences": "preferences.json", | |
| "image": "image.png", | |
| "style": "https://raw.githubusercontent.com/GoldLion123RP/zen-traffic-lights/main/chrome.css", | |
| "readme": "https://raw.githubusercontent.com/GoldLion123RP/zen-traffic-lights/main/readme.md", | |
| "preferences": "https://raw.githubusercontent.com/GoldLion123RP/zen-traffic-lights/main/preferences.json", | |
| "image": "https://raw.githubusercontent.com/GoldLion123RP/zen-traffic-lights/main/image.png", |
| { | ||
| "id": "3ffef3a7-cdb7-40a0-9510-96f0db1b1536", | ||
| "name": "Zen Traffic Lights", | ||
| "description": "Elegant macOS-inspired circular traffic light buttons for Zen Browser. Optimized for all sidebar and compact layouts with deep customization.", |
There was a problem hiding this comment.
description is 141 characters, but the theme submission script enforces a max length of 120 characters. Please shorten this string so automated validation passes.
| "description": "Elegant macOS-inspired circular traffic light buttons for Zen Browser. Optimized for all sidebar and compact layouts with deep customization.", | |
| "description": "Elegant macOS-inspired circular traffic light buttons for Zen Browser, optimized for sidebar and compact layouts.", |
| "id": "3ffef3a7-cdb7-40a0-9510-96f0db1b1536", | ||
| "name": "Zen Traffic Lights", |
There was a problem hiding this comment.
This theme ID is not present in the root themes.json index, so it won’t appear in the store listing. Add an entry for this theme (or run the repository’s rebuild/index script) so the new theme is discoverable.
| }, | ||
| { | ||
| "property": "mod.zen-traffic-lights.button_size_large", | ||
| "label": "Use Mid-Size Buttons", |
There was a problem hiding this comment.
The preference key mod.zen-traffic-lights.button_size_large doesn’t match the user-facing label "Use Mid-Size Buttons" (and the CSS increases size). This is confusing for users and future maintainers—either rename the preference to reflect the label (e.g., mid-size) or adjust the label to match what the setting actually does.
| "label": "Use Mid-Size Buttons", | |
| "label": "Use Large Buttons", |
| [](LICENSE) | ||
| [](https://zen-browser.app/mods/) |
There was a problem hiding this comment.
The MIT license badge/link implies this theme is MIT-licensed, but the repo policy is that all themes are licensed under CC BY-NC-SA 4.0. Please update/remove this badge/link to avoid a licensing conflict and user confusion.
| MIT License | ||
|
|
||
| Copyright (c) 2026 Rahul | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
There was a problem hiding this comment.
Adding an MIT LICENSE file here conflicts with this repository’s stated license policy for theme content (CC BY-NC-SA 4.0). Please remove this file or replace it with the correct CC BY-NC-SA 4.0 license text/notice used for themes in this repo.
| MIT License | |
| Copyright (c) 2026 Rahul | |
| Permission is hereby granted, free of charge, to any person obtaining a copy | |
| of this software and associated documentation files (the "Software"), to deal | |
| in the Software without restriction, including without limitation the rights | |
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | |
| copies of the Software, and to permit persons to whom the Software is | |
| furnished to do so, subject to the following conditions: | |
| The above copyright notice and this permission notice shall be included in all | |
| copies or substantial portions of the Software. | |
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | |
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | |
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | |
| SOFTWARE. | |
| Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International | |
| Copyright (c) 2026 Rahul | |
| This theme is licensed under the Creative Commons | |
| Attribution-NonCommercial-ShareAlike 4.0 International License. | |
| You are free to: | |
| - Share — copy and redistribute the material in any medium or format | |
| - Adapt — remix, transform, and build upon the material | |
| Under the following terms: | |
| - Attribution — You must give appropriate credit, provide a link to the | |
| license, and indicate if changes were made. | |
| - NonCommercial — You may not use the material for commercial purposes. | |
| - ShareAlike — If you remix, transform, or build upon the material, you | |
| must distribute your contributions under the same license as the original. | |
| - No additional restrictions — You may not apply legal terms or | |
| technological measures that legally restrict others from doing anything | |
| the license permits. | |
| To view a copy of this license, visit: | |
| https://creativecommons.org/licenses/by-nc-sa/4.0/ |
| ## 📜 License | ||
| This project is licensed under the **MIT License**. | ||
|
|
There was a problem hiding this comment.
This license section says the project is under MIT, which conflicts with the repository’s policy that theme content is CC BY-NC-SA 4.0. Please update this section to match the repo theme license (or remove per-theme licensing claims).
Elegant macOS-inspired circular traffic light buttons for Zen Browser. Optimized for all layouts with deep customization.