Skip to content

Commit 59bff93

Browse files
committed
fix: headings markup
1 parent 958e10c commit 59bff93

File tree

7 files changed

+30
-38
lines changed

7 files changed

+30
-38
lines changed

src/components/Features.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const descriptions = Object.values(features.featureTabs).map(tab => tab.descript
2020
---
2121

2222
<section id="features" class="relative flex w-full flex-col py-12 text-start lg:py-36">
23-
<Description class="mb-2 text-4xl font-bold sm:text-6xl">
23+
<h2 class="mb-2 text-4xl font-bold sm:text-6xl">
2424
{
2525
(titles || features.titles).map((title, index) =>
2626
title !== '\n' ? (
@@ -32,7 +32,7 @@ const descriptions = Object.values(features.featureTabs).map(tab => tab.descript
3232
)
3333
)
3434
}
35-
</Description>
35+
</h2>
3636

3737
<p class="feature-description-text opacity-0 lg:w-1/2">
3838
{features.description}
@@ -66,7 +66,7 @@ const descriptions = Object.values(features.featureTabs).map(tab => tab.descript
6666
data-feature-key={key}
6767
data-active={i === 0 ? 'true' : undefined}
6868
>
69-
<Description class="text-2xl font-bold">{tab.title}</Description>
69+
<h3 class="text-2xl font-bold">{tab.title}</h3>
7070
<Description>{tab.description}</Description>
7171
</div>
7272
))

src/components/Footer.astro

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
import Button from '~/components/Button.astro'
33
import Circles from '~/components/Circles.astro'
4-
import Description from '~/components/Description.astro'
54
import SocialMediaStrip from '~/components/SocialMediaStrip.astro'
65
import ArrowRightIcon from '~/icons/ArrowRightIcon.astro'
76
import { getLocale, getPath, getUI } from '~/utils/i18n'
@@ -24,14 +23,13 @@ const {
2423
class="flex w-full flex-col gap-4 text-center lg:w-1/2 lg:text-left"
2524
aria-labelledby="footer-title"
2625
>
27-
<a href="/">
28-
<Description id="footer-title" class="text-6xl font-bold !text-paper"
29-
>{footer.title}</Description
30-
>
31-
</a>
32-
<Description class="mx-auto max-w-xl lg:mx-0">
26+
<h2 id="footer-title" class="text-6xl font-bold !text-paper">
27+
<a href="/">{footer.title}</a>
28+
</h2>
29+
30+
<p class="mx-auto max-w-xl lg:mx-0">
3331
{footer.description}
34-
</Description>
32+
</p>
3533
</section>
3634
<section class="grid gap-10 place-self-center lg:place-self-start">
3735
<Button
@@ -54,15 +52,15 @@ const {
5452
class="flex flex-col items-center gap-2 sm:items-start"
5553
aria-labelledby="follow-us-heading"
5654
>
57-
<h2 id="follow-us-heading" class="text-base !font-semibold">
55+
<h3 id="follow-us-heading" class="text-base !font-semibold">
5856
{footer.followUs}
59-
</h2>
57+
</h3>
6058
<SocialMediaStrip />
6159
</section>
6260
<section class="flex flex-col gap-2" aria-labelledby="about-us-heading">
63-
<h2 id="about-us-heading" class="text-base !font-semibold">
61+
<h3 id="about-us-heading" class="text-base !font-semibold">
6462
{footer.aboutUs}
65-
</h2>
63+
</h3>
6664
<nav aria-label="About navigation">
6765
<ul class="grid gap-2 opacity-80">
6866
<li>
@@ -80,9 +78,9 @@ const {
8078
</section>
8179
</div>
8280
<nav class="flex flex-col gap-2" aria-labelledby="get-started-heading">
83-
<h2 id="get-started-heading" class="text-base !font-semibold">
81+
<h3 id="get-started-heading" class="text-base !font-semibold">
8482
{footer.getStarted}
85-
</h2>
83+
</h3>
8684
<ul class="grid gap-2 opacity-80">
8785
<li>
8886
<a href="https://docs.zen-browser.app/" class="font-normal">{footer.documentation}</a>
@@ -101,9 +99,9 @@ const {
10199
</ul>
102100
</nav>
103101
<nav class="flex flex-col gap-2" aria-labelledby="get-help-heading">
104-
<h2 id="get-help-heading" class="text-base !font-semibold">
102+
<h3 id="get-help-heading" class="text-base !font-semibold">
105103
{footer.getHelp}
106-
</h2>
104+
</h3>
107105
<ul class="grid gap-2 opacity-80">
108106
<li>
109107
<a href="https://discord.gg/zen-browser" class="font-normal">{footer.discord}</a>

src/components/Sponsors.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ const {
1919
<section id="sponsors" class:list={['py-12', !showSponsors && 'hidden']}>
2020
<div class="grid items-center gap-8 text-center">
2121
<div class="grid gap-2">
22-
<h3
22+
<h2
2323
class="text-4xl font-bold sm:text-6xl"
2424
style="transform: translateY(20px); opacity: 0.001; filter: blur(4px)"
2525
>
2626
{sponsors.title}
27-
</h3>
27+
</h2>
2828
<p class="text-base" style="transform: translateY(20px); opacity: 0.001; filter: blur(4px)">
2929
<span class="opacity-80" set:html={sponsors.description} />
3030
</p>
@@ -74,7 +74,7 @@ const {
7474
const debug = false
7575

7676
const elements = document.querySelectorAll(
77-
'#sponsors h3, #sponsors p, #sponsors .sponsors__sponsor a'
77+
'#sponsors h2, #sponsors p, #sponsors .sponsors__sponsor a'
7878
)
7979

8080
animate(elements, {

src/pages/[...locale]/about.astro

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
---
22
import { Image } from 'astro:assets'
3+
import Button from '~/components/Button.astro'
34
import Description from '~/components/Description.astro'
45
import Layout from '~/layouts/Layout.astro'
56
import { getLocale, getUI } from '~/utils/i18n'
67
export { getStaticPaths } from '~/utils/i18n'
7-
import Button from '~/components/Button.astro'
88
99
const locale = getLocale(Astro)
1010
@@ -17,24 +17,24 @@ const {
1717
<Layout title={layout.about.title} description={layout.about.description}>
1818
<main class="container flex min-h-screen w-full flex-col gap-24 py-24">
1919
<div class="flex w-full flex-col gap-6">
20-
<Description class="text-6xl font-bold leading-none">{about.title}</Description>
20+
<h1 class="text-6xl font-bold leading-none">{about.title}</h1>
2121
<Description class="max-w-4xl">
2222
{about.description}
2323
</Description>
2424
<Button href="/donate" class="w-fit" isPrimary>{about.littleHelp}</Button>
2525
</div>
2626
<div class="flex w-full flex-col gap-4">
27-
<div class="text-4xl font-bold leading-none lg:text-5xl">{about.mainTeam.title}</div>
27+
<h2 class="text-4xl font-bold leading-none lg:text-5xl">{about.mainTeam.title}</h2>
2828
<Description>
2929
{about.mainTeam.description}
3030
</Description>
3131
<div class="flex flex-col gap-6">
3232
{
3333
Object.entries(about.mainTeam.members).map(([team, members]) => (
3434
<div class="flex flex-col gap-2">
35-
<div class="text-3xl font-semibold">
35+
<h3 class="text-3xl font-semibold">
3636
{about.mainTeam.subTitle[team as keyof typeof about.mainTeam.subTitle]}
37-
</div>
37+
</h3>
3838
<ul class="flex flex-col gap-2">
3939
{Object.entries(members).map(([_key, member]) => (
4040
<li class="text-sm">
@@ -55,14 +55,12 @@ const {
5555
</div>
5656
</div>
5757
<div class="flex w-full flex-col gap-4">
58-
<div class="text-4xl font-bold leading-none lg:text-5xl">{about.contributors.title}</div>
58+
<h2 class="text-4xl font-bold leading-none lg:text-5xl">{about.contributors.title}</h2>
5959
<Description>
6060
{about.contributors.description}
6161
</Description>
6262
<div class="flex w-fit flex-col gap-4">
63-
<Description class="text-3xl font-semibold lg:text-4xl"
64-
>{about.contributors.browser}</Description
65-
>
63+
<h3 class="text-3xl font-semibold lg:text-4xl">{about.contributors.browser}</h3>
6664
<a href="https://github.com/zen-browser/desktop/graphs/contributors"
6765
><Image
6866
src="https://contributors-img.web.app/image?repo=zen-browser/desktop"
@@ -73,9 +71,7 @@ const {
7371
>
7472
</div>
7573
<div class="flex w-fit flex-col gap-4">
76-
<Description class="text-3xl font-semibold lg:text-4xl"
77-
>{about.contributors.website}</Description
78-
>
74+
<h3 class="text-3xl font-semibold lg:text-4xl">{about.contributors.website}</h3>
7975
<a href="https://github.com/zen-browser/www/graphs/contributors"
8076
><Image
8177
src="https://contributors-img.web.app/image?repo=zen-browser/www"

src/pages/[...locale]/index.astro

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,3 @@ const { layout } = getUI(locale)
3434
animation: headerSlideIn 0.5s ease-in-out;
3535
}
3636
</style>
37-
<script></script>

src/pages/[...locale]/mods/index.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const allMods = (await getAllMods()) || []
2020
<Layout title={layout.mods.title}>
2121
<main class="container mt-32 flex flex-col gap-10 2xl:mt-32">
2222
<header class="flex w-full flex-col gap-8 border-dark">
23-
<Description class="text-6xl font-bold">{mods.title}</Description>
23+
<h1 class="text-6xl font-bold">{mods.title}</h1>
2424
<Description class="max-w-3xl">
2525
{mods.description}
2626
</Description>

src/pages/[...locale]/release-notes/index.astro

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
import { Modal, ModalBody, ModalHeader } from 'free-astro-components'
33
import Button from '~/components/Button.astro'
4-
import Description from '~/components/Description.astro'
54
import ReleaseNoteItem from '~/components/ReleaseNoteItem.astro'
65
import ArrowUpIcon from '~/icons/ArrowUp.astro'
76
import Layout from '~/layouts/Layout.astro'
@@ -22,7 +21,7 @@ const {
2221
class="container flex h-full min-h-[1000px] flex-1 flex-col items-center justify-center py-4"
2322
>
2423
<div id="release-notes" class="py-42 flex min-h-screen w-full flex-col justify-center gap-8">
25-
<Description class="mt-48 text-6xl font-bold">{releaseNotes.topSection.title}</Description>
24+
<h1 class="mt-48 text-6xl font-bold">{releaseNotes.topSection.title}</h1>
2625
<p
2726
class="text-base opacity-55"
2827
set:html={releaseNotes.topSection.description.replaceAll(

0 commit comments

Comments
 (0)