Refactored ReachedFinalHandlerException to use named constructor

Author: asgrim

src/Exception/ReachedFinalHandlerException.php

@@ -11,4 +11,11 @@
 
 class ReachedFinalHandlerException extends RuntimeException
 {
+    /**
+     * @return self
+     */
+    public static function create()
+    {
+        return new self('Reached the final handler for middleware pipe - check the pipe configuration');
+    }
 }

src/MiddlewareListener.php

@@ -84,9 +84,7 @@ public function onDispatch(MvcEvent $event)
                 $psr7Request,
                 $psr7ResponsePrototype,
                 function (PsrServerRequestInterface $request, PsrResponseInterface $response) {
-                    throw new ReachedFinalHandlerException(
-                        'Reached the final handler for middleware pipe - check the pipe configuration'
-                    );
+                    throw ReachedFinalHandlerException::create();
                 }
             );
         } catch (\Throwable $ex) {

test/Exception/MiddlewareNotCallableExceptionTest.php

@@ -3,7 +3,7 @@
  * Zend Framework (http://framework.zend.com/)
  *
  * @link      http://github.com/zendframework/zf2 for the canonical source repository
- * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com)
+ * @copyright Copyright (c) 2005-2017 Zend Technologies USA Inc. (http://www.zend.com)
  * @license   http://framework.zend.com/license/new-bsd New BSD License
  */
 

test/Exception/ReachedFinalHandlerExceptionTest.php

@@ -0,0 +1,27 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link      http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2017 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace ZendTest\Mvc;
+
+use PHPUnit_Framework_TestCase as TestCase;
+use Zend\Mvc\Exception\ReachedFinalHandlerException;
+
+final class ReachedFinalHandlerExceptionTest extends TestCase
+{
+    public function testFromNothing()
+    {
+        $exception = ReachedFinalHandlerException::create();
+
+        $this->assertInstanceOf(ReachedFinalHandlerException::class, $exception);
+        $this->assertSame(
+            'Reached the final handler for middleware pipe - check the pipe configuration',
+            $exception->getMessage()
+        );
+    }
+}