Actually support Symfony 8 #1022
Merged
+453
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Nov 2, 2025
| "phpstan/phpstan-doctrine": "^2.0", | ||
| "phpstan/phpstan-phpunit": "^2.0" | ||
| "phpstan/phpstan-phpunit": "^2.0", | ||
| "symfony/var-exporter": "^7" |
Member
Author
There was a problem hiding this comment.
phpstan doctrine still needs var-exporter 7
nikophil
commented
Nov 2, 2025
nikophil
commented
Nov 2, 2025
Comment on lines
110
to
113
| if (!TestKernel::canUseLegacyProxy()) { | ||
| yield []; | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
this is currently mandatory in order to still be able to test proxies in data providers
I think I will start working on Foundry 3 very soon because I can't stand this complexity in the tests anymore
nikophil
commented
Nov 2, 2025
Comment on lines
27
to
30
| public static function setUpBeforeClass(): void | ||
| { | ||
| self::markTestSkipped(); | ||
| } |
nikophil
commented
Nov 2, 2025
nikophil
commented
Nov 2, 2025
| See https://github.com/zenstruck/foundry/blob/2.x/UPGRADE-2.7.md to upgrade.]]></issue> | ||
|
|
||
| <issue><![CDATA[Support for MySQL < 8 is deprecated and will be removed in DBAL 5 (AbstractMySQLDriver.php:75 called by AbstractDriverMiddleware.php:32, https://github.com/doctrine/dbal/pull/6343, package doctrine/dbal)]]></issue> | ||
| <issue><![CDATA[Since doctrine/doctrine-bundle 3.1: The "auto_mapping" option is deprecated and will be removed in DoctrineBundle 4.0, as it only accepts `false` since 3.0.]]></issue> |
Member
Author
There was a problem hiding this comment.
can't make disappear this deprec... I think there is a problem in Doctrine bundle
nikophil
force-pushed
the
chore/sf-8
branch
9 times, most recently
from
9175aea to
3b4889a
Compare
Contributor
|
Thanks @nikophil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to support SF 8 in Foundry 2, we'd need to throw an exception when using
ProxyPersistentObjectFactoryBTW, Doctrine ORM still not support SF 8