fix remote denial of service #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I nickname this the Lalufu exploit: Tweets by special nicknames like '__indexes', '__windows' and so on will corrupt internal data structures and most likely result in a "Not an ARRAY reference" error and crash the whole twirssi.pl script. Subsequent restarts of the script (if the crash is noticed in the first place) will most likely result in another crash as the offending tweet will most likely be downloaded again. It is trivial to register one of these usernames and with a single tweet containing the #twirssi hashtag, it is possible to crash many twirssi instances netwide at once as twirssi users are likely to follow the #twirssi hashtag. The fix is rather simple and blunt: it blackholes any tweets coming from those nicks. In the long run, the internal $state reprensentation should be refactored.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special nicks can crash irssi, for details see the commit log entry.
Should be fixed before somebody actually exploits this :-)