filter searches and subscriptions by blocked accounts #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regularly poll the list of blocked accounts and filter search and subscription results by this list. This is a very close copy of the friends list handling.
Only the block list for the current account was read. This has been changed to querying all accounts for their block lists. Every block applies globally, e.g. it filters results from _any_ account. Seems reasonable to me because I use blocks to remove unwanted results (spammers etc.) and these results don't become wanted just because another account stumbles upon them.
Gedge found out that Twitter does not honor the page attribute to the blocks/blocking method which makes us download the same block list 10 times for every account. Talk about The Big Freeze on startup...
The existing twitter_friends_poll setting is used for both friends and blocks.
This should fix a case-related bug that seems to pop up sometime (don't know why, though). Account names are case insensitive so using all lowercase can't hurt.
As Gedge pointed out, $settings{blocks_poll} does not exist. Use
$settings{friends_poll} instead, as documented in html/using.html.
I don't see much sense in polling the friends and blocks lists at
different intervals, so just use the same setting for both lists for
now.
Collaborator
|
this is implemented in latest beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't show tweets from blocked accounts in search results and in subscriptions