Refactor extensions to not use closures to reduce GC allocations

Author: adamgraham

Runtime/Delegates.cs

@@ -1,28 +1,27 @@
 namespace Zigurous.Tweening
 {
     /// <summary>
-    /// A function delegate that gets the current value of a parameter from a
-    /// source object.
+    /// A function delegate that gets the current value of a parameter from an
+    /// object.
     /// </summary>
-    /// <typeparam name="S">The type of the source object.</typeparam>
-    /// <typeparam name="T">The type of the parameter.</typeparam>
-    /// <param name="source">The source object to get the value from.</param>
+    /// <typeparam name="T">The type of object to get the parameter from.</typeparam>
+    /// <typeparam name="U">The type of the parameter.</typeparam>
+    /// <param name="target">The object to get the value from.</param>
     /// <returns>The current value of the parameter.</returns>
-    public delegate T TweenGetter<S,T>(S source);
+    public delegate U TweenGetter<T,U>(T target);
 
     /// <summary>
-    /// A function delegate that sets a new value of a parameter on a source
-    /// object.
+    /// A function delegate that sets a new value of a parameter on an object.
     /// </summary>
-    /// <typeparam name="S">The type of the source object.</typeparam>
-    /// <typeparam name="T">The type of the parameter.</typeparam>
-    /// <param name="source">The source object to set the value on.</param>
+    /// <typeparam name="T">The type of object to set the parameter on.</typeparam>
+    /// <typeparam name="U">The type of the parameter.</typeparam>
+    /// <param name="target">The object to set the value on.</param>
     /// <param name="value">The new value of the parameter.</param>
-    public delegate void TweenSetter<S,T>(S source, T value);
+    public delegate void TweenSetter<T,U>(T target, U value);
 
     /// <summary>
     /// A function delegate that can be invoked during various tween events
-    /// and/or state changes.
+    /// and/or state changes, such as on complete.
     /// </summary>
     public delegate void TweenCallback();
 

Runtime/Extensions/Audio/AudioChorusFilterTweens.cs

@@ -5,32 +5,32 @@ namespace Zigurous.Tweening
     public static class AudioChorusFilterTweens
     {
         public static Tween TweenDelay(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.delay, (source, value) => source.delay = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.delay, (target, value) => target.delay = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenRate(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.rate, (source, value) => source.rate = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.rate, (target, value) => target.rate = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDepth(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.depth, (source, value) => source.depth = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.depth, (target, value) => target.depth = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDryMix(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.dryMix, (source, value) => source.dryMix = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.dryMix, (target, value) => target.dryMix = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenWetMix1(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.wetMix1, (source, value) => source.wetMix1 = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.wetMix1, (target, value) => target.wetMix1 = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenWetMix2(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.wetMix2, (source, value) => source.wetMix2 = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.wetMix2, (target, value) => target.wetMix2 = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenWetMix3(this AudioChorusFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.wetMix3, (source, value) => source.wetMix3 = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.wetMix3, (target, value) => target.wetMix3 = value, to, duration)
+                    .SetReference(filter);
     }
 
 }

Runtime/Extensions/Audio/AudioDistortionFilterTweens.cs

@@ -5,8 +5,8 @@ namespace Zigurous.Tweening
     public static class AudioDistortionFilterTweens
     {
         public static Tween TweenDistortionLevel(this AudioDistortionFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.distortionLevel, (source, value) => source.distortionLevel = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.distortionLevel, (target, value) => target.distortionLevel = value, to, duration)
+                    .SetReference(filter);
     }
 
 }

Runtime/Extensions/Audio/AudioEchoFilterTweens.cs

@@ -5,20 +5,20 @@ namespace Zigurous.Tweening
     public static class AudioEchoFilterTweens
     {
         public static Tween TweenDelay(this AudioEchoFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.delay, (source, value) => source.delay = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.delay, (target, value) => target.delay = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDecayRatio(this AudioEchoFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.decayRatio, (source, value) => source.decayRatio = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.decayRatio, (target, value) => target.decayRatio = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDryMix(this AudioEchoFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.dryMix, (source, value) => source.dryMix = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.dryMix, (target, value) => target.dryMix = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenWetMix(this AudioEchoFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.wetMix, (source, value) => source.wetMix = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.wetMix, (target, value) => target.wetMix = value, to, duration)
+                    .SetReference(filter);
     }
 
 }

Runtime/Extensions/Audio/AudioHighPassFilterTweens.cs

@@ -5,12 +5,12 @@ namespace Zigurous.Tweening
     public static class AudioHighPassFilterTweens
     {
         public static Tween TweenCutoffFrequency(this AudioHighPassFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.cutoffFrequency, (source, value) => source.cutoffFrequency = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.cutoffFrequency, (target, value) => target.cutoffFrequency = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenHighpassResonanceQ(this AudioHighPassFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.highpassResonanceQ, (source, value) => source.highpassResonanceQ = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.highpassResonanceQ, (target, value) => target.highpassResonanceQ = value, to, duration)
+                    .SetReference(filter);
     }
 
 }

Runtime/Extensions/Audio/AudioListenerTweens.cs

@@ -6,7 +6,7 @@ public static class AudioListenerTweens
     {
         public static Tween TweenVolume(this AudioListener listener, float to, float duration) =>
             Tweening.To(listener, (source) => AudioListener.volume, (source, value) => AudioListener.volume = value, to, duration)
-                    .SetTarget(listener);
+                    .SetReference(listener);
     }
 
 }

Runtime/Extensions/Audio/AudioLowPassFilterTweens.cs

@@ -5,12 +5,12 @@ namespace Zigurous.Tweening
     public static class AudioLowPassFilterTweens
     {
         public static Tween TweenCutoffFrequency(this AudioLowPassFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.cutoffFrequency, (source, value) => source.cutoffFrequency = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.cutoffFrequency, (target, value) => target.cutoffFrequency = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenLowpassResonanceQ(this AudioLowPassFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.lowpassResonanceQ, (source, value) => source.lowpassResonanceQ = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.lowpassResonanceQ, (target, value) => target.lowpassResonanceQ = value, to, duration)
+                    .SetReference(filter);
     }
 
 }

Runtime/Extensions/Audio/AudioReverbFilterTweens.cs

@@ -5,60 +5,60 @@ namespace Zigurous.Tweening
     public static class AudioReverbFilterTweens
     {
         public static Tween TweenDensity(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.density, (source, value) => source.density = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.density, (target, value) => target.density = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDiffusion(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.diffusion, (source, value) => source.diffusion = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.diffusion, (target, value) => target.diffusion = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenReverbDelay(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.reverbDelay, (source, value) => source.reverbDelay = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.reverbDelay, (target, value) => target.reverbDelay = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenReverbLevel(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.reverbLevel, (source, value) => source.reverbLevel = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.reverbLevel, (target, value) => target.reverbLevel = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenReflectionsDelay(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.reflectionsDelay, (source, value) => source.reflectionsDelay = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.reflectionsDelay, (target, value) => target.reflectionsDelay = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenReflectionsLevel(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.reflectionsLevel, (source, value) => source.reflectionsLevel = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.reflectionsLevel, (target, value) => target.reflectionsLevel = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDecayHFRatio(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.decayHFRatio, (source, value) => source.decayHFRatio = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.decayHFRatio, (target, value) => target.decayHFRatio = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDecayTime(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.decayTime, (source, value) => source.decayTime = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.decayTime, (target, value) => target.decayTime = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenRoom(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.room, (source, value) => source.room = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.room, (target, value) => target.room = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenRoomHF(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.roomHF, (source, value) => source.roomHF = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.roomHF, (target, value) => target.roomHF = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenRoomLF(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.roomLF, (source, value) => source.roomLF = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.roomLF, (target, value) => target.roomLF = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenDryLevel(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.dryLevel, (source, value) => source.dryLevel = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.dryLevel, (target, value) => target.dryLevel = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenHFReference(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.hfReference, (source, value) => source.hfReference = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.hfReference, (target, value) => target.hfReference = value, to, duration)
+                    .SetReference(filter);
 
         public static Tween TweenLFReference(this AudioReverbFilter filter, float to, float duration) =>
-            Tweening.To(filter, (source) => source.lfReference, (source, value) => source.lfReference = value, to, duration)
-                    .SetTarget(filter);
+            Tweening.To(filter, (target) => target.lfReference, (target, value) => target.lfReference = value, to, duration)
+                    .SetReference(filter);
     }
 
 }