Remove unnecessary extra transition methods

Author: adamgraham

Runtime/Tween.cs

@@ -195,80 +195,12 @@ internal void Update(float deltaTime)
         /// </summary>
         public void Play()
         {
-            if (this.state.CanTransition(TweenState.Playing)) {
-                TransitionToPlaying(this.state);
+            if (!this.state.CanTransition(TweenState.Playing)) {
+                return;
             }
-        }
-
-        /// <summary>
-        /// Stops the tween if currently being played.
-        /// </summary>
-        public void Stop()
-        {
-            if (this.state.CanTransition(TweenState.Stopped)) {
-                TransitionToStopped();
-            }
-        }
-
-        /// <summary>
-        /// Completes the tween, jumping to the end value.
-        /// </summary>
-        public void Complete()
-        {
-            if (this.state.CanTransition(TweenState.Complete)) {
-                TransitionToComplete();
-            }
-        }
 
-        /// <summary>
-        /// Kills the tween in its place, preventing any further state changes
-        /// or changes to the parameter being animated.
-        /// </summary>
-        public void Kill()
-        {
-            if (this.state.CanTransition(TweenState.Killed)) {
-                TransitionToKilled();
-            }
-        }
+            TweenState previousState = this.state;
 
-        /// <summary>
-        /// Restarts the tween as along as it has not been killed.
-        /// </summary>
-        public void Restart()
-        {
-            Stop();
-            Play();
-        }
-
-        /// <summary>
-        /// Resets all properties of the tween back to their default values.
-        /// </summary>
-        internal void Reset()
-        {
-            this.id = -1;
-            this.state = TweenState.Ready;
-            this.internalState = InternalTweenState.Queued;
-            this.ease = Settings.defaultEase;
-            this.duration = Settings.defaultDuration;
-            this.elapsed = 0.0f;
-            this.delay = Settings.defaultDelay;
-            this.delayElapsed = 0.0f;
-            this.reversed = false;
-            this.autoStart = Settings.defaultAutoStart;
-            this.autoKill = Settings.defaultAutoKill;
-            this.recyclable = Settings.defaultRecyclable;
-
-            this.onUpdate = null;
-            this.onStart = null;
-            this.onStop = null;
-            this.onComplete = null;
-            this.onKill = null;
-
-            OnReset();
-        }
-
-        private void TransitionToPlaying(TweenState previousState)
-        {
             this.state = TweenState.Playing;
             this.internalState = InternalTweenState.Active;
 
@@ -290,8 +222,15 @@ private void TransitionToPlaying(TweenState previousState)
             }
         }
 
-        private void TransitionToStopped()
+        /// <summary>
+        /// Stops the tween if currently being played.
+        /// </summary>
+        public void Stop()
         {
+            if (!this.state.CanTransition(TweenState.Stopped)) {
+                return;
+            }
+
             this.state = TweenState.Stopped;
 
             OnStop();
@@ -301,8 +240,15 @@ private void TransitionToStopped()
             }
         }
 
-        private void TransitionToComplete()
+        /// <summary>
+        /// Completes the tween, jumping to the end value.
+        /// </summary>
+        public void Complete()
         {
+            if (!this.state.CanTransition(TweenState.Complete)) {
+                return;
+            }
+
             this.state = TweenState.Complete;
             this.elapsed = this.duration;
             this.delayElapsed = this.delay;
@@ -319,8 +265,16 @@ private void TransitionToComplete()
             }
         }
 
-        private void TransitionToKilled()
+        /// <summary>
+        /// Kills the tween in its place, preventing any further state changes
+        /// or changes to the parameter being animated.
+        /// </summary>
+        public void Kill()
         {
+            if (!this.state.CanTransition(TweenState.Killed)) {
+                return;
+            }
+
             this.state = TweenState.Killed;
             this.internalState = InternalTweenState.Dequeued;
 
@@ -337,6 +291,42 @@ private void TransitionToKilled()
             this.onComplete = null;
         }
 
+        /// <summary>
+        /// Restarts the tween as along as it has not been killed.
+        /// </summary>
+        public void Restart()
+        {
+            Stop();
+            Play();
+        }
+
+        /// <summary>
+        /// Resets all properties of the tween back to their default values.
+        /// </summary>
+        internal void Reset()
+        {
+            this.id = -1;
+            this.state = TweenState.Ready;
+            this.internalState = InternalTweenState.Queued;
+            this.ease = Settings.defaultEase;
+            this.duration = Settings.defaultDuration;
+            this.elapsed = 0.0f;
+            this.delay = Settings.defaultDelay;
+            this.delayElapsed = 0.0f;
+            this.reversed = false;
+            this.autoStart = Settings.defaultAutoStart;
+            this.autoKill = Settings.defaultAutoKill;
+            this.recyclable = Settings.defaultRecyclable;
+
+            this.onUpdate = null;
+            this.onStart = null;
+            this.onStop = null;
+            this.onComplete = null;
+            this.onKill = null;
+
+            OnReset();
+        }
+
         protected virtual void OnUpdate() {}
         protected virtual void OnStart() {}
         protected virtual void OnStop() {}