Skip to content

Spans and LogAnnotations are not Propagating to Third Party Libraries Using SLF4J #925

@khajavi

Description

@khajavi
//> using scala 2.13.15
//> using dep dev.zio::zio:2.1.14
//> using dep dev.zio::zio-logging:2.4.0
//> using dep dev.zio::zio-logging-slf4j2:2.4.0
//> using dep org.slf4j:slf4j-simple:2.0.16

import my.lib.foo._
import zio._
import zio.logging.LogFormat
import zio.logging.backend.SLF4J
import zio.logging.backend.SLF4J.logFormatDefault

object MainApp extends ZIOAppDefault {
  override val bootstrap =
    Runtime.removeDefaultLoggers >>> SLF4J.slf4j(logFormatDefault |-| LogFormat.spans)

  override def run = {
    ZIO.logSpan("my-span") {
      ZIO.logAnnotate("foo", "bar") {
        for {
          _ <- ZIO.logInfo("App started!")
          _ <- ZIO.attempt(doSomething())
          _ <- ZIO.logInfo("App finished!")
        } yield ()
      }
    }
  }
}

package my.lib {

  import org.slf4j.LoggerFactory

  object foo {
    private val logger = LoggerFactory.getLogger("lib.foo")

    def doSomething() =
      logger.info("Doing something!")
  }
}

// Output:
// [ZScheduler-Worker-7] INFO <empty>.MainApp - foo=bar my-span=8ms App started!
// [ZScheduler-Worker-7] INFO lib.foo - Doing something!
// [ZScheduler-Worker-7] INFO <empty>.MainApp - foo=bar my-span=12ms App finished!

// Example of Expected Output:
// [ZScheduler-Worker-7] INFO <empty>.MainApp - foo=bar my-span=8ms App started!
// [ZScheduler-Worker-7] INFO lib.foo - foo=bar my-span=10ms Doing something!
// [ZScheduler-Worker-7] INFO <empty>.MainApp - foo=bar my-span=12ms App finished!

Do you have any idea what is the problem?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions