From 1cf70a1a5639278f61c8058ee04879add722b586 Mon Sep 17 00:00:00 2001 From: "Christian S." Date: Tue, 11 Nov 2025 12:53:23 +0100 Subject: [PATCH 1/3] Add correct type hinting for list_rules --- zscaler/zia/cloud_firewall_dns.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zscaler/zia/cloud_firewall_dns.py b/zscaler/zia/cloud_firewall_dns.py index 49724f6b..ba078500 100644 --- a/zscaler/zia/cloud_firewall_dns.py +++ b/zscaler/zia/cloud_firewall_dns.py @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None: def list_rules( self, query_params: Optional[dict] = None, - ) -> APIResult[dict]: + ) -> APIResult[List[FirewallDNSRules]]: """ List firewall dns rules in your organization. If the `search` parameter is provided, the function filters the rules client-side. From eb1d0075d3c2a8603c662061c3bd02bfe44f9bbc Mon Sep 17 00:00:00 2001 From: "Christian S." Date: Tue, 11 Nov 2025 12:59:39 +0100 Subject: [PATCH 2/3] Update return type of list_rules method Change return type of list_rules method to return a list of FirewallRule objects. --- zscaler/zia/cloud_firewall_rules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zscaler/zia/cloud_firewall_rules.py b/zscaler/zia/cloud_firewall_rules.py index 5b6f4b54..eb043588 100644 --- a/zscaler/zia/cloud_firewall_rules.py +++ b/zscaler/zia/cloud_firewall_rules.py @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None: def list_rules( self, query_params: Optional[dict] = None, - ) -> APIResult[dict]: + ) -> APIResult[List[FirewallRule]]: """ List firewall rules in your organization. If the `search` parameter is provided, the function filters the rules client-side. From b740b6afb4cc6705620d0196ed181f50b566583a Mon Sep 17 00:00:00 2001 From: "Christian S." Date: Tue, 11 Nov 2025 13:02:16 +0100 Subject: [PATCH 3/3] Change return type of list_rules to APIResult[List[FirewallIPSrules]] --- zscaler/zia/cloud_firewall_ips.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zscaler/zia/cloud_firewall_ips.py b/zscaler/zia/cloud_firewall_ips.py index ebcb5986..d5f2ab84 100644 --- a/zscaler/zia/cloud_firewall_ips.py +++ b/zscaler/zia/cloud_firewall_ips.py @@ -33,7 +33,7 @@ def __init__(self, request_executor: "RequestExecutor") -> None: def list_rules( self, query_params: Optional[dict] = None, - ) -> APIResult[dict]: + ) -> APIResult[List[FirewallIPSrules]]: """ List firewall ips rules in your organization. If the `search` parameter is provided, the function filters the rules client-side.