Skip to content

Commit 0b5f728

Browse files
committed
login test [nfc]: Pull out an attempt helper in AddAccountPage test
1 parent 0b07032 commit 0b5f728

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

test/widgets/login_test.dart

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,20 +98,24 @@ void main() {
9898
await testNavObserver.pumpPastTransition(tester);
9999
}
100100

101-
testWidgets('happy path', (tester) async {
102-
await prepare(tester);
103-
104-
final serverSettings = eg.serverSettings();
105-
106-
await tester.enterText(find.byType(TextField),
107-
serverSettings.realmUrl.toString());
101+
Future<void> attempt(WidgetTester tester,
102+
Uri realmUrl, Map<String, Object?> responseJson) async {
103+
await tester.enterText(find.byType(TextField), realmUrl.toString());
108104
testBinding.globalStore.useCachedApiConnections = true;
109105
connection = testBinding.globalStore.apiConnection(
110-
realmUrl: serverSettings.realmUrl,
106+
realmUrl: realmUrl,
111107
zulipFeatureLevel: null);
112-
connection.prepare(json: serverSettings.toJson());
108+
connection.prepare(json: responseJson);
113109
await tester.tap(find.text('Continue'));
114110
await tester.pump(Duration.zero);
111+
}
112+
113+
testWidgets('happy path', (tester) async {
114+
await prepare(tester);
115+
116+
final serverSettings = eg.serverSettings();
117+
118+
await attempt(tester, serverSettings.realmUrl, serverSettings.toJson());
115119
checkNoDialog(tester);
116120
check(takePushedRoutes()).single.isA<WidgetRoute>().page.isA<LoginPage>()
117121
.serverSettings.realmUrl.equals(serverSettings.realmUrl);

0 commit comments

Comments
 (0)