feat: ERC20TransferableReceivable contract gas optimizations#10
Open
mliu wants to merge 17 commits intomint-for-userfrom
Open
feat: ERC20TransferableReceivable contract gas optimizations#10mliu wants to merge 17 commits intomint-for-userfrom
mliu wants to merge 17 commits intomint-for-userfrom
Conversation
|
Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to cut gas costs on the ERC20TransferableReceivable contract. The changes proposed are based on the findings of a gas profiler and include the following optimizations:
requestNetwork/packages/multi-format/src/hexadecimal-serializable-multi-format.ts
Line 59 in 2b03cd1
Using hardhat-gas-reporter, I measured a decrease in mint call costs from 320k to 177k. These changes cut gas costs per mint by almost half, resulting in savings of approximately $8-10 per mint on mainnet with current gas prices.
Before
After