[2/x] ActiveAccount and NativeAccount traits to call tx kernel functions via self.* on an account
#801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `NativeAccount` and `ActiveAccount` trait with methods calling the tx kernel functions from the corresponding modules.
Fix expects in tests.
struct in scripts.
#802 is resolved.
methods with `#[inline]`. Clean up and fix comments.
remove `Copy` and `Clone`.
bitwalker
approved these changes
Dec 11, 2025
Collaborator
bitwalker
left a comment
bitwalker
left a comment
There was a problem hiding this comment.
It looks like this implements passing accounts by reference (see my feedback from #798), which is awesome!
I mostly skimmed through this, but nothing caught my eye as an issue. Definitely like how this is shaping up! Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #733
Close #788
This PR is stacked on #798 and should be merged after it.
This PR:
NativeAccountandActiveAccounttraits wrapping functions from the corresponding tx kernel library modules;#[component]macro implements these traits for the user account type;#[note_script]macro implementsActiveAccountfor the generatedAccountstruct introduced in [1/x] Pass an account as a parameter to note and tx script #798